oak-team/oak-gpui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
22e31a0d410dc22d2fbeabe8530b6836d107bf78
oak-gpui/crates
T
History
Smit Barmase 22e31a0d41 Fix crash when filtering items in Picker (#37929) 
Closes #37617

We're already using `get` in a bunch of places, this PR updates the
remaining spots to follow the same pattern. Note that the `ix` we read
in `render_match` can sometimes be stale.

The likely reason is that we run the match-update logic asynchronously
(see
[here](https://github.com/zed-industries/zed/blob/138117e0b15664079f5526cb56168750382b49b9/crates/picker/src/picker.rs#L643)).
That means it's possible to render items after the list's [data
update](https://github.com/zed-industries/zed/blob/138117e0b15664079f5526cb56168750382b49b9/crates/picker/src/picker.rs#L652)
but before the [list
reset](https://github.com/zed-industries/zed/blob/138117e0b15664079f5526cb56168750382b49b9/crates/picker/src/picker.rs#L662),
in which case the `ix` can be greater than that of our updated data.

Release Notes:

- Fixed crash when filtering MCP tools.
2025-09-10 23:06:09 +05:30
..
acp_thread
acp: Add keybindings for authorizing tool calls (#37876)
2025-09-10 13:23:46 +00:00
acp_tools
acp: Rename dev command (#36908)
2025-08-25 16:04:44 -06:00
action_log
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
activity_indicator
project: Be explicit about project-searchability for buffers (#37773)
2025-09-08 11:22:36 +00:00
agent
Centralize ZED_STATELESS (#37492)
2025-09-03 22:10:14 +00:00
agent2
acp: Support session modes (e.g. CC plan mode) (#37632)
2025-09-09 13:28:02 -03:00
agent_servers
acp: Ensure connection subprocess gets killed on drop (#37858)
2025-09-09 17:22:19 +00:00
agent_settings
acp: Support session modes (e.g. CC plan mode) (#37632)
2025-09-09 13:28:02 -03:00
agent_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
ai_onboarding
cloud_llm_client: Add another Plan variant (#37852)
2025-09-09 15:51:22 +00:00
anthropic
language_models: Fix beta_headers for Anthropic custom models (#37306)
2025-09-04 06:02:13 +02:00
askpass
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
assets
Use IBM Plex Sans / Lilex (#36084)
2025-08-13 13:25:52 -06:00
assistant_context
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
assistant_slash_command
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
assistant_slash_commands
Make SanitizedPath wrap Path instead of Arc<Path> to avoid allocation (#37106)
2025-08-28 13:32:30 -06:00
assistant_tool
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
assistant_tools
Fix auth in edit_agent evals (#37869)
2025-09-09 19:00:24 +00:00
audio
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
auto_update
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
auto_update_helper
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
auto_update_ui
Remove Chat (#37789)
2025-09-08 21:53:17 -06:00
aws_http_client
bedrock: Fix remaining streaming delays (#33931)
2025-07-22 11:55:24 -04:00
bedrock
bedrock: Inference Config updates (#35808)
2025-08-29 18:13:06 -04:00
breadcrumbs
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
buffer_diff
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
call
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
channel
Remove Chat (#37789)
2025-09-08 21:53:17 -06:00
cli
Remove wsl command line args on non-windows platforms (#37422)
2025-09-03 03:49:04 +00:00
client
Improve macOS version information in telemetry (#37185)
2025-09-05 12:40:47 -04:00
clock
…
cloud_api_client
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
cloud_api_types
Establish WebSocket connection to Cloud (#35734)
2025-08-07 01:28:41 +00:00
cloud_llm_client
cloud_llm_client: Add another Plan variant (#37852)
2025-09-09 15:51:22 +00:00
collab
Remove Chat (#37789)
2025-09-08 21:53:17 -06:00
collab_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
collections
…
command_palette
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
command_palette_hooks
Syntax tree view improvements (#37570)
2025-09-05 14:22:32 +02:00
component
tests: Fix doctests in crates/component (#37716)
2025-09-08 12:23:33 +03:00
context_server
Add configurable timeout for context server tool calls (#33348)
2025-09-03 00:03:56 +00:00
copilot
language_models: Make Copilot Chat resilient to new model vendors and add tokenizer-based token counting (#37118)
2025-09-09 13:28:26 -06:00
crashes
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
credentials_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
dap
settings ui: Add text field support to ui layer (#37868)
2025-09-09 18:48:22 +00:00
dap_adapters
debugger: Add ability to only show stack frame entries from visible work trees (#37061)
2025-08-28 07:53:32 +00:00
db
Centralize ZED_STATELESS (#37492)
2025-09-03 22:10:14 +00:00
debug_adapter_extension
Allow remote loading for DAP-only extensions (#33981)
2025-07-06 14:52:16 +02:00
debugger_tools
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
debugger_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
deepseek
Change DeepSeek max token count to 128k (#36864)
2025-09-04 05:51:48 +00:00
diagnostics
diagnostics: Current file diagnostics view (#34430)
2025-09-08 09:14:24 -06:00
docs_preprocessor
windows: Fix keystroke & keymap (#36572)
2025-08-27 03:24:50 +08:00
edit_prediction
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
edit_prediction_button
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
editor
gpui: Fix blending of colors in HighlightStyle::highlight (#37666)
2025-09-10 18:56:49 +02:00
eval
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
explorer_command_injector
Just Zed instead of Zed Editor (#34146)
2025-07-10 21:08:43 +02:00
extension
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
extension_api
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
extension_cli
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
extension_host
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
extensions_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
feature_flags
cloud_llm_client: Add new Plan variants (#37810)
2025-09-09 00:18:43 +00:00
feedback
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
file_finder
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
file_icons
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
fs
Various fixups to unsafe code (#37651)
2025-09-06 00:27:14 +02:00
fsevent
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
fuzzy
Prevent out of bounds access in recursive_score_match (#35630)
2025-08-06 10:53:20 +02:00
git
git_ui: Show author name on commits in branch picker (#36812)
2025-09-09 18:44:46 +00:00
git_hosting_providers
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
git_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
go_to_line
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
google_ai
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
gpui
gpui: Fix blending of colors in HighlightStyle::highlight (#37666)
2025-09-10 18:56:49 +02:00
gpui_macros
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
gpui_tokio
Use Tokio::spawn instead of getting an executor handle (#36701)
2025-08-21 17:19:57 +00:00
html_to_markdown
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
http_client
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
http_client_tls
…
icons
debugger: Add ability to only show stack frame entries from visible work trees (#37061)
2025-08-28 07:53:32 +00:00
image_viewer
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
inspector_ui
Add option for code context menu items to have dynamic width (#37404)
2025-09-02 20:18:15 -03:00
install_cli
zed: Hide Install CLI menu button on Windows (#37843)
2025-09-09 20:56:08 +02:00
jj
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
jj_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
journal
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
keymap_editor
keymap_editor: Move OpenKeymapEditor action into zed_actions (#37928)
2025-09-10 16:57:05 +00:00
language
gpui: Fix blending of colors in HighlightStyle::highlight (#37666)
2025-09-10 18:56:49 +02:00
language_extension
python: Replace pyright with basedpyright (#35362)
2025-09-08 19:15:17 +00:00
language_model
cloud_llm_client: Add another Plan variant (#37852)
2025-09-09 15:51:22 +00:00
language_models
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
language_onboarding
python: Improve Basedpyright banner styles (#37802)
2025-09-08 18:51:13 -03:00
language_selector
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
language_tools
project: Be explicit about project-searchability for buffers (#37773)
2025-09-08 11:22:36 +00:00
languages
languages: Remove broken pixi environment activation (#37915)
2025-09-10 13:35:16 +00:00
line_ending_selector
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
livekit_api
…
livekit_client
Add Rodio audio pipeline as alternative to current LiveKit pipeline (#36607)
2025-08-21 15:56:16 +02:00
lmstudio
language_models: Fix tool_choice null issue for other providers (#34554)
2025-09-03 01:22:57 +02:00
lsp
python: Replace pyright with basedpyright (#35362)
2025-09-08 19:15:17 +00:00
markdown
agent: Make read_file and edit_file tool call titles more specific (#37639)
2025-09-08 12:57:22 -04:00
markdown_preview
Revert "markdown: Add support for inline HTML img tags inside text (#37264)" (#37893)
2025-09-10 05:34:42 +00:00
media
…
menu
gpui: Store action documentation (#33809)
2025-07-02 21:14:33 -04:00
migrator
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
mistral
language_models: Fix tool_choice null issue for other providers (#34554)
2025-09-03 01:22:57 +02:00
multi_buffer
Add commands to select next/previous siblings in the syntax tree (#35053)
2025-09-08 23:11:53 +00:00
nc
Claude experiment (#34577)
2025-07-17 14:25:55 +00:00
net
windows: Add support for SSH (#29145)
2025-07-08 14:34:57 +00:00
node_runtime
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
notifications
Remove Chat (#37789)
2025-09-08 21:53:17 -06:00
ollama
ollama: Add mistral-nemo (#37723)
2025-09-09 20:08:05 +00:00
onboarding
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
open_ai
open_ai: Trim newline before "data:" prefix and account for the possibility of no space after ":" (#37644)
2025-09-08 22:01:55 +02:00
open_router
language_models: Use /models/user for fetching OpenRouter models (#37534)
2025-09-06 07:42:15 +02:00
outline
Allow outline modal toggling (#37575)
2025-09-09 13:26:35 -06:00
outline_panel
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
panel
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
paths
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
picker
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
prettier
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
project
Fix import not working on first column first row of file (#37746)
2025-09-09 14:18:27 -06:00
project_panel
project_panel: Add action to open file in split pane (#36973)
2025-09-10 00:14:15 +05:30
project_symbols
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
prompt_store
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
proto
git_ui: Show author name on commits in branch picker (#36812)
2025-09-09 18:44:46 +00:00
recent_projects
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
refineable
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
release_channel
…
remote
Revert "Remote: Change "sh -c" to "sh -lc" (#36760)" (#37417)
2025-09-03 14:24:32 -07:00
remote_server
ACP over SSH (#37725)
2025-09-08 14:19:41 -04:00
repl
toolchains: Allow users to provide custom paths to toolchains (#37009)
2025-09-06 00:47:39 +02:00
reqwest_client
reqwest_client: Remove example (#37410)
2025-09-03 00:52:04 +00:00
rich_text
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
rope
Optimize Chunks::seek when offset is in current chunk (#37659)
2025-09-06 04:22:55 +00:00
rpc
Remove Chat (#37789)
2025-09-08 21:53:17 -06:00
rules_library
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
scheduler
Make it possible to support GPUI in the scheduler crate (#37849)
2025-09-09 18:10:03 +00:00
schema_generator
…
search
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
semantic_version
…
session
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
settings
keymap validation: Improve message for action that takes no input (#37877)
2025-09-09 20:56:29 +00:00
settings_profile_selector
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
settings_ui
settings ui: Add text field support to ui layer (#37868)
2025-09-09 18:48:22 +00:00
settings_ui_macros
settings ui: Improve setting proc macro and add scroll to UI (#37581)
2025-09-04 22:30:48 +00:00
snippet
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippet_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippets_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
sqlez
Disable foreign keys in sqlite when running migrations (#37572)
2025-09-06 01:09:50 +00:00
sqlez_macros
…
story
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
storybook
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
streaming_diff
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
sum_tree
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
supermaven
supermaven: Improve completion caching and position validation (#37047)
2025-08-29 16:17:22 -04:00
supermaven_api
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
svg_preview
Fix SVG preview not refreshing on external file changes (#37316)
2025-09-09 13:36:35 -06:00
system_specs
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
tab_switcher
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
task
Fix logic for default values for task variables (#37588)
2025-09-05 14:57:58 +00:00
tasks_ui
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
telemetry
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
telemetry_events
Remove old telemetry events and transformation layer (#36263)
2025-08-15 15:37:52 -04:00
terminal
terminal: Sanitize trailing periods in URL detection (#37684)
2025-09-09 10:39:09 -04:00
terminal_view
terminal_view: Improve path hyperlink navigation by considering the terminal working directory (#36962)
2025-09-09 10:31:37 -04:00
text
Extract a scheduler crate from GPUI to enable unified integration testing of client and server code (#37326)
2025-09-04 17:14:53 +02:00
theme
onboarding: Fix font loading frame delay (#37668)
2025-09-08 11:09:54 -04:00
theme_extension
…
theme_importer
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
theme_selector
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
time_format
…
title_bar
keymap_editor: Move OpenKeymapEditor action into zed_actions (#37928)
2025-09-10 16:57:05 +00:00
toolchain_selector
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
ui
settings_ui: Add Basic Implementation of Language Settings (#37803)
2025-09-08 20:14:36 -04:00
ui_input
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
ui_macros
…
ui_prompt
ui_prompt: Fix prompt dialog is hard to see on large screen (#35348)
2025-07-30 23:03:53 +05:30
util
Update Editor::select_larger_syntax_node (#36971)
2025-09-09 12:13:20 -06:00
util_macros
Remove separator! macro and make path! handle relative paths (#32527)
2025-06-13 06:32:29 +00:00
vercel
openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)
2025-08-15 13:54:24 +03:00
vim
Fix crash when filtering items in Picker (#37929)
2025-09-10 23:06:09 +05:30
vim_mode_setting
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00
watch
acp: Model-specific prompt capabilities for 1PA (#36879)
2025-08-25 14:28:11 -04:00
web_search
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
web_search_providers
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
workspace
workspace: Fix tab bar drop target height when no unpinned tabs present (#37884)
2025-09-10 05:17:36 +05:30
worktree
Allow user-defined worktree names in title bar and platform windows (#36713)
2025-09-09 11:50:58 -06:00
x_ai
Add xAI's Grok Code Fast 1 model (#36959)
2025-08-26 21:08:45 +00:00
zed
keymap_editor: Move OpenKeymapEditor action into zed_actions (#37928)
2025-09-10 16:57:05 +00:00
zed_actions
keymap_editor: Move OpenKeymapEditor action into zed_actions (#37928)
2025-09-10 16:57:05 +00:00
zed_env_vars
Centralize ZED_STATELESS (#37492)
2025-09-03 22:10:14 +00:00
zeta
editor: Wrap placeholder if text overflows (#37919)
2025-09-10 15:38:19 +00:00
zeta_cli
zeta: Check whether data collection is allowed for recent edit history (#37680)
2025-09-07 11:16:49 -06:00
zlog
Various fixups to unsafe code (#37651)
2025-09-06 00:27:14 +02:00
zlog_settings
settings ui: Create settings key trait (#37489)
2025-09-04 15:19:02 -04:00