keymap_editor: Move OpenKeymapEditor action into zed_actions (#37928)

This lets us remove title_bar's dependency on keymap_editor, which in
turns improves dev build times by ~0.5s for me

Release Notes:

- N/A
This commit is contained in:
Piotr Osiewicz
2025-09-10 16:57:05 +00:00
committed by GitHub
parent 6441099a67
commit c0b583c9ef
6 changed files with 6 additions and 14 deletions
Generated
-1
View File
@@ -16710,7 +16710,6 @@ dependencies = [
"db",
"gpui",
"http_client",
"keymap_editor",
"notifications",
"pretty_assertions",
"project",
+1 -8
View File
@@ -37,6 +37,7 @@ use workspace::{
};
pub use ui_components::*;
use zed_actions::OpenKeymapEditor;
use crate::{
persistence::KEYBINDING_EDITORS,
@@ -48,14 +49,6 @@ use crate::{
const NO_ACTION_ARGUMENTS_TEXT: SharedString = SharedString::new_static("<no arguments>");
actions!(
zed,
[
/// Opens the keymap editor.
OpenKeymapEditor
]
);
actions!(
keymap_editor,
[
-1
View File
@@ -42,7 +42,6 @@ rpc.workspace = true
schemars.workspace = true
serde.workspace = true
settings.workspace = true
keymap_editor.workspace = true
smallvec.workspace = true
story = { workspace = true, optional = true }
telemetry.workspace = true
+2 -3
View File
@@ -29,7 +29,6 @@ use gpui::{
IntoElement, MouseButton, ParentElement, Render, StatefulInteractiveElement, Styled,
Subscription, WeakEntity, Window, actions, div,
};
use keymap_editor;
use onboarding_banner::OnboardingBanner;
use project::{Project, WorktreeSettings};
use remote::RemoteConnectionOptions;
@@ -705,7 +704,7 @@ impl TitleBar {
"Settings Profiles",
zed_actions::settings_profile_selector::Toggle.boxed_clone(),
)
.action("Keymap Editor", Box::new(keymap_editor::OpenKeymapEditor))
.action("Keymap Editor", Box::new(zed_actions::OpenKeymapEditor))
.action(
"Themes…",
zed_actions::theme_selector::Toggle::default().boxed_clone(),
@@ -753,7 +752,7 @@ impl TitleBar {
"Settings Profiles",
zed_actions::settings_profile_selector::Toggle.boxed_clone(),
)
.action("Key Bindings", Box::new(keymap_editor::OpenKeymapEditor))
.action("Key Bindings", Box::new(zed_actions::OpenKeymapEditor))
.action(
"Themes…",
zed_actions::theme_selector::Toggle::default().boxed_clone(),
+1 -1
View File
@@ -17,7 +17,7 @@ pub fn app_menus() -> Vec<Menu> {
name: "Settings".into(),
items: vec![
MenuItem::action("Open Settings", super::OpenSettings),
MenuItem::action("Open Key Bindings", keymap_editor::OpenKeymapEditor),
MenuItem::action("Open Key Bindings", zed_actions::OpenKeymapEditor),
MenuItem::action("Open Default Settings", super::OpenDefaultSettings),
MenuItem::action(
"Open Default Key Bindings",
+2
View File
@@ -36,6 +36,8 @@ actions!(
OpenDefaultKeymap,
/// Opens account settings.
OpenAccountSettings,
/// Opens the keymap editor.
OpenKeymapEditor,
/// Opens server settings.
OpenServerSettings,
/// Quits the application.