oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
30,481 Commits 1 Branch 0 Tags
fda6eda3c2abcbe90af48bd112ee560eb63706e7
Commit Graph
30481 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Antonio Scandurra fda6eda3c2 Fix @-mentioning threads when their summary isn't ready yet (#36664) 
Release Notes:

- N/A
 2025-08-21 08:57:28 +00:00
Kirill Bulatov ed84767c9d Fix overlooked Clippy lints (#36659) 
Follow-up of https://github.com/zed-industries/zed/pull/36557 that is
needed after https://github.com/zed-industries/zed/pull/36652

Release Notes:

- N/A
 2025-08-21 06:48:04 +00:00
Kirill Bulatov cde0a5dd27 Add a non-style lint exclusion (#36658) 
Follow-up of https://github.com/zed-industries/zed/pull/36651
Restores https://github.com/zed-industries/zed/pull/35955 footgun guard.

Release Notes:

- N/A
 2025-08-21 06:36:57 +00:00
Sachith Shetty 68f97d6069 editor: Use highlight_text to highlight matching brackets, fix unnecessary inlay hint highlighting (#36540) 
Closes #35981

Release Notes:

- Fixed bracket highlights overly including parts of inlays when
highlighting

Before -
<img width="1480" height="602" alt="Screenshot from 2025-08-19 17-15-06"
src="https://github.com/user-attachments/assets/8e6b5ed8-f133-4867-8352-ed93441fbd8b"
/>

After -
<img width="1480" height="602" alt="Screenshot from 2025-08-19 17-24-26"
src="https://github.com/user-attachments/assets/1314e54e-ecf9-4280-9d53-eed6e96e393f"
/>
 2025-08-21 09:27:41 +03:00
Kirill BulatovDavid KleingeldMikayla MakiDavid Kleingeld
 		5dcb90858e Stop waiting for part of LSP responses on remote Collab clients' part (#36557) 
Instead of holding a connection for potentially long LSP queries (e.g.
rust-analyzer might take minutes to look up a definition), disconnect
right after sending the initial request and handle the follow-up
responses later.

As a bonus, this allows to cancel previously sent request on the local
Collab clients' side due to this, as instead of holding and serving the
old connection, local clients now can stop previous requests, if needed.

Current PR does not convert all LSP requests to the new paradigm, but
the problematic ones, deprecating `MultiLspQuery` and moving all its
requests to the new paradigm.

Release Notes:

- Improved resource usage when querying LSP over Collab

---------

Co-authored-by: David Kleingeld <git@davidsk.dev>
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: David Kleingeld <davidsk@zed.dev>
 2025-08-21 09:24:34 +03:00
Conrad Irwin c731bb6d91 Re-add redundant clone (#36652) 
Although I said I'd do this, I actually didn't...

Updates #36651

Release Notes:

- N/A
 2025-08-20 21:08:49 -06:00
Conrad Irwin 4b03d791b5 Remove style lints for now (#36651) 
Closes #36577

Release Notes:

- N/A
 2025-08-20 20:38:30 -06:00
Agus Zubiaga 9a3e4c47d0 acp: Suggest upgrading to preview instead of latest (#36648) 
A previous PR changed the install command from `@latest` to `@preview`,
but the upgrade command kept suggesting `@latest`.

Release Notes:

- N/A
 2025-08-21 00:52:38 +00:00
Ben Brandt 568e1d0a42 acp: Add e2e test support for NativeAgent (#36635) 
Release Notes:

- N/A
 2025-08-21 00:36:50 +00:00
Agus Zubiaga 6f242772cc acp: Update to 0.0.30 (#36643) 
See: https://github.com/zed-industries/agent-client-protocol/pull/20

Release Notes:

- N/A
 2025-08-21 00:10:36 +00:00
张小白 8ef9ecc91f windows: Fix RevealInFileManager (#36592) 
Closes #36314

This PR takes inspiration from [Electron’s
implementation](https://github.com/electron/electron/blob/dd54e84a58531b52680f7f736f593ee887eff6a7/shell/common/platform_util_win.cc#L268-L314).

Before and after:



https://github.com/user-attachments/assets/53eec5d3-23c7-4ee1-8477-e524b0538f60



Release Notes:

- N/A
 2025-08-21 08:08:54 +08:00
Ben Kunkle 3dd362978a docs: Add table of all actions (#36642) 
Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-08-20 23:41:06 +00:00
Agus Zubiaga 74c0ba980b acp: Reliably suppress gemini abort error (#36640) 
https://github.com/zed-industries/zed/pull/36633 relied on the prompt
request responding before cancel, but that's not guaranteed


Release Notes:

- N/A
 2025-08-20 23:32:17 +00:00
Marshall Bowers c20233e0b4 agent_ui: Fix signed-in check in Zed provider configuration (#36639) 
This PR fixes the check for if the user is signed in in the Agent panel
configuration.

Supersedes https://github.com/zed-industries/zed/pull/36634.

Release Notes:

- Fixed the user's plan badge near the Zed provider in the Agent panel
not showing despite being signed in.
 2025-08-20 23:09:09 +00:00
Agus Zubiaga ffb995181e acp: Supress gemini aborted errors (#36633) 
This PR adds a temporary workaround to supress "Aborted" errors from
Gemini when cancelling generation. This won't be needed once
https://github.com/google-gemini/gemini-cli/pull/6656 is generally
available.

Release Notes:

- N/A
 2025-08-20 22:30:25 +00:00
Conrad IrwinandDanilo Leal 5120b6b7f9 acp: Handle Gemini Auth Better (#36631) 
Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
 2025-08-20 16:12:41 -06:00
Julia Ryan c9c708ff08 nix: Re-enable nightly builds (#36632) 
Release Notes:

- N/A
 2025-08-20 21:43:53 +00:00
Agus Zubiaga 9e34bb3f05 acp: Hide feedback buttons for external agents (#36630) 
Release Notes:

- N/A
 2025-08-20 21:35:48 +00:00
Cole Miller 595cf1c6c3 acp: Rename assistant::QuoteSelection and support it in agent2 threads (#36628) 
Release Notes:

- N/A
 2025-08-20 21:31:25 +00:00
Agus Zubiaga d1820b183a acp: Suggest installing gemini@preview instead of latest (#36629) 
Release Notes:

- N/A
 2025-08-20 21:26:07 +00:00
Danilo Leal fb7edbfb46 thread_view: Add recent history entries & adjust empty state (#36625) 
Release Notes:

- N/A
 2025-08-20 18:01:22 -03:00
Agus Zubiaga 02dabbb9fa acp thread view: Do not go into editing mode if unsupported (#36623) 
Release Notes:

- N/A
 2025-08-20 20:05:53 +00:00
Joseph T. Lyons fa8bef1496 Bump Zed to v0.202 (#36622) 
Release Notes:

-N/A
 2025-08-20 20:05:30 +00:00
Cole Miller 739e4551da Fix typo in Excerpt::contains (#36621) 
Follow-up to #36524 

Release Notes:

- N/A
 2025-08-20 19:30:11 +00:00
Ben Brandt b0bef3a9a2 agent2: Clean up tool descriptions (#36619) 
schemars was passing along the newlines from the doc comments. This
should make these closer to the markdown file versions we had in the old
agent.

Release Notes:

- N/A
 2025-08-20 19:17:07 +00:00
Agus Zubiaga 2813073d7b message editor: Only allow types of content the agent can handle (#36616) 
Uses the new
[`acp::PromptCapabilities`](https://github.com/zed-industries/agent-client-protocol/blob/a39b7f635d67528f0a4e05e086ab283b9fc5cb93/rust/agent.rs#L194-L215)
to disable non-file mentions and images for agents that don't support
them.

Release Notes:

- N/A
 2025-08-20 19:04:10 +00:00
Piotr Osiewicz 74ce543d8b clippy: println_empty_string & non_minimal_cfg (#36614) 
- **clippy: Fix println-empty-string**
- **clippy: non-minimal-cfg**

Related to #36577

Release Notes:
- N/A
 2025-08-20 18:45:40 +00:00
Cole MillerandConrad Irwin b6722ca3c8 Remove special case for singleton buffers from MultiBufferSnapshot::anchor_at (#36524) 
This may be responsible for a panic that we've been seeing with
increased frequency in agent2 threads.

Release Notes:

- N/A

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
 2025-08-20 18:43:29 +00:00
Umesh Yadav ec8106d1db Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613) 
Related: #36577

Release Notes:

- N/A
 2025-08-20 20:14:30 +02:00
Cole Miller 41e28a7185 Add tracked buffers for agent2 mentions (#36608) 
Release Notes:

- N/A
 2025-08-20 14:01:18 -04:00
Bennet Bo FennerandBen Brandt 8334cdb358 agent2: Port feedback (#36603) 
Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
 2025-08-20 19:10:43 +02:00
Antonio Scandurra d0fb6120d9 Fix scrollbar flicker when streaming agent2 response (#36606) 
This was caused by calling `list_state.splice` on updated entries. We
don't need to splice the entry, as we'll recompute its measurements
automatically when we render it.

Release Notes:

- N/A
 2025-08-20 16:39:46 +00:00
Antonio Scandurra 699f58aeba Capture telemetry when requesting completions in agent2 (#36600) 
Release Notes:

- N/A
 2025-08-20 16:04:32 +00:00
Umesh Yadav 1e6cefaa56 Fix clippy::len_zero lint style violations (#36589) 
Related: #36577

Release Notes:

- N/A

---------

Signed-off-by: Umesh Yadav <git@umesh.dev>
 2025-08-20 14:35:59 +00:00
tidely 92352f97ad Fix clippy::map_clone lint violations (#36585) 
#36577

Release Notes:

- N/A
 2025-08-20 16:34:52 +02:00
Antonio Scandurra eaf6b56163 Miscellaneous UX fixes for agent2 (#36591) 
Release Notes:

- N/A
 2025-08-20 13:56:39 +00:00
Bennet Bo FennerAgus ZubiagaCole Miller
 		85865fc950 agent2: New thread from summary (#36578) 
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
Co-authored-by: Cole Miller <cole@zed.dev>
 2025-08-20 13:54:00 +00:00
Lukas Wirth c5040bd0a4 remote: Do not leave client hanging on unhandled proto message (#36590) 
Otherwise the client will wait for a response that never arrives,
causing the task to lock up

Release Notes:

- N/A
 2025-08-20 13:41:58 +00:00
tidely bc79076ad3 Fix clippy::manual_map lint violations (#36584) 
#36577

Release Notes:

- N/A
 2025-08-20 15:17:28 +02:00
Antonio Scandurra de12633591 Wait for agent2 feature flag before loading panel (#36583) 
Release Notes:

- N/A
 2025-08-20 15:02:40 +02:00
tidely 6ed29fbc34 Enforce style lints which do not have violations (#36580) 
Release Notes:

- N/A
 2025-08-20 14:07:37 +02:00
Antonio Scandurra 4ee565cd39 Fix mentions roundtrip from/to database and other history bugs (#36575) 
Release Notes:

- N/A
 2025-08-20 12:03:20 +00:00
tidely f80a0ba056 Move clippy lints which aren't apart of the style category (#36579) 
Move lints which aren't apart of the style category.

Motivation: They might get accidentally get reverted when we turn the
style category on again and remove the manual lint enforcements.

Release Notes:

- N/A
 2025-08-20 11:26:45 +00:00
tidely 7bdc99abc1 Fix clippy::redundant_clone lint violations (#36558) 
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.

A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.

I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.

Release Notes:

- N/A
 2025-08-20 12:20:13 +02:00
Piotr Osiewicz cf7c64d77f lints: A bunch of extra style lint fixes (#36568) 
- **lints: Fix 'doc_lazy_continuation'**
- **lints: Fix 'doc_overindented_list_items'**
- **inherent_to_string and io_other_error**
- **Some more lint fixes**
- **lints: enable bool_assert_comparison, match_like_matches_macro and
wrong_self_convention**


Release Notes:

- N/A
 2025-08-20 12:05:58 +02:00
Bennet Bo Fenner a32a264508 agent2: Use correct completion intent when generating summary (#36573) 
Release Notes:

- N/A
 2025-08-20 10:03:35 +00:00
Bennet Bo Fenner 0a80209c5e agent2: Fix remaining update_model_request_usage todos (#36570) 
Release Notes:

- N/A
 2025-08-20 09:54:26 +00:00
Finn Evers 83d361ba69 Add more string and comment overrides (#36566) 
Follow-up to #36469

Part of the issue was that we hadn't defined comment and string
overrides for some languages. Hence, even after the fix edit predictions
would show up in comments for me in e.g. JSONC files.

This PR adds some more overrides where possible for this repo to ensure
this happens less frequently.

Release Notes:

- N/A
 2025-08-20 09:29:53 +00:00
Bennet Bo FennerandAntonio Scandurra 4290f043cd agent2: Fix token count not updating when changing model/toggling burn mode (#36562) 
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
 2025-08-20 09:29:05 +00:00
tidely 44941b5dfe Fix clippy::for_kv_map lint violations (#36493) 
Release Notes:

- N/A
 2025-08-20 11:22:19 +02:00