Nathan Sobo
e5ada92b7b
Remove initialize from the Element trait ( #3338 )
...
Initially, we imagined registering keyboard handlers in the initialize
phase so we would understand the relationships between focus handles
during the layout pass, which would allow us to assign assign `focus_in`
styles that impact layout.
However, we soon realized that many elements aren't created until paint
time anyway, such as within the uniform list. Since it's impossible to
know prior to paint whether an element contains the focused element, it
makes more sense to eliminate the `focus_in` styling helper.
Release Notes:
- N/A
2023-11-15 19:36:35 -07:00
Conrad Irwin
0e79a7f26b
collab ui2 ( #3339 )
...
- Move placeholder titlebar render to collab_ui
Release Notes:
- N/A
2023-11-15 16:21:52 -07:00
Conrad Irwin
793fa6e3a4
Move placeholder titlebar render to collab_ui
2023-11-15 16:09:21 -07:00
Conrad Irwin
84bcbf1128
Add collab_ui2
2023-11-15 16:08:03 -07:00
Nathan Sobo
4f09633379
Remove focus_in styling helper
2023-11-15 14:17:49 -07:00
Nathan Sobo
c6b374ebc9
Remove initialize method from Element trait
2023-11-15 14:11:19 -07:00
Conrad Irwin
26d90a5e48
Leaky, but better, test abstraction ( #3337 )
...
Make test view creation a bit more ergonomic
Release Notes:
- N/A
2023-11-15 14:09:02 -07:00
Conrad Irwin
0a51784dd0
Leaky, but better, test abstraction
2023-11-15 14:01:10 -07:00
Conrad Irwin
19c0b390d2
FileFinder tests ( #3336 )
...
Also including:
* Fixes for focus when closing the last item in a pane
* Workspace#active_item_as::<Editor>()
* cx.simulate_input()
Release Notes:
- N/A
2023-11-15 13:24:34 -07:00
Conrad Irwin
cebc8428c8
FileFinder tests
2023-11-15 13:16:28 -07:00
Antonio Scandurra
33a808a49b
WIP
2023-11-15 20:41:09 +01:00
Antonio Scandurra
ffcc1cbf77
Clear the state of keystroke matchers when focus changes ( #3335 )
...
Release Notes:
- N/A
2023-11-15 20:41:01 +01:00
Antonio Scandurra and Nathan Sobo
759ce7440c
Avoid unnecessary call to with_element_id in RenderViewWith
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 20:12:30 +01:00
Antonio Scandurra and Nathan Sobo
1d04dc5dbf
Clear the state of keystroke matchers when focus changes
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 20:11:07 +01:00
Antonio Scandurra
3978d4e872
Show fold indicators ( #3334 )
...
Release Notes:
- N/A
2023-11-15 20:10:24 +01:00
Antonio Scandurra
08dfcba68a
Fix panic when painting blocks
2023-11-15 20:02:35 +01:00
Antonio Scandurra and Nathan Sobo
c225a3e5af
Don't use Mutex or Arc now that app state is not Send
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 18:50:34 +01:00
Antonio Scandurra and Nathan Sobo
c7b7f7dfd5
Move render_view into View::render_with
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 18:50:09 +01:00
Joseph T. Lyons
d791fc707a
v0.114.x dev
2023-11-15 12:47:40 -05:00
Antonio Scandurra and Nathan Sobo
9ff238921f
Fix clicking on code action and fold indicators
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 18:29:53 +01:00
Antonio Scandurra and Nathan Sobo
17b8e4a684
Handle clicking folded ranges
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 18:19:26 +01:00
Antonio Scandurra and Nathan Sobo
3ff8c78b58
Return a Fold struct when querying the FoldMap
...
This contains a new `id` field that lets us distinguish among folds.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-11-15 17:09:59 +01:00
Conrad Irwin
1db4fab3ab
Add command palette tests and simulate_keystrokes ( #3330 )
...
Release Notes:
- N/A
2023-11-15 08:00:41 -07:00
Kirill Bulatov
aa0563c656
More detailed errors when opening files ( #3333 )
...
Release Notes:
- N/A
2023-11-15 16:31:48 +02:00
Kirill Bulatov
888098bad2
More detailed errors when opening files
2023-11-15 16:20:00 +02:00
Antonio Scandurra
851a60a68e
Render fold indicators in the gutter
2023-11-15 14:07:37 +01:00
Antonio Scandurra
c0f43d964c
Introduce rename in editor2 ( #3331 )
...
Release Notes:
- N/A
2023-11-15 11:15:08 +01:00
Antonio Scandurra
786cc59d7a
Fix formatting
2023-11-15 11:07:32 +01:00
Antonio Scandurra
45381e566c
Fix focus management on editor when renaming
2023-11-15 11:05:09 +01:00
Antonio Scandurra
003e4bc241
Extract out a register_actions function
2023-11-15 09:53:32 +01:00
Antonio Scandurra
feeb44c122
Merge remote-tracking branch 'origin/main' into editor2-rename
...
# Conflicts:
# crates/editor2/src/editor.rs
# crates/editor2/src/element.rs
# crates/gpui2/src/style.rs
2023-11-15 09:51:33 +01:00
Antonio Scandurra
c3094b7c3d
Introduce gpui::render_view
2023-11-15 09:45:23 +01:00
Antonio Scandurra
1def355d44
Don't return Result from TextStyle::highlight
2023-11-15 09:10:46 +01:00
Conrad Irwin
c81bd288d4
Fix test
2023-11-14 23:47:08 -07:00
Conrad Irwin
91b54b352b
Add command palette tests and simulate_keystrokes
2023-11-14 23:22:51 -07:00
Nathan Sobo
e37d7f5b0e
Fix click events by notifying when we assign pending_mouse_down ( #3329 )
...
We need to notify when we set the pending mouse down so we attach the
mouse up event listener before the mouse button is released.
Release Notes:
- N/A
2023-11-14 19:55:23 -07:00
Nathan Sobo
32ad486a8e
Document contexts
2023-11-14 19:52:51 -07:00
Nathan Sobo
00d8921ae9
Fix click events by notifying when we assign pending_mouse_down
2023-11-14 19:22:41 -07:00
Max Brunsfeld
f9a5e141aa
Fix uncached raster_bounds computation and font selection ( #3328 )
...
This fixes some slowness we noticed when scrolling an editor in `zed2`.
2023-11-14 17:27:12 -08:00
8de8615176
Fix uncached raster_bounds computation and font selection
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-11-14 17:19:10 -08:00
Mikayla Maki
96f0257fb3
Simplify element types ( #3318 )
...
This PR does away with the extra type parameters on Div and instead
introduces two wrapper elements, `Stateful` and `Focusable`. All of the
interactivity is stored on `Interactivity` and `InteractiveState`, which
is stored on the base element. The wrappers simply control what methods
are available to call.
Not sure this is fully working, but a smoke test does work.
/cc @as-cii @ConradIrwin
Release Notes:
- N/A
2023-11-14 16:03:20 -08:00
Mikayla
817c6dd49c
remove dbg
2023-11-14 15:57:23 -08:00
Mikayla
b81b96f353
Merge branch 'element-types' of github.com:zed-industries/zed into element-types
2023-11-14 15:55:53 -08:00
Mikayla
7f72df6dcf
Merge branch 'main' into element-types
2023-11-14 15:49:10 -08:00
Mikayla Maki
df64a3c701
Not working yet file-finder2 ( #3321 )
...
Porting file_finder
Release Notes:
- N/A
2023-11-14 15:22:59 -08:00
Conrad Irwin
1109cd11c8
Abandon ship
2023-11-14 16:17:24 -07:00
Nathan Sobo and Julia
bef4df5df9
Return an id from Element::element_id instead of calling cx.with_element_id
...
Co-Authored-By: Julia <julia@zed.dev >
2023-11-14 16:05:28 -07:00
Max Brunsfeld
ca63a99736
Enable tests in project panel 2 ( #3325 )
2023-11-14 15:02:51 -08:00
Max Brunsfeld
860959fe13
Implement simulated prompts in TestPlatform
2023-11-14 14:56:50 -08:00
Mikayla
6b25841e2a
WIP
2023-11-14 14:48:34 -08:00
Nathan Sobo