oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,629 Commits 1 Branch 0 Tags
dd730549df0794de8945afcaf3c28fd9c4476257
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Conrad IrwinandMax 385cbfea2d Tidy up context usage 
Co-Authored-By: Max <max@zed.dev>
 2024-01-05 16:35:20 -07:00
Conrad IrwinandMax 709682e8bc Tidy up TestContext lifecycle 
Co-Authored-By: Max <max@zed.dev>
 2024-01-05 16:31:41 -07:00
Conrad IrwinandMax c7568a7d37 All the following tests 
Co-Authored-By: Max <max@zed.dev>
 2024-01-05 16:18:01 -07:00
Conrad Irwin 204ef451d0 Merge branch 'main' into following-tests 2024-01-05 16:14:12 -07:00
Conrad Irwin f239a8292e More following tests 2024-01-05 16:13:40 -07:00
Conrad IrwinandMax 81d707adbc Port 1.00 following tests 
Co-Authored-By: Max <max@zed.dev>
 2024-01-05 15:55:33 -07:00
Conrad Irwin 573b74906f Deploy tweaks (#3920) 
Bugs from the 0.34.0 collab nightly deploy
 2024-01-05 13:32:47 -07:00
Conrad Irwin 0dfeae6e24 Deploy tweaks 2024-01-05 13:24:29 -07:00
Conrad Irwin 15d8fed378 collab 0.34.0 2024-01-05 11:30:00 -07:00
Conrad Irwin 1a993ca496 Read-only access for channel guests (#3841) 2024-01-05 11:21:18 -07:00
Conrad Irwin 460b364daf Disable Dangerous Downtime-causing Default (#3873) 
According to
https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates

you can specify whether to disable automatic DNS record
creation for the certificate upon the load balancer’s creation using the
do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you
specify true, we will not automatically create a DNS A record at the
apex of your domain to support the SSL certificate.
 2024-01-05 11:21:03 -07:00
Conrad Irwin c066480e31 Fix dock right click labels (#3626) 
Release Notes:

- N/A
 2024-01-05 10:08:58 -07:00
Conrad Irwin 3c0052850c Merge branch 'main' into channel-guests 2024-01-05 10:05:59 -07:00
Conrad Irwin df0076a4eb Better TestWindow support (#3876) 
Adding guest roles led us down a rabbit hole where we'd have liked to
rely on a
side-effect of activating a window in tests; but the test window didn't
implement that.

Looking into that, I realized our TestWindow wasn't doing a great job of
emulating the MacWindow, so this makes the two more similar.
 2024-01-05 09:59:48 -07:00
Conrad Irwin fa73cf3983 Correct dock menu names 2024-01-05 09:58:07 -07:00
Conrad Irwin 06ab986599 fmt 2024-01-05 09:52:39 -07:00
Conrad Irwin fff415e3e9 Improve deactivate simulation 2024-01-04 22:06:52 -07:00
Conrad Irwin 1f09f98c9b Remove un-needed change 2024-01-04 22:06:12 -07:00
Conrad Irwin 319bfff14e Fix more tests broken by timing change 2024-01-04 21:34:56 -07:00
Conrad Irwin 9840a8427e Add LeakDetector for gpui2 (#3903) 
Needed for debugging some fun following tests
 2024-01-04 21:31:37 -07:00
Conrad IrwinandJulia 5037cca7ec Add LeakDetector for gpui2 
Co-Authored-By: Julia <julia@zed.dev>
 2024-01-04 20:29:44 -07:00
Conrad Irwin 22c3eb7d5f Uncomment editor tests (#3896) 
Co-Authored-By: Julia <julia@zed.dev>

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
 2024-01-04 20:00:04 -07:00
Conrad Irwin 4a7233f8f0 Fixy fix 2024-01-04 19:43:12 -07:00
Conrad IrwinandJulia 931bd687dc Uncomment editor tests 
Co-Authored-By: Julia <julia@zed.dev>
 2024-01-04 13:58:19 -07:00
Conrad Irwin be426e67cc Tidy up guest count 2024-01-04 12:22:45 -07:00
Conrad Irwin d2afc97b53 Tidy up branch 2024-01-04 11:55:14 -07:00
Conrad Irwin 4e1b9873b4 Implement "open in terminal" (#3888) 2024-01-04 10:35:17 -07:00
Conrad Irwin fcf7007e0b let search happen too 2024-01-04 09:48:47 -07:00
Conrad Irwin 4e310b99aa Implement "open in terminal" 2024-01-04 09:45:39 -07:00
Conrad Irwin 427e7f6b4f Read only permissions for project panel too 2024-01-04 09:40:12 -07:00
Conrad Irwin 9d146a2a6f Fix vim tests 2024-01-04 08:59:31 -07:00
Conrad Irwin 5c32dd5688 Better TestWindow support 2024-01-04 08:00:40 -07:00
Conrad Irwin 26a4b6af0b Disable Dangerous Downtime-causing Default 
According to https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates

you can specify whether to disable automatic DNS record
creation for the certificate upon the load balancer’s creation using the
do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you
specify true, we will not automatically create a DNS A record at the
apex of your domain to support the SSL certificate.
 2024-01-03 19:55:17 -07:00
Conrad Irwin 1930258d39 Show guests in fewer places 2024-01-03 19:31:43 -07:00
Conrad Irwin c3402024bc Fix privilege escalation when guests invite people 2024-01-03 19:31:43 -07:00
Conrad Irwin 9fe17a1d1d Prevent guests from screen-sharing, unmuting or screen sharing 2024-01-03 19:31:43 -07:00
Conrad Irwin 6877bd4969 Make read only buffers feel more read only 2024-01-03 19:31:43 -07:00
Conrad Irwin 84171787a5 Track read_only per project and buffer 
This uses a new enum to avoid confusing booleans
 2024-01-03 19:31:43 -07:00
Conrad Irwin bf304b3fe7 Track room participant role 
(Also wire that through to project collaboration rules for now)
 2024-01-03 19:30:32 -07:00
Conrad Irwin 88ed5f7290 Plumbing to pass role for room participants 2024-01-03 19:30:32 -07:00
Conrad Irwin a801c85a1b TEMP 2024-01-03 19:30:32 -07:00
Conrad Irwin e43be065d9 Fix position calculation (#3854) 
Fixes a bug where the context menu appears in the wrong place
 2024-01-02 18:36:57 -07:00
Conrad Irwin 4ab5fa564d Fix overlay position calculation 
(but keep rounding)
 2024-01-02 18:17:26 -07:00
Conrad Irwin 09951208a7 Round tooltip co-ordinates (#3836) 
There was a hypothesis that this would fix border rendering.

It doesn't :D; but it does at least mean that they are always
consistently
broken, so it may be easier to fix.
 2024-01-02 15:06:19 -07:00
Conrad Irwin 12f06a96d0 Merge branch 'main' into overlay-rounding 2024-01-02 12:35:38 -07:00
Conrad Irwin 2e349a806a Round tooltip co-ordinates 2024-01-02 10:12:57 -07:00
Conrad Irwin b8cdcf4e93 fix theme selector gaps (#3682) 
- Don't scroll beyond end of uniform list
- Restore position of uniform_list padding

[[PR Description]]

Release Notes:

- N/A
 2023-12-15 13:27:17 -07:00
Conrad Irwin 3c3e5ed7d8 Fix bug where vim commands were copied on each update_matches (#3680) 
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.

Release Notes:

- N/A
 2023-12-15 13:20:10 -07:00
Conrad Irwin 2fe9a1df21 Restore position of uniform_list padding 
It should be inside the scrollable area.
 2023-12-15 13:18:51 -07:00
Conrad Irwin a35fdf45fc Don't scroll beyond end of uniform list 2023-12-15 12:54:12 -07:00
Conrad Irwin d0dbf8e1e2 Fix bug where vim commands were copied on each update_matches 
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.
 2023-12-15 11:59:06 -07:00
Conrad Irwin 70a14bb22f Implement user menu (#3636) 
Release Notes:

- N/A
 2023-12-14 20:30:28 -07:00
Conrad Irwin 7e1d61d116 Merge branch 'main' into user-menu 2023-12-14 20:18:20 -07:00
Conrad Irwin 2efd7cedbc Ignore invisible layers for mouse events (#3651) 
Fixes clicking in the top/bottom 100px of the editor


Release Notes:

- N/A
 2023-12-14 12:01:45 -07:00
Conrad Irwin 4e1b4c4390 Refactor editor to be more clear about stacking 2023-12-14 10:48:15 -07:00
Conrad Irwin d8cb0e8a2a Fix z-indexes in editor element 
* Ensure that scroll events from blocks scroll the editor
* Ensure that scroll bars show behind hover things
 2023-12-14 10:36:16 -07:00
Conrad Irwin c2c7eead8a Robustify checks for visibility 2023-12-14 10:02:54 -07:00
Conrad Irwin 17a80ca09b Ignore invisible layers for mouse events 2023-12-14 09:44:04 -07:00
Conrad Irwin 7899833367 Don't hang the app when signing in offline 2023-12-13 15:52:43 -07:00
Conrad Irwin 3094cb749e Implement user menu 2023-12-13 14:14:03 -07:00
Conrad Irwin 426d298173 Port project_symbols (#3634) 
Release Notes:

- N/A
 2023-12-13 14:13:25 -07:00
Conrad Irwin 9ff73d3a0a Port project_symbols 2023-12-13 13:43:39 -07:00
Conrad Irwin 19e842b860 fix overlay positions (#3621) 
- Fix typo in overlay positioning code
- Make overlay positioning more robust

Release Notes:

- N/A
 2023-12-12 22:13:56 -07:00
Conrad Irwin e91ecec8cd fix modal exchange (#3620) 
- Fix opening GoToLine from Command
- Extend test to cover go_to_line behavior too

Release Notes:

- N/A
 2023-12-12 21:30:34 -07:00
Conrad Irwin a055a4c163 Make overlay positioning more robust 
Previously we would either switch anchor or snap, now we first try switching
anchor (if desired) and then snap to window regardless.
 2023-12-12 21:28:58 -07:00
Conrad Irwin fa36adbf1f Fix typo in overlay positioning code 2023-12-12 21:14:48 -07:00
Conrad Irwin 979db25e91 Extend test to cover go_to_line behavior too 
(It's also been broken and fixed a few times along the way)
 2023-12-12 20:53:54 -07:00
Conrad Irwin a2f0accb74 Fix opening GoToLine from Command 
This was broken because of the async hop introduced by should_dismiss.

Change that API to instead be syncronous, and require that implementors
(of which there is only one) to call dismiss again if they want to.
 2023-12-12 20:46:27 -07:00
Conrad Irwin c94c6614ed vim2 (#3619) 
Fix vim command tests by restoring the spawn in command palette's
confirm


Release Notes:

- N/A
 2023-12-12 19:40:54 -07:00
Conrad Irwin 630997db28 And restore the command palette spawn behaviour 2023-12-12 19:27:09 -07:00
Conrad Irwin b65129437f vim2 (#3618) 
- Uncomment editor event tests
- Uncomment vim search tests

Just command left

Release Notes:

- N/A
 2023-12-12 19:19:08 -07:00
Conrad Irwin 1a86e4ff96 Fix vim toggle on welcome 2023-12-12 19:03:54 -07:00
Conrad Irwin a9349267ec hah, oops 2023-12-12 18:54:35 -07:00
Conrad Irwin a656d11fed Fix vim2 search tests 2023-12-12 18:39:42 -07:00
Conrad Irwin 3088cbea68 Uncomment vim search tests 2023-12-12 15:29:17 -07:00
Conrad Irwin c43969eaed Uncomment editor event tests 2023-12-12 15:29:10 -07:00
Conrad Irwin 149e90c3d9 vim2 (#3597) 
- MOAR TESTS

[[PR Description]]

Release Notes:

- N/A
 2023-12-11 16:42:03 -07:00
Conrad Irwin 3779316e4e Fix scroll tests 
For some reason in gpui2, the window contains an extra 59px of space..
 2023-12-11 16:12:17 -07:00
Conrad Irwin 2d59492aac Most tests now... 2023-12-11 15:25:30 -07:00
Conrad Irwin e37173fe97 And some more 2023-12-11 15:14:13 -07:00
Conrad Irwin 3baf125f4a All the easy tests? 2023-12-11 15:13:11 -07:00
Conrad Irwin d12eb0581a vim2 (#3594) 
- First round of vim tests

Add `observe_keystrokes` back to gpui2
Allow multiple actions to match a given key event

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
 2023-12-11 15:06:51 -07:00
Conrad Irwin 1e89092d62 MOAR TESTS 2023-12-11 15:06:33 -07:00
Conrad Irwin 303189e086 Fix warnings 2023-12-11 14:54:58 -07:00
Conrad Irwin 4942b1962b Moar tests 2023-12-11 14:21:21 -07:00
Conrad Irwin d1805d8ada First round of vim tests 2023-12-11 14:16:25 -07:00
Conrad Irwin fcbc18a380 vim-flight entertainment (#3574) 
- vim2 compiling (but mostly commented out)
- More code written, similar lack of workingness so far

Still todo:
[ ] Figure out the focus/blur stuff
[ ] Uncoment more code
[ ] Fix VimTestContext
[ ] Uncomment the tests

Release Notes:

- N/A
 2023-12-11 12:11:13 -07:00
Conrad Irwin f35453caad COmment out tests again for now 2023-12-11 11:40:54 -07:00
Conrad Irwin 8ed642dc16 Clear out easy todo!()s 2023-12-11 11:00:55 -07:00
Conrad Irwin dd42adc4e5 Remove warnigns 2023-12-11 10:45:27 -07:00
Conrad Irwin af7c93b8d5 Merge branch 'main' into vim2 2023-12-11 10:19:18 -07:00
Conrad Irwin c97c9f98c0 Revert actions! changes 2023-12-11 10:19:03 -07:00
Conrad Irwin 59d0feafc5 actions3 (#3586) 
- Fix action registrations

Release Notes:

- N/A
 2023-12-11 09:48:57 -07:00
Conrad Irwin b66b4915cf Merge branch 'main' into vim2 2023-12-11 09:38:23 -07:00
Conrad Irwin d678efe7dd Fix some action registrations 2023-12-11 09:29:10 -07:00
Conrad Irwin cea26c9d10 actions3 (#3578) 
- Restore impl_actions! and remove derive(Action)

Originally in gpui2 we inferred the action's namespace from the module
it was
defined in. This worked most of the time (ignoring the "remove_the_2"
hack),
but caused unintended (and mostly invisible) behavior in crates with
multiple
modules.

#3577 restored the namespace parameter to actions!, and this PR
reintroduces
`impl_actions!` to do the same for non-unit structs.

I considered trying to keep the struct-attribute API work, because it
does feel
more stylistically appropriate for rust, but two problems lead to it
feeling less good than `impl_actions!` in practice:
1. You have to repeat the namespace for each struct (and usually you're
defining them all in the same namespace)
2. You can't pass an argument to a derive macro inline, you need to use
an attribute instead.


Release Notes:

- N/A
 2023-12-10 19:59:53 -07:00
Conrad Irwin c5367e3085 Correct docs re:Debug 2023-12-10 19:52:17 -07:00
Conrad Irwin 9ce7395b74 Restore impl_actions! and remove derive(Action) 2023-12-10 19:33:38 -07:00
Conrad Irwin 62d6a85a71 Restore namespace parameter to actions! (#3577) 
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.

Although automatically deriving the namespace worked in many situations,
it was
unclear what to do with nested modules. Vim wanted all actions to be
registered
under vim, while collab_ui wanted one namespace per action.

It seems better to make the implicit explicit, and give the flexibility
to hide
implementation details from the end-users.

Release Notes:

- N/A
 2023-12-09 15:27:17 -07:00
Conrad Irwin 4290c67b6a Restore namespace parameter to actions! 
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
 2023-12-09 15:18:31 -07:00