oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
5,994 Commits 1 Branch 0 Tags
560d8a8004bc8614268d30640887ed486df0be9f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kay Simmons f081dbced5 Merge pull request #1634 from zed-industries/dock-tweaks 
Dock Tweaks
 2022-09-19 09:02:43 -07:00
K Simmons b682fd8035 remove rounded corners on dock due to rendering issue 2022-09-16 16:44:29 -07:00
K Simmons da05e340b8 Fix dock keybindings 2022-09-16 16:41:57 -07:00
K Simmons 1ce48f4a94 Minor improvements to dock visuals, rework dock keybindings, and fix panic on split when dock is active 2022-09-16 12:55:36 -07:00
Kay Simmons 29f46539f0 Merge pull request #1614 from zed-industries/dock 
Dock
 2022-09-14 12:40:59 -07:00
K Simmons 61ec334234 Minor tweak to dock tests 2022-09-13 19:26:07 -07:00
K Simmons 3b9b2cd443 Add tests for the dock 2022-09-13 19:18:05 -07:00
K Simmons ad77bb7b92 Fix mouse scroll in terminal items 2022-09-13 17:37:24 -07:00
K Simmons a7d0732f95 fixed release build issue 2022-09-13 15:26:10 -07:00
K SimmonsandMikayla Maki 0b5952e1bd Fix incorrect rendering of toolbar in right anchored dock 
Make dock keybinding activate the dock if it wasn't hidden, and hide it if it was already active
Make clicking the expanded dock wash, hide the dock
Fix some issues with programmatically activating other panes, not hiding the dock
Tweak dock anchor menu text
Swap dock hide button for thin variant
Fix dock sidebar interactions
Add clicked state to search button and fix presenter issue sending clicked events when mouse not overlapping MouseRegion

Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-13 15:17:27 -07:00
K SimmonsandMikayla Maki 3c88aa3d18 Fix hovering over hover popovers in the editor 
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-13 13:35:06 -07:00
K Simmons 6bc17cc9a4 Fix remaining test failures 2022-09-13 13:17:49 -07:00
K Simmons df59b28aaf Extract panel resize code from sidebar into Resizable element 
Make resizable work in vertical axis
Make dock resizable
Have dock preserve size based on Anchor position
Make pane buttons work more correctly in pathological cases
Sync status bar dock button with dock visibility/anchor position

Co-Authored-By Mikayla Maki <mikayla@zed.dev>
 2022-09-12 18:32:15 -07:00
K Simmons f2b72eb6d2 WIP working on resizable dock 2022-09-12 14:24:57 -07:00
K Simmons 1dfa711d2e Fix some pane button issues 2022-09-11 15:52:09 -07:00
K SimmonsandMikayla Maki 444417203b Move workspace overlay elements into an actual overlay in order to get proper stacking context depths 
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-11 15:34:12 -07:00
K SimmonsandMikayla Maki 6b26965074 Permanent fix to repeat MouseRegion Tag failure in Workspace 
Polish tab bar buttons

Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-11 15:34:10 -07:00
K SimmonsandMikayla Maki 69ecbb644d DOCK WORKING! 
Update editor element to use mouse regions instead of dispatch event for mouse events
Fix bug in presenter where mouse region handlers were stored on click and called instead of more up to date handlers from subsequent renders
Changed MouseRegion to require discriminants in all cases
Add scroll wheel event to MouseRegion
Polished a bunch of dock inconsistencies

Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-11 15:32:20 -07:00
K Simmons 59fd967793 Swapped keyboard binding and did some minor tweaks to style and focus 2022-09-11 15:31:44 -07:00
K Simmons b88abcacac WIP dock split button and default item 2022-09-11 15:31:44 -07:00
K Simmons 0fca4d02ec Merge pull request #1621 from zed-industries/editor-context-menu-fix 
Make MouseRegion Click handlers, also handle Down events by default.
 2022-09-11 15:22:24 -07:00
K Simmons 28965dc5b6 Make MouseRegion Click handlers, also handle Down events by default. 2022-09-11 14:19:35 -07:00
K Simmons 6555d6f1c9 Merge pull request #1613 from zed-industries/breadcrumbs-refactoring 
Terminal Breadcrumbs
 2022-09-06 16:28:00 -07:00
K SimmonsandMikayla Maki 31ecb2f7bc Introduced ItemEvent and to_item_events function to Item trait which converts the Item's events into a standard ItemEvent similar to how SearchableItems work. 
Add breadcrumb_location and breadcrumbs functions to item trait which handles rendering of the breadcrumb elements
Change breadcrumb toolbar to use these new functions rather than having hard coded breadcrumb logic
Add breadcrumb support to the terminal tabs

Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-06 16:05:36 -07:00
K Simmons ab81093ef5 WIP pull breadcrumb rendering out into item trait 2022-09-06 14:39:58 -07:00
K Simmons a662a8967b Merge pull request #1596 from zed-industries/move-pane-panic-fix 
Don't panic if a tab isn't present in a from tab when dragged
 2022-09-01 17:47:16 -07:00
K SimmonsandMikayla Maki 7497edaec2 Add process info to terminal so that we can show the active process in the terminal tab title 
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
 2022-09-01 17:46:11 -07:00
K Simmons 91080fb998 Don't panic if a tab isn't present in a from tab when dragged 2022-09-01 15:17:25 -07:00
K Simmons e00b7b2670 Merge pull request #1593 from zed-industries/drag-and-drop-multiple-windows 
Drag and drop with multiple windows fix
 2022-09-01 13:45:47 -07:00
K SimmonsandMax Brunsfeld 67a585cdfa Impl default for drag and drop global. Make drag and drop global maintain a list of weak handles to the container. 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2022-09-01 12:13:46 -07:00
K Simmons efaf7e25f4 Merge pull request #1581 from zed-industries/generalized-item-search 
Make Workspace item search generic
 2022-08-31 16:12:45 -07:00
K Simmons c02b022e1c Merge pull request #1585 from zed-industries/more-drag-and-drop-fixes 
Some more drag and drop fixes
 2022-08-31 14:24:02 -07:00
K Simmons 227cc66594 Simulate mouse up if mouse was released outside window, don't report dragged payload if it was dragged from a different window 2022-08-31 14:06:38 -07:00
K Simmons dd934e930b Revert unnecessary app.rs changes 2022-08-30 22:01:36 -07:00
K Simmons d7e6e8c5a1 Add match associated type and fix failing test 2022-08-30 21:53:49 -07:00
K Simmons 91a5d0b036 SearchableItem trait is completed and editor searches appear to be working 2022-08-30 15:37:54 -07:00
K Simmons d59911df26 Merge pull request #1572 from zed-industries/drag-and-drop-fixes 
Misc drag and drop issue fixes
 2022-08-26 15:58:16 -07:00
K Simmons 3cc07c1099 Fix some drag and drop issues including the mouse cursor not being locked to pointer, tooltips being incorrect when a dragged tab is used, and some subscription leaks from panes 2022-08-26 15:43:15 -07:00
K Simmons 579c84b5e4 Merge pull request #1515 from zed-industries/drag-and-drop 
Drag and drop
 2022-08-25 16:52:15 -07:00
K Simmons 8591c3f46d Merge branch 'main' into drag-and-drop 2022-08-25 16:32:11 -07:00
K Simmons 22f62ee137 Add tests for Pane::add_item 2022-08-25 16:21:44 -07:00
K Simmons 042ece00b1 Drag and drop tabs working. all known bugs fixed 2022-08-25 11:14:24 -07:00
K Simmons 0a97a9c0fd Change dragged tab styling 2022-08-23 18:02:01 -07:00
K Simmonsand 5c38021a4d Move pane item reordering from activate_tab to add_item_at. 
Co-authored-by: nathan@zed.dev
 2022-08-23 17:33:01 -07:00
K Simmons de3acbd75b Introduce ReorderBehavior to pane, and address drag and drop offset error 2022-08-23 15:41:59 -07:00
K Simmons 9d20b66f2e Merge branch 'main' into drag-and-drop 2022-08-22 17:24:36 -07:00
K Simmons 13e9336049 Merge branch 'main' into drag-and-drop 2022-08-22 17:18:29 -07:00
K Simmons e44536344a Removed EventHandler from workspace in favor of mouse event handler 2022-08-22 16:49:14 -07:00
K Simmons 0f43ef9331 Dispatch Event refactoring. Appears to be workingCo-Authored-By: nathan@zed.dev 2022-08-22 16:16:40 -07:00
K Simmons b97940be9b more wip but currently beach balling 2022-08-22 16:16:39 -07:00
K Simmons 3fb4e6356c Rework presenter dispatch_event to allow isolated propogation of individual MouseRegionEvent types Co-Authored-By: mikayla@zed.dev 2022-08-22 16:16:39 -07:00
K Simmons 0d6125889f WIP 2022-08-22 16:16:39 -07:00
K Simmons 03a344a272 properly constrained tab 2022-08-22 16:16:39 -07:00
K Simmons ab9f073443 fixed merge errors 2022-08-22 16:16:39 -07:00
K Simmons 133c194f4a wip tab drag and drop 2022-08-22 16:16:39 -07:00
K Simmons 86fdd55fd4 Combined presenter mouse region event dispatching and added support up_out, and drag_over 2022-08-22 16:16:39 -07:00
K Simmons a650c146f1 more event wip 2022-08-22 16:16:39 -07:00
K Simmons 53add253b6 wip new mouse region events 2022-08-22 16:16:39 -07:00
K Simmons 42c01c5b10 minor rustfmt fix 2022-08-11 11:35:11 -07:00
K Simmons c74d10809e Testing with allow flags 2022-08-10 17:01:13 -07:00
K Simmons 9aa3f2d777 clippy fixes for focus change 2022-08-10 16:51:01 -07:00
Keith Simmons ec015d4607 Merge pull request #1422 from zed-industries/workspace-child-focus-pane-activation 
Add on_child_focus and on_child_blur to View trait
 2022-08-10 16:42:01 -07:00
K Simmons 4d38dcfc54 Fix workspace 2022-08-10 16:27:45 -07:00
K Simmons d68f227ec4 Fix failing tests 2022-08-10 16:26:53 -07:00
K Simmons 3bdf05c0cd fix up command palette 2022-08-09 17:15:54 -07:00
K Simmons f5a6a112c8 Address picker issues 2022-08-09 17:15:54 -07:00
K Simmons 6f180ed822 Pane focus working. Modals seem broken now 2022-08-09 17:15:54 -07:00
K Simmons 049149320c build fix 2022-08-09 17:15:54 -07:00
K Simmons 690ea57211 WIP compiling but failing with circular reference 2022-08-09 17:15:52 -07:00
K Simmons 6442ec59e7 Switch action dispatch to use MutableAppContext parent utilities and delete parent map from presenter 2022-08-09 17:09:28 -07:00
K Simmons 4271eb3624 Event dispatch moved to MutableAppContext. No longer dispatches from presenter. Not currently handling key presses properly 2022-08-09 17:09:16 -07:00
K Simmons 20d45221c9 Move terminal modal keymap context to the connected view 2022-07-27 11:00:54 -07:00
Keith Simmons 4ff007eaab Merge pull request #1414 from zed-industries/fix-theme-issues 
Fix tab bar themes
 2022-07-26 11:55:17 -07:00
K Simmons 2bd0819ac8 Extract tab bar from workspace 2022-07-26 10:41:02 -07:00
Keith Simmons 2111fdc118 Merge pull request #1378 from zed-industries/diagnostics-popover 
Diagnostics Popover
 2022-07-22 11:12:56 -07:00
K Simmons b93040a6ae attempt to fix broken test 2022-07-22 10:55:57 -07:00
Keith Simmons 9286e5ea04 Merge pull request #1396 from zed-industries/better-empty-pane 
Fix Pane Focus Issues
 2022-07-21 15:07:03 -07:00
K Simmons d6519ad280 Minor naming improvements and revert empty pane background color change 2022-07-21 14:56:17 -07:00
K Simmons fb2fbf2ac7 fix test failure 2022-07-20 19:13:16 -07:00
K Simmons a076eeeb96 tweak diagnostic popover colors 2022-07-20 19:02:33 -07:00
K Simmons b85b2a90aa address warnings 2022-07-20 19:02:33 -07:00
K Simmons 02a47d962e add test coverage for diagnostic popover 2022-07-20 19:02:33 -07:00
K Simmons 95952f0c66 working diagnostic popover. Also renamed GoToNextDiagnostic to GoToDiagnostic and adjusted it's action to jump to the popover's diagnostic if it is visible 2022-07-20 19:02:33 -07:00
K Simmons dbedc30abe WIP 2022-07-20 19:02:33 -07:00
K Simmons daceb1eb5f Fix warning 2022-07-20 19:02:12 -07:00
K Simmons 225055ed5d Address some issues where panes don't get focused properly, make the focused pane more obvious, and prevent splitting of the pane with no items 2022-07-20 18:52:32 -07:00
Keith Simmons d34d6ea184 Merge pull request #1392 from zed-industries/mouse-vim-mode-clipping 
Fixup Clipping at Line Ends when Selecting with the Mouse in Vim Mode
 2022-07-20 13:39:24 -07:00
K Simmons a77cf914ec Fix failing test re mode switch in buffer search 2022-07-19 17:18:17 -07:00
K Simmons 1cfaac1bc5 Fix clipping when dragging the mouse with vim-mode enabled and adjust single line editor selections 2022-07-19 17:18:17 -07:00
Keith Simmons c2868a39e8 Merge pull request #1388 from zed-industries/mouse-region-refactor 
Mouse Region Refactor
 2022-07-19 16:50:12 -07:00
K Simmons deeefed7eb Change mouse_event_handler to use HandlerSet 2022-07-18 10:08:14 -07:00
K Simmons ec25fa9260 Extract handler set from MouseRegion 2022-07-18 09:54:48 -07:00
K Simmons 8add81350e Rework presenter and MouseRegion to use Handler hashmap rather than individual fields 2022-07-17 23:19:32 -07:00
Keith Simmons 17f52fb587 Merge pull request #1355 from zed-industries/better-tab-ordering 
More intuitive tab ordering
 2022-07-14 12:26:46 -07:00
K Simmons 52b29c0928 When tab closed, move to previous tab, and when opening an existing tab, reorder it to be after the current active tab 2022-07-13 20:14:44 -07:00
Keith Simmons ed1370eafc Merge pull request #1330 from zed-industries/completions-setting 
Completions Menu Setting
 2022-07-13 15:35:10 -07:00
K Simmons e7b1060bca fix merge error to use new default settings flow 2022-07-13 14:29:47 -07:00
Keith Simmons 7f3018c3f6 add show_completions_on_input setting to disable popping the completions menu automatically 2022-07-13 14:23:49 -07:00
Keith Simmons 5366ed4404 Add basic test for editor context menu 2022-07-13 14:13:19 -07:00
Keith Simmons b850e41d6f Add editor mouse context menu with some basic refactorings and an entry to pop the code actions 2022-07-13 14:13:19 -07:00