oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1596 from zed-industries/move-pane-panic-fix

Browse Source 
Don't panic if a tab isn't present in a from tab when dragged
This commit is contained in:
K Simmons
2022-09-01 17:47:16 -07:00
committed by GitHub
parent 7cbabc386f 91080fb998
commit a662a8967b
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/workspace/src/pane.rs
+8 -3
View File
@@ -910,13 +910,18 @@ impl Pane {
destination_index: usize,
cx: &mut ViewContext<Workspace>,
) {
let (item_ix, item_handle) = from
let item_to_move = from
.read(cx)
.items()
.enumerate()
.find(|(_, item_handle)| item_handle.id() == item_to_move)
.expect("Tried to move item handle which was not in from pane");
.find(|(_, item_handle)| item_handle.id() == item_to_move);
if item_to_move.is_none() {
log::warn!("Tried to move item handle which was not in `from` pane. Maybe tab was closed during drop");
return;
}
let (item_ix, item_handle) = item_to_move.unwrap();
// This automatically removes duplicate items in the pane
Pane::add_item(
workspace,