oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,317 Commits 1 Branch 0 Tags
0794de71e3269b977f9efc8dec98f31e9f78ad24
Commit Graph
80 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lukas Wirth e1b57f00a0 sum_tree: Reduce Cursor size for contextless summary types (#38776) 
This reduces the size of cursor by a usize when the summary does not
require a context making Cursor usages and constructions slightly more
efficient.

This change is a bit annoying though, as Rust has no means of
specializing, so this uses a `ContextlessSummary` trait with a blanket
impl while turning the `Context` into a GAT `Context<'a>`. This means
`Summary` implies are a bit more verbose now while contextless ones are
slimmer. It does come with the downside that the lifetime in the GAT is
always considered invariant, so some lifetime splitting occurred due to
that.


 ```
push/4096               time:   [352.65 µs 360.87 µs 367.80 µs]
                        thrpt:  [10.621 MiB/s 10.825 MiB/s 11.077 MiB/s]
                 change:
time: [-2.6633% -1.3640% -0.0561%] (p = 0.05 < 0.05)
                        thrpt:  [+0.0561% +1.3828% +2.7361%]
                        Change within noise threshold.
Found 16 outliers among 100 measurements (16.00%)
  7 (7.00%) low severe
  3 (3.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe
push/65536              time:   [1.2917 ms 1.2949 ms 1.2979 ms]
                        thrpt:  [48.156 MiB/s 48.267 MiB/s 48.387 MiB/s]
                 change:
time: [+1.4428% +1.9844% +2.5299%] (p = 0.00 < 0.05)
                        thrpt:  [-2.4675% -1.9458% -1.4223%]
                        Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low severe
  1 (1.00%) low mild
  1 (1.00%) high severe

append/4096             time:   [677.87 ns 678.87 ns 679.83 ns]
                        thrpt:  [5.6112 GiB/s 5.6192 GiB/s 5.6274 GiB/s]
                 change:
time: [-0.8924% -0.5017% -0.1705%] (p = 0.00 < 0.05)
                        thrpt:  [+0.1708% +0.5043% +0.9004%]
                        Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
append/65536            time:   [9.3275 µs 9.3406 µs 9.3536 µs]
                        thrpt:  [6.5253 GiB/s 6.5344 GiB/s 6.5435 GiB/s]
                 change:
time: [+0.5409% +0.7215% +0.9054%] (p = 0.00 < 0.05)
                        thrpt:  [-0.8973% -0.7163% -0.5380%]
                        Change within noise threshold.

slice/4096              time:   [27.673 µs 27.791 µs 27.907 µs]
                        thrpt:  [139.97 MiB/s 140.56 MiB/s 141.16 MiB/s]
                 change:
time: [-1.1065% -0.6725% -0.2429%] (p = 0.00 < 0.05)
                        thrpt:  [+0.2435% +0.6770% +1.1189%]
                        Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) low mild
  1 (1.00%) high mild
slice/65536             time:   [507.55 µs 517.40 µs 535.60 µs]
                        thrpt:  [116.69 MiB/s 120.80 MiB/s 123.14 MiB/s]
                 change:
time: [-1.3489% +0.0599% +2.2591%] (p = 0.96 > 0.05)
                        thrpt:  [-2.2092% -0.0598% +1.3674%]
                        No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
  5 (5.00%) low mild
  2 (2.00%) high mild
  1 (1.00%) high severe

bytes_in_range/4096     time:   [3.3917 µs 3.4108 µs 3.4313 µs]
                        thrpt:  [1.1117 GiB/s 1.1184 GiB/s 1.1247 GiB/s]
                 change:
time: [-5.3466% -4.7193% -4.1262%] (p = 0.00 < 0.05)
                        thrpt:  [+4.3038% +4.9531% +5.6487%]
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  1 (1.00%) low mild
  5 (5.00%) high mild
bytes_in_range/65536    time:   [88.175 µs 88.613 µs 89.111 µs]
                        thrpt:  [701.37 MiB/s 705.31 MiB/s 708.82 MiB/s]
                 change:
time: [-0.6935% +0.3769% +1.4655%] (p = 0.50 > 0.05)
                        thrpt:  [-1.4443% -0.3755% +0.6984%]
                        No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

chars/4096              time:   [678.70 ns 680.38 ns 682.08 ns]
                        thrpt:  [5.5927 GiB/s 5.6067 GiB/s 5.6206 GiB/s]
                 change:
time: [-0.6969% -0.2755% +0.1485%] (p = 0.20 > 0.05)
                        thrpt:  [-0.1483% +0.2763% +0.7018%]
                        No change in performance detected.
Found 9 outliers among 100 measurements (9.00%)
  5 (5.00%) low mild
  4 (4.00%) high mild
chars/65536             time:   [12.720 µs 12.775 µs 12.830 µs]
                        thrpt:  [4.7573 GiB/s 4.7778 GiB/s 4.7983 GiB/s]
                 change:
time: [-0.6172% -0.1110% +0.4179%] (p = 0.68 > 0.05)
                        thrpt:  [-0.4162% +0.1112% +0.6211%]
                        No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild

clip_point/4096         time:   [33.240 µs 33.310 µs 33.394 µs]
                        thrpt:  [116.98 MiB/s 117.27 MiB/s 117.52 MiB/s]
                 change:
time: [-2.8892% -2.6305% -2.3438%] (p = 0.00 < 0.05)
                        thrpt:  [+2.4000% +2.7015% +2.9751%]
                        Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
  1 (1.00%) low mild
  4 (4.00%) high mild
  7 (7.00%) high severe
clip_point/65536        time:   [1.6531 ms 1.6586 ms 1.6640 ms]
                        thrpt:  [37.560 MiB/s 37.683 MiB/s 37.808 MiB/s]
                 change:
time: [-6.6381% -5.9395% -5.2680%] (p = 0.00 < 0.05)
                        thrpt:  [+5.5610% +6.3146% +7.1100%]
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  4 (4.00%) high severe

point_to_offset/4096    time:   [11.586 µs 11.603 µs 11.621 µs]
                        thrpt:  [336.15 MiB/s 336.67 MiB/s 337.16 MiB/s]
                 change:
time: [-14.289% -14.111% -13.939%] (p = 0.00 < 0.05)
                        thrpt:  [+16.197% +16.429% +16.672%]
                        Performance has improved.
Found 12 outliers among 100 measurements (12.00%)
  3 (3.00%) low severe
  5 (5.00%) low mild
  4 (4.00%) high mild
point_to_offset/65536   time:   [527.74 µs 532.08 µs 536.51 µs]
                        thrpt:  [116.49 MiB/s 117.46 MiB/s 118.43 MiB/s]
                 change:
time: [-6.7825% -4.6235% -2.3533%] (p = 0.00 < 0.05)
                        thrpt:  [+2.4100% +4.8477% +7.2760%]
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  4 (4.00%) high mild
  4 (4.00%) high severe

cursor/4096             time:   [16.154 µs 16.192 µs 16.232 µs]
                        thrpt:  [240.66 MiB/s 241.24 MiB/s 241.81 MiB/s]
                 change:
time: [-3.2536% -2.9145% -2.5526%] (p = 0.00 < 0.05)
                        thrpt:  [+2.6194% +3.0019% +3.3630%]
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) low mild
  2 (2.00%) high mild
  2 (2.00%) high severe
cursor/65536            time:   [509.60 µs 511.24 µs 512.93 µs]
                        thrpt:  [121.85 MiB/s 122.25 MiB/s 122.65 MiB/s]
                 change:
time: [-7.3677% -6.6017% -5.7840%] (p = 0.00 < 0.05)
                        thrpt:  [+6.1391% +7.0683% +7.9537%]
                        Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe
```
Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-24 14:35:38 +02:00
Lukas Wirth c53e5ba397 editor: Fix invalid anchors in hover_links::surrounding_filename (#38766) 
Fixes ZED-1K3

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-24 08:30:11 +00:00
Lukas Wirth 9418a2f4bc editor: Prevent panics in BlockChunks if the block spans more than 128 lines (#38763) 
Not an ideal fix, but a proper one will require restructuring the
iterator state (which would be easier if Rust had first class
generators)
Fixes ZED-1MB

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-24 08:10:56 +00:00
Lukas Wirth 1bf8332333 editor: Deduplicate locations in navigate_to_hover_links (#38707) 
Closes
https://github.com/zed-industries/zed/issues/6730#issuecomment-3320933701

That way if multiple servers are running while reporting the same
results we prevent opening multi buffers for single entries.

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-23 11:39:48 +00:00
Lukas Wirth 55dc9ff7ca text: Implement Rope::clip_offset in terms of the new utf8 boundary methods (#38630) 
Release Notes:

- N/A
 2025-09-22 11:45:23 +00:00
Lukas WirthandMikayla Maki a2c71d3d20 text: Assert text anchor offset validity on construction (#38441) 
Attempt to aid debugging some utf8 indexing issues

Release Notes:

- N/A

Co-authored-by: Mikayla Maki <mikayla@zed.dev>
 2025-09-22 11:20:46 +00:00
Lukas Wirth b1aa2723e9 editor: Reverse range of pending selection if required (#38410) 
cc https://github.com/zed-industries/zed/issues/38129

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-18 10:58:10 +00:00
Lukas Wirth 59a609c9fc Partially revert "project: Fix terminal activation scripts failing on Windows for new shells (#37986) (#38406) 
This partially reverts commit 4002602a89.
Specifically the parts that closes
https://github.com/zed-industries/zed/issues/38343

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-18 10:06:43 +00:00
Lukas Wirth 9f9e8063fc workspace: Pop a toast if manually spawning a task fails (#38405) 
Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-18 12:03:35 +02:00
Lukas Wirth d85a6db6a3 git_ui: Use margin instead of padding for blame entries (#38397) 
This makes the hover background change keep a visible border element
between the gutter and blame entries

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-18 08:22:26 +00:00
Lukas Wirth f3b8c619e3 editor: Fix unwrap_syntax_node panicking by not setting selections (#38329) 
Fixes ZED-11T

Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-17 15:10:05 +00:00
Lukas Wirth 405a8eaf78 editor: Fix BlockMapWriter::blocks_intersecting_buffer_range creating invalid indexing ranges (#38325) 
Fixes ZED-113
Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-17 13:47:00 +00:00
Lukas Wirth a5c29176a3 editor: Fix incorrect offset passed to acp completion provider (#38321) 
Might fix | ZED-15G
Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-17 12:02:39 +00:00
Lukas Wirth 399118f461 denoise: Fix LICENSE-GPL symlink (#38313) 
Release Notes:

- N/A *or* Added/Fixed/Improved ...
 2025-09-17 10:38:49 +00:00
Lukas Wirth 5ca3b998f3 fs: Do panic when failing to query modified timestamps (#38312) 
Fixes ZED-1EW

Release Notes:

- N/A
 2025-09-17 10:28:05 +00:00
Lukas Wirth 28800c2a3b languages: Fix panic in python lsp adapters assuming settings shape (#38309) 
Fixes ZED-1EV
Fixes ZED-S0
Fixes ZED-Q9

Release Notes:

- N/A
 2025-09-17 10:09:15 +00:00
Lukas Wirth c5ac1e6218 editor: Fix select_larget_syntax_node overflowing in multibuffers (#38308) 
Fixes ZED-18Z

Release Notes:

- N/A
 2025-09-17 11:36:20 +02:00
Lukas Wirth a2de91827d agent_ui: Fix panic on editor changes in inline_assistant (#38303) 
Fixes ZED-13P

Release Notes:

- N/A
 2025-09-17 08:39:24 +00:00
Lukas Wirth 531f9ee236 Give most spawned threads names (#38302) 
Release Notes:

- N/A
 2025-09-17 10:11:51 +02:00
Lukas Wirth 4ee2daeded markdown: Fix indented codeblocks having incorrect content ranges (#38225) 
Closes https://github.com/zed-industries/zed/issues/37743

Release Notes:

- Fixed agent panel panicking when streaming indented codeblocks from
agent output
 2025-09-17 06:48:47 +00:00
Lukas Wirth 173074f248 search: Re-issue project search if search query is stale on replacement (#38251) 
Closes https://github.com/zed-industries/zed/issues/34897

Release Notes:

- Fixed project search replacement replacing stale search results
 2025-09-16 12:12:45 +00:00
Lukas Wirth c6472fd7a8 agent_settings: Fix schema validation rejecting custom llm providers (#38248) 
Closes https://github.com/zed-industries/zed/issues/37989

Release Notes:

- N/A
 2025-09-16 10:23:49 +00:00
Lukas Wirth f321d02207 auto_update: Show update error on hover and open logs on click (#38241) 
Release Notes:

- Improved error reporting when auto-updating fails
 2025-09-16 08:07:02 +00:00
Lukas Wirth 1c09985fb3 worktree: Add more context to log_err calls (#38239) 
Release Notes:

- N/A
 2025-09-16 07:31:28 +00:00
Lukas Wirth 92b946e8e5 acp_thread: Properly use project terminal API (#38186) 
Closes https://github.com/zed-industries/zed/issues/35603

Release Notes:

- Fixed shell selection for terminal tool
 2025-09-15 12:43:41 +00:00
Lukas Wirth 393d6787a3 terminal: Do not auto close shell terminals if they error out (#38182) 
Closes https://github.com/zed-industries/zed/issues/38134

This also reduces an annoying level of shell nesting

Release Notes:

- N/A
 2025-09-15 10:09:25 +00:00
Lukas Wirth 14f4e867aa terminal: Do not auto close shell terminals if they error out (#38180) 
cc https://github.com/zed-industries/zed/issues/38134
Release Notes:

- N/A
 2025-09-15 09:43:05 +00:00
Lukas Wirth 2a03b6b80c terminal: Fix test_basic_terminal test (#38059) 
`echo` isn't a program on windows, so we need to spawn a shell that
executes it for the test

Release Notes:

- N/A
 2025-09-12 13:13:23 +00:00
Lukas WirthandPiotr Osiewicz e68aa18fd4 project: Fix task arguments being quoted incorrectly for nushell and powershell (#38056) 
Release Notes:

- Fixed task arguments being quoted incorrectly for nushell and
powershell

Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
 2025-09-12 12:02:39 +00:00
Lukas Wirth 592b013013 language: Split LSP installation handling into a separate trait (#38046) 
Part of reworking our installation handling to allow for multiple
different versions to be handled

Release Notes:

- Fixed pre-release lsp fetching setting not having an affect until
restarting Zed
 2025-09-12 09:37:45 +00:00
Lukas Wirth 462293667b editor: Re-use multibuffers when opening the same locations again (#37994) 
A very primitive attempt, we just key the editor with the locations and
re-use the editor if we open a new buffer with the same initial
locations and title.

Release Notes:

- Added reusing of reference search buffers when applicable
 2025-09-11 16:58:11 +02:00
Lukas Wirth 4002602a89 project: Fix terminal activation scripts failing on Windows for new shells (#37986) 
Tasks are still disabled as there seem to be more issues with it

Release Notes:

- N/A
 2025-09-11 12:16:08 +00:00
Lukas Wirth d110d325d4 languages: Remove broken pixi environment activation (#37915) 
Closes [#ISSUE](https://github.com/zed-industries/zed/issues/37895)

This needs more thought behind it to be implemented properly

Release Notes:

- N/A
 2025-09-10 13:35:16 +00:00
Lukas WirthandFinn Evers df2d097dc5 editor: Fix adjacent custom highlights interfering with each other (#37912) 
Release Notes:

- Fixed matching bracket highlighting not highlighting closing brackets
when adjacent to each other

Co-authored-by: Finn Evers <finn@zed.dev>
 2025-09-10 13:08:32 +00:00
Lukas Wirth adf43d691a project: Remove non searchable buffer entries on buffer close (#37841) 
Release Notes:

- N/A
 2025-09-09 11:21:51 +00:00
Lukas Wirth 80a4746a46 project: Be explicit about project-searchability for buffers (#37773) 
Closes https://github.com/zed-industries/zed/issues/28830

Release Notes:

- Fixed builtin buffers and log views showing up in project search
 2025-09-08 11:22:36 +00:00
Lukas Wirth a0081dd693 project: Consider all worktrees for activation script search (#37764) 
Should fix https://github.com/zed-industries/zed/issues/37734

Release Notes:

- Fixed venv not always activating correctly
 2025-09-08 10:06:43 +00:00
Lukas Wirth ec58adca13 languages: Invoke conda activate in conda environments (#37627) 
This isn't quite right, but using the env manager path causes conda to
scream and I am not yet sure why, either way this is an improvement over
the status quo

Release Notes:

- N/A\
 2025-09-05 11:16:15 +00:00
Lukas Wirth bed358718b agent_ui: Fix index panic in SlashCommandCompletion::try_parse (#37612) 
Release Notes:

- N/A
 2025-09-05 07:56:53 +00:00
Lukas Wirth 4124bedab7 gpui: Skip test attribute expansion for rust-analyzer (#37611) 
The `test` attribute doesn't really matter to rust-analyzer, so we can
make use of its cfg to have it think its just the standard test
attribute which should make rust-analyzer slightly less resource
intensive in zed. It also should prevent some IDE features from possibly
failing within tests.

Notably this has no effect outside of this repo, as the `rust-analyzer`
cfg only takes effect on workspace member crates.

Ideally we'd use the ignored proc macro config here but rust-analyzer
still doesn't have toml configs working unfortunately.

Release Notes:

- N/A
 2025-09-05 06:54:08 +00:00
Lukas Wirth e37efc1e9b diagnostics: Fix diagnostics pane clearing up too eagerly on typing (#37546) 
Closes https://github.com/zed-industries/zed/issues/30494

Release Notes:

- Fixed diagnostics pane closing buffers too eagerly when typing inside
it
 2025-09-04 15:30:23 +00:00
Lukas Wirth fca44f89c1 languages: Allow installing pre-release of rust-analyzer and clangd (#37530) 
Release Notes:

- Added lsp binary config to allow fetching nightly rust-analyzer and
clangd releases
 2025-09-04 09:22:19 +00:00
Lukas WirthandKirill Bulatov c1ca7303a8 editor: Make blame and inline blame work for multibuffers (#37366) 
Release Notes:

- Added blame view and inline blame support for multi buffer editors

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
 2025-09-03 14:22:35 +00:00
Lukas Wirth d80f9dda75 languages: Fix python tasks failing when binary contains whitespaces (#37454) 
Fixes https://github.com/zed-industries/zed/issues/33459

Release Notes:

- Fixed python tasks failing when the python binary path contains
whitespaces
 2025-09-03 16:11:36 +02:00
Lukas Wirth 35c0d02c7c project: Temporarily disable terminal activation scripts on windows (#37361) 
They seem to break things on window right now

Release Notes:

- N/A
 2025-09-02 10:42:29 +00:00
Lukas Wirth 62083fe796 gpui: Do not render ligatures between different styled text runs (#37175) 
Currently when we render text with differing styles adjacently we might
form a ligature between the text, causing the ligature forming
characters to take on one of the two styles. This can especially become
confusing when a ligature is formed between actual text and inlay hints.

Annoyingly, the only ways to prevent this with core text is to either
render each run separately, or to insert a zero-width non-joiner to
force core text to break the ligatures apart, as it otherwise will merge
subsequent font runs of the same fonts.

We currently do layouting on a per line basis and it is unlikely we want
to change that as it would incur a lot of complexity and annoyances to
merge things back into a line, so this goes with the other approach of
inserting ZWNJ characters instead.

Note that neither linux nor windows seem to currently render ligatures,
so this only concerns macOS rendering at the moment.

Release Notes:

- Fixed ligatures forming between real text and inlay hints on macOS
 2025-09-01 09:49:52 +02:00
Lukas Wirth 4507f60b8d languages: Fix python activation scripts not being quoted (#37159) 
Release Notes:

- N/A
 2025-08-29 11:39:38 +00:00
Lukas Wirth 7403a4ba17 Add basic PyEnv and pixi support for python environments (#37156) 
cc https://github.com/zed-industries/zed/issues/29807

Release Notes:

- Fixed terminals and tasks not respecting python pyenv and pixi
environments
 2025-08-29 10:19:27 +00:00
Lukas Wirth 835e5ba662 Inject venv environment via the toolchain (#36576) 
Instead of manually constructing the venv we now ask the python
toolchain for the relevant information, unifying the approach of vent
inspection

Fixes https://github.com/zed-industries/zed/issues/27350

Release Notes:

- Improved the detection of python virtual environments for terminals
and tasks in remote projects.
 2025-08-28 14:40:43 +00:00
Lukas Wirth 72bd248544 editor: Fix multi buffer header context menu not handling absolute paths (#36769) 
Release Notes:

- N/A
 2025-08-22 18:49:12 +00:00
Lukas Wirth 33e05f15b2 collab_ui: Fix channel text bleeding through buttons on hover (#36710) 
Release Notes:

- N/A
 2025-08-21 18:50:06 +00:00
Lukas Wirth b284b1a0b8 remote: Fetch shell on ssh remote to use for preparing commands (#36690) 
Prerequisite for https://github.com/zed-industries/zed/pull/36576 to
allow us to differentiate the shell in a remote.

Release Notes:

- N/A
 2025-08-21 19:08:26 +02:00
Lukas Wirth c5040bd0a4 remote: Do not leave client hanging on unhandled proto message (#36590) 
Otherwise the client will wait for a response that never arrives,
causing the task to lock up

Release Notes:

- N/A
 2025-08-20 13:41:58 +00:00
Lukas Wirth d1cabef2bf editor: Fix inline diagnostics min column inaccuracy (#36501) 
Closes https://github.com/zed-industries/zed/issues/33346

Release Notes:

- Fixed `diagnostic.inline.min_column` being inaccurate
 2025-08-19 16:53:45 +00:00
Lukas Wirth 013eaaeadd editor: Render dirty and conflict markers in multibuffer headers (#36489) 
Release Notes:

- Added rendering of status indicators for multi buffer headers
 2025-08-19 18:43:42 +02:00
Lukas Wirth 9e8ec72bd5 Revert "project: Handle textDocument/didSave and textDocument/didChange (un)registration and usage correctly (#36441)" (#36480) 
This reverts commit c5991e74bb.

This PR broke rust-analyzer's check on save function, so reverting for
now

Release Notes:

- N/A
 2025-08-19 14:32:26 +02:00
Lukas WirthandSmit Barmase 5df9c7c1c2 search: Fix project search query flickering (#36470) 
Release Notes:

- N/A

Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
 2025-08-19 10:16:49 +00:00
Lukas Wirth ed155ceba9 title_bar: Fix screensharing errors not being shown to the user (#36424) 
Release Notes:

- N/A
 2025-08-18 16:27:26 +00:00
Lukas Wirth 472f1a8cc2 editor: Add right click context menu to buffer headers (#36398) 
This adds a context menu to buffer headers mimicking that of pane tabs,
notably being able to copy the relative and absolute paths of the buffer
as well as opening a terminal in the parent.

Confusingly prior to this right clicking a buffer header used to open
the context menu of the underlying editor.

Release Notes:

- Added context menu for buffer titles
 2025-08-18 10:40:39 +00:00
Lukas Wirth 864d4bc1d1 editor: Drop multiline targets in navigation buffers (#36291) 
Release Notes:

- N/A
 2025-08-16 07:55:46 +00:00
Lukas Wirth 846ed6adf9 search: Fix project search not rendering matches count (#36238) 
Follow up to https://github.com/zed-industries/zed/pull/36103/

Release Notes:

- N/A
 2025-08-15 12:54:05 +00:00
Lukas Wirth d891348442 search: Simplify search options handling (#36233) 
Release Notes:

- N/A
 2025-08-15 10:34:54 +00:00
Lukas Wirth 8d6982e78f search: Fix some inconsistencies between project and buffer search bars (#36103) 
- project search query string now turns red when no results are found
matching buffer search behavior
- General code deduplication as well as more consistent layout between
the two bars, as some minor details have drifted apart
- Tab cycling in buffer search now ends up in editor focus when cycling
backwards, matching forward cycling
- Report parse errors in filter include and exclude editors

Release Notes:

- N/A
 2025-08-15 09:56:47 +02:00
Lukas Wirth e2ce787c05 editor: Limit target names in hover links multibuffer titles (#36207) 
Release Notes:

- N/A
 2025-08-14 21:18:07 +00:00
Lukas Wirth b7c562f359 Bump async-trait (#36201) 
The latest release has span changes in it which prevents rust-analyzer
from constantly showing `Box` and `Box::pin` on hover as well as those
items polluting the go to definition feature on every identifier.

See https://github.com/dtolnay/async-trait/pull/293

Release Notes:

- N/A
 2025-08-14 19:28:59 +00:00
Lukas Wirth ffac8c5128 editor: Render all targets in go to def multbuffer title (#36167) 
Release Notes:

- N/A
 2025-08-14 09:11:46 +00:00
Lukas Wirth 8e4f30abcb project: Print error causes when failing to spawn lsp command (#36163) 
cc https://github.com/zed-industries/zed/issues/34666

Display printing anyhow errors only renders the error itself, but not
any of its causes so we've been dropping the important context when
showing the issue to the users.

Release Notes:

- N/A
 2025-08-14 08:16:25 +00:00
Lukas Wirth a88c533ffc language: Fix rust-analyzer removing itself on download (#35971) 
Release Notes:

- N/A\
 2025-08-11 12:24:53 +00:00
Lukas Wirth e132c7cad9 dap_adapters: Log CodeLldb version fetching errors (#35943) 
Release Notes:

- N/A
 2025-08-11 08:15:59 +00:00
Lukas Wirth 8d332da4c5 languages: Don't remove old artifacts on download failure (#35967) 
Release Notes:

- N/A
 2025-08-11 07:20:03 +00:00
Lukas Wirth 9cd5c3656e util: Fix crate name extraction for log_error_with_caller (#35944) 
The paths can be absolute, meaning they would just log the initial
segment of where the repo was cloned.

Release Notes:

- N/A
 2025-08-10 15:19:06 +00:00
Lukas Wirth f0782aa243 agent: Don't error when the agent navigation history hasn't been persisted (#35863) 
This causes us to log an unrecognizable error on every startup otherwise

Release Notes:

- N/A
 2025-08-08 14:01:48 +00:00
Lukas Wirth d5c4e4b7b2 languages: Fix digest check on downloaded artifact for clangd (#35870) 
Closes 35864

Release Notes:

- N/A
 2025-08-08 13:54:26 +00:00
Lukas Wirth 0097d89672 language: Fix rust completion labels with fullFunctionSignature config (#35823) 
Release Notes:

- N/A
 2025-08-08 07:43:49 +00:00
Lukas Wirth 738968e90c editor: Consider mixed hover link kinds when navigating to multibuffer (#35828) 
Previously when handling multiple hover links we filtered non-location
links out which may end up with a single location entry only, resulting
in us opening a multi buffer for a single location. This changes the
logic to do the filtering first, then deciding on whether to open a
single buffer or multi buffer.

Closes https://github.com/zed-industries/zed/issues/6730

Release Notes:

- N/A
 2025-08-08 05:32:51 +00:00
Lukas Wirth 4dbd24d75f Reduce amount of allocations in RustLsp label handling (#35786) 
There can be a lot of completions after all


Release Notes:

- N/A
 2025-08-07 13:24:29 +00:00
Lukas Wirth f5f837d39a languages: Fix rust completions not having proper detail labels (#35772) 
rust-analyzer changed the format here a bit some months ago which
partially broke our nice detailed highlighted completion labels. The
brings that back while also cleaning up the code a bit.

Also fixes a bug where disabling rust-analyzers snippet callable
completions would fully break them.

Release Notes:

- N/A
 2025-08-07 10:38:58 +00:00
Lukas Wirth 0302f6356e Ignore metadata file in RustLspAdapter::get_cached_server_binary (#35708) 
Follows https://github.com/zed-industries/zed/pull/35642

Release Notes:

- Fixed accidentally picking a non executable as a rust-analyzer server
when downloading fails
 2025-08-06 09:08:32 +00:00
Lukas Wirth 69794db331 Prevent out of bounds access in recursive_score_match (#35630) 
Closes https://github.com/zed-industries/zed/issues/33668

The recursive case increments both indices by 1, but only one of the two
had a base case check in the function prologue so the other could spill
over into a different matrix row or out of bounds entirely.

Lacking a test as I haven't figured out a test case yet.

Release Notes:

- Fixed out of bounds panic in fuzzy matching
 2025-08-06 10:53:20 +02:00
Lukas WirthandKirill Bulatov c59c436a11 Verify downloaded rust-analyzer and clang binaries by checking the artifact digest (#35642) 
Release Notes:

- Added GitHub artifact digest verification for rust-analyzer and clangd
binary downloads, skipping downloads if cached binary digest is up to
date
- Added verification that cached rust-analyzer and clangd binaries are
executable, if not they are redownloaded

---------

Co-authored-by: Kirill Bulatov <kirill@zed.dev>
 2025-08-06 08:32:25 +00:00