Mikayla Maki
f6b64dc67a
This PR adds a new mouse event type for catching when a click happens outside of a given region. This was added because I noticed a 'race condition' between the context menu and the buttons which deploy a context menu. Buttons use on an`on_click()` handler to deploy the context menu, but the context menu was closing itself with an `on_down_out()` handler. This meant that the order of operations was: 0. Context menu is open 1. User presses down on the button, _outside of the context menu_ 2. `on_down_out()` is fired, closing the context menu 3. User releases the mouse 4. `click()` is fired, checks the state of the context menu, finds that it's closed, and so opens it You can see this behavior demonstrated with this video with a long-click here: https://github.com/zed-industries/zed/assets/2280405/588234c3-1567-477f-9a12-9e6a70643527 ~~Switching from `on_down_out()` to `on_click_out()` means that the click handler for the button can close the menu before the context menu gets a chance to close itself.~~ ~~However, GPUI does not have an `on_click_out()` event, hence this PR.~~ ~~Here's an example of the new behavior, with the same long-click action:~~ https://github.com/zed-industries/zed/assets/2280405/a59f4d6f-db24-403f-a281-2c1148499413 Unfortunately, this `click_out` is the incorrect event for this to happen on. This PR now adds a mechanism for delaying the firing of a cancel action so that toggle buttons can signal that this on_down event should not result in a menu closure. Release Notes: * Made context menus deployed from buttons toggle, instead of hide-and-re-show, visibility on click
Zed
Welcome to Zed, a lightning-fast, collaborative code editor that makes your dreams come true.
Development tips
Dependencies
-
Install Postgres.app and start it.
-
Install the
LiveKitserver and theforemanprocess supervisor:brew install livekit brew install foreman -
Ensure the Zed.dev website is checked out in a sibling directory:
cd .. git clone https://github.com/zed-industries/zed.dev -
Initialize submodules
git submodule update --init --recursive -
Set up a local
zeddatabase and seed it with some initial users:Create a personal GitHub token to run
script/bootstraponce successfully: the token needs to have an access to private repositories for the script to work (repoOAuth scope). Then delete that token.GITHUB_TOKEN=<$token> script/bootstrap
Testing against locally-running servers
Start the web and collab servers:
foreman start
If you want to run Zed pointed at the local servers, you can run:
script/zed-with-local-servers
# or...
script/zed-with-local-servers --release
Dump element JSON
If you trigger cmd-alt-i, Zed will copy a JSON representation of the current window contents to the clipboard. You can paste this in a tool like DJSON to navigate the state of on-screen elements in a structured way.
Licensing
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Wasm Plugins
Zed has a Wasm-based plugin runtime which it currently uses to embed plugins. To compile Zed, you'll need to have the wasm32-wasi toolchain installed on your system. To install this toolchain, run:
rustup target add wasm32-wasi
Plugins can be found in the plugins folder in the root. For more information about how plugins work, check the Plugin Guide in crates/plugin_runtime/README.md.