tims
d090caccd7
Closes #21625 #17401 #16426 This is how the opening of a file works currently: 1. We first check if the file is part of any existing worktree. If it is, we focus on that file in the worktree, and the window is activated. 2. If the file is not part of any worktree, we open it in the first local non-collab workspace we find and activate that window. This is the bug that the issues are based on. This PR fixes it by modifying the second part of the above step, where the file is not part of any worktree. Now, we will first open the file in the active window, but only if the active window is local and non-collab. This resolves the issue. If the file can't be opened in the active window due to the local non-collab check, we will carry out the existing logic of opening the file in whichever window is local and non-collab. I have tested this using the "workspace::OpenFiles" action, and "workspace::Open" also uses the same method. That is, it will work on all platforms. Future: Some users also mentioned there should be a setting for whether we should open a non-workspace file in the existing window or in a separate new window. However, this seems out of scope, and a new issue should be created for this. #9370 is related, but this likely doesn't fix it, as it deals with how macOS Finder's "Open with" handles files. I don't have macOS to test, but this PR won't resolve it if Finder always opens a new window. Release Notes: - Fixed the issue where a file outside of the workspace was opening in a random window instead of the last active window.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.