Boris Vassilev
cbb535f5eb
Fixes #16057 In newer versions of clangd, the switch labelDetailsSupport in the json passed to the language server modifies the format of the returned json. Zed handles well the old format, but misses the function parameters in the new one. For example: The old format looks like this: ```json ... "label": " Window(int width, int height, const char *name, bool vsync, bool resizable)", ... ``` and with labelDetailsSupport = true: ```json ... "label": " Window", "labelDetails": { "detail": "(int width, int height, const char *name, bool vsync, bool resizable)" }, ... ``` A simple solution is to just to not tell the language server that label details are supported and force it to use the old format. This is a dirty fix, but makes the completions behave like in the old versions of clangd. I do not know if this will break another language server. From what I've found out most lsp-s do not depend on that setting and provide all completion data either way. If not, this switch will need to be exposed in a config or be at least lsp-dependant. Lastly, I do not know Rust, maybe will need help to make a better fix for the issue. Release Notes: - Fixed broken C++ completion suggestions
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.