tims
b46b261f11
Closes #22326 This PR adds process PID information to window created by X11, so that window manager can identify which process this window belongs to. Without this property, the window manager would have no reliable way to know which process created this window. In original issue, `robotgo` throws error on `x, y, w, h := robotgo.GetBounds(pid)` this method. If we go deeper into the source code of `robotgo`, it calls `GetXidFromPid` which goes through all windows, and tries to check for provided pid. Hence, when it tries to do that for Zed, it fails and returns `0, err` to caller. ```go // Robotgo source code trying to look through all windows and query pid // GetXidFromPid get the xid from pid func GetXidFromPid(xu *xgbutil.XUtil, pid int) (xproto.Window, error) { windows, err := ewmh.ClientListGet(xu) if err != nil { return 0, err } for _, window := range windows { wmPid, err := ewmh.WmPidGet(xu, window) if err != nil { return 0, err } if uint(pid) == wmPid { return window, nil } } return 0, errors.New("failed to find a window with a matching pid.") } ``` Querying for pid for active Zed window: Before: ```sh tims@lemon ~/w/go-repro [127]> xprop -root _NET_ACTIVE_WINDOW _NET_ACTIVE_WINDOW(WINDOW): window id # 0x4e00002 tims@lemon ~/w/go-repro> xprop -id 0x4e00002 _NET_WM_PID _NET_WM_PID: not found. ``` After: ```sh tims@lemon ~/w/go-repro> xprop -root _NET_ACTIVE_WINDOW _NET_ACTIVE_WINDOW(WINDOW): window id # 0x4e00002 tims@lemon ~/w/go-repro> xprop -id 0x4e00002 _NET_WM_PID _NET_WM_PID(CARDINAL) = 103548 tims@lemon ~/w/go-repro> ``` Correct zed process PID (below) assosiated with zed window (shown above):  Release Notes: - Fix `robotgo` failing when Zed window is open on Linux
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.