tims
b1375ab946
Closes #23216 This crash happens in the `update_visible_entries` function, where we calculate `ancestors` and `current_ancestor_depth`. `ancestors` is map storing information about folded ancestors and `current_ancestor_depth` is basically selected ancestor index in reverse order of visibility. For example, before adding a new file or directory in `a/b/c`, the `ancestors` might look like: ```jsonc { "entry_id_of_c": { "current_ancestor_depth": 2, // "a" is selected "ancestors": ["entry_id_of_a", "entry_id_of_b", "entry_id_of_c"] } } ``` When new file or directory is added to`a`, ancestors length is reduced, as `a` now is not part of folded dir due to having multiple children. But depth still remains the same as while calculating it, we use depth from `old_ancestors` to preserve selection across renders. This causes panic. ```jsonc { "entry_id_of_c": { "current_ancestor_depth": 2, // wrong: use of old depth here causes panic "ancestors": ["entry_id_of_b", "entry_id_of_c"] // correct: notice "a" is missing, as "a" now has multiple children } } ``` This PR fixes it by capping depth so it don't exceed `ancestors` array. This preserves existing depth as well as handles our edge case. Release Notes: - Fixed crash when adding a new file or directory to the first folded directory
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.