Alejandro Fernández Gómez
b0086b472f
Closes #32397 This PR fixes an issue when pasting text with the `editor::Paste` command that was copied with `vim::Yank`'s linewise selection. The change stops setting the `is_entire_line` setting when copying from with vim linewise selections (<kbd>⇧v</kbd>) and motions (i.e. <kbd>y2j</kbd>). This flag is used when cutting/copying text without being selected (so, place a cursor on line without selecting anything, and press <kbd>⌘X</kbd>). When cutting/copying text in this manner, [the editor pastes the text above the cursor](https://github.com/afgomez/zed/blob/36941253ee086af3dc7d2b2729a68bebe387d650/crates/editor/src/editor.rs#L11936-L11947). However, this behaviour is not needed when cutting/copying with vim motions. Pasting with vim operations is not affected by this change. [They are handled elsewhere](https://github.com/afgomez/zed/blob/36941253ee086af3dc7d2b2729a68bebe387d650/crates/vim/src/normal/paste.rs) and they don't consider the `is_entire_line` flag at all. Note for maintainers: I'm not familiar with this codebase 🙃. This change fixes the issue. I don't see anything breaking... but let me know if it's not the case and a more thorough change is needed. **Before:** The text is copied above the first line, before the cursor. https://github.com/user-attachments/assets/0c2f111a-5da0-4775-a7a0-2e4fb6f78bfc **After:** The text is copied at the cursor location: https://github.com/user-attachments/assets/60a17985-fe8b-4149-a77b-d72bf531bf85 Release Notes: - Fixed an issue when pasting text that was yanked with vim's linewise selections.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.