Smit Barmase
ae017c3f96
Closes #26777 This PR fixes a panic when a file name contains a newline and a multi-byte character like 👋 (4 bytes in UTF-8). The issue was in the regex not considering newlines in file names, causing it to match only the latter part of the file name. For example: ``` left: PathWithPosition { path: "ab", row: None, column: None } // matched right: PathWithPosition { path: "ab\ncd", row: None, column: None } // actual file name ``` This resulted in incorrect index calculation later in the code, which went unnoticed until now due to the lack of tests with file names containing newlines. We discovered this issue when a panic occurred due to incorrect index calculation while trying to get the index of a multi-byte character. After the newline fix, the index calculation is always correct, even in the case of multi-byte characters. Release Notes: - Fixed an issue where file names with newlines and multi-byte characters could cause a crash in certain cases.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.