Remco Smits
ac452799b0
This PR fixes a few issues around shutting down a debug adapter. The first issue I discovered was when I shut down all sessions via `shutdown all adapters` command. We would still fetch the threads request again, because we receive a thread event that indicated that it exited. But this will always time out because the debug adapter is already shutdown at this point, so by updating the check so we don't allow fetching a request when the session is terminated fixes the issue. The second issue fixes a bug where we would always shut down the parent session, when a child session is terminated. This was reintroduced by the big refactor. This is not something we want, because you could receive multiple StartDebugging reverse requests, so if one child is shutting down that does not mean the other ones should have been shutting down as well. Issue was original fixed in https://github.com/RemcoSmitsDev/zed/pull/80#issuecomment-2573943661. ## TODO: - [x] Add tests Release Notes: - N/A
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.