Finn Evers
a65ea2708c
This PR is primarily an implementation of @osiewicz [comment](https://github.com/zed-industries/zed/pull/19495#pullrequestreview-2488877957) in an effort to increase maintainability after the horizontal editor scrollbar was added in #19495 . I also want to build on these changes in future PRs to adress some other small bugs. This primarily does the following: 1. Uses `along` wherever possible 2. Fixes the amount of mouse event listeners attached to the editor when scrollbars are displayed to 2 instead of 2-4 in case both scrollbars are displayed. This can be done since only one scrollbar can be dragged by the cursor at any given time, so the event listeners now account for that. The state reflecting the scrollbar dragging state was also updated accordingly. It does not change any functionality besides the aforementioned event listener code as well as some minor bugs which where present after #19495 , namely: - One missing `cx.stop_propagation()` (see [here](https://github.com/zed-industries/zed/blob/a8741dc3107a205ba5a28aa8c3e18747ceed2ba3/crates/editor/src/element.rs#L4684) and [here](https://github.com/zed-industries/zed/blob/a8741dc3107a205ba5a28aa8c3e18747ceed2ba3/crates/editor/src/element.rs#L4838) respectively). - The horizontal scrollbar thumb having a small border on the left side, which seems to be unintended for the horizontal scrollbar whilst intended for the vertical one. Since this is a minimal change, I figured it could be already included in this PR. This PR admittetly grew quite large over time, however, much of the diff is just renames to account for the code now working for both axes as well as moved code. The logic remains (or should at least be) unaffected. If I should split this into two PRs or remove some of the changes, please let me know. Release Notes: - N/A
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.