Lukas Wirth
8ab52f3491
We've been seeing the occasional `cannot seek backwards` panic within `SelectionsCollection` without means to reproduce. I believe the cause is one of the callers of `MutableSelectionsCollection::select` not passing a well formed `Selection` where `start > end`, so this PR enforces the invariant in `select` by swapping the fields and setting `reversed` as required as the other mutator functions already do that as well. We could also just assert this instead, but it callers usually won't care about this so its the less user facing annoyance to just fix this invariant up internally. Fixes ZED-253 Fixes ZED-ZJ Fixes ZED-23S Fixes ZED-222 Fixes ZED-1ZV Fixes ZED-1SN Fixes ZED-1Z0 Fixes ZED-10E Fixes ZED-1X0 Fixes ZED-12M Fixes ZED-1GR Fixes ZED-1VE Fixes ZED-13X Fixes ZED-1G4 Release Notes: - Fixed occasional panics when querying selections
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.