Bennet Bo Fenner
75067c94ad
As you can see in the image, we were previously returning different `ascent`s/`descent`s when a line would/would not contain an Emoji. <img width="104" height="36" alt="image" src="https://github.com/user-attachments/assets/436aeda0-87c0-4dee-943b-6da83681d466" /> --- CoreTexts `CTLineGetTypographicBounds` seems to return a different ascent/descent depending on if an Emoji is there or not AFAIK it is not documented if this is intended behaviour or not. For us it is undesirable, as typing an Emoji causes the line to be shifted to the bottom, see here: https://github.com/user-attachments/assets/2ad1c82e-6297-48ac-a522-fb382ea56eea --- Instead of using `CTLineGetTypographicBounds` to resolve the ascent/descent, we look at every run and choose the maximum ascent/descent. This matches how it [works on Linux](https://github.com/zed-industries/zed/blob/f1d17fcfbef41690fdeb523f0fbddc7c406c5ad6/crates/gpui/src/platform/linux/text_system.rs#L452) Release Notes: - Fixed an issue on macOS where typing an emoji on a line would cause the line to shift downwards by a few pixels
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.