张小白andshenjackyuanjie
6af385c09e
Previously, we used messages greater than `WM_USER` to pass information between `WindowsPlatform` and `WindowsWindow`. For example, to close a window, we handled it as follows: 1. The window sends a message with `WM_USER + 2` to `WindowsPlatform`. 2. `WindowsPlatform`, upon receiving this message, casts the `lparam` to `HWND` and closes the window. According to Microsoft's documentation, it is safe to use values between `WM_USER` and `0xBFFF` as messages. However, certain versions of Microsoft's IME use `WM_USER + 2` for UNKNOWN purposes. This causes step 2 to be erroneously triggered. The IME window's `lparam` value could be arbitrary, leading to an attempt to close an arbitrary `HWND` and resulting in errors. It is quite surprising that Microsoft indicates using `WM_USER + 2` is safe, yet Microsoft itself breaks this convention. I mean, well done Microsoft! This PR addresses the issue by using the `wparam` with a specific random value for validation purpose when sending the aforementioned message. Before `WindowsPlatform` attempts to close the window, it will first verify the `wparam` value. Special thanks to @shenjackyuanjie for helping me on this. Co-authored-by: shenjackyuanjie <3695888@qq.com> Release Notes: - Fixed weird panic when IME window is closing(#15185, #12563). --------- Co-authored-by: shenjack <3695888@qq.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS and Linux you can download Zed directly or install Zed via your local package manager.
Other platforms are not yet available:
- Windows (tracking issue)
- Web (tracking issue)
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.