Thorsten Ball
1afcd12747
This fixes #10185 by not keeping snippet state around when already at the end of the snippet and the tabstop is empty (i.e. it's not a selection) and we're already on it. The reason for the fix is outlined in the comments of #10185 but to repeat: 1. `gopls` sends completions with type "snippet" even when suggesting single word completions that don't contain tabstops 2. We use a default behavior and add an "end tabstop" by default so that the cursor jumps to the end of the snippet when accepting it. 3. We'd then push the state of the snippet on the stack which is where it would stay, with the cursor already at the end and the user unable to get rid of the tabstop state. This fixes the issue by not pushing snippet state when the tabstop we accepted is the "end tabstop". Release Notes: - Fixed completions inside snippets breaking the jump-to-next-tabstop behaviour when using Go/`gopls` ([#10185](https://github.com/zed-industries/zed/issues/10185)). Demo: https://github.com/zed-industries/zed/assets/1185253/35384e5e-45c6-46ab-870d-b48e56d8786b
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
You can download Zed today for macOS (v10.15+).
Support for additional platforms is on our roadmap:
- Linux (tracking issue)
- Windows (tracking issue)
- Web (tracking issue)
For macOS users, you can also install Zed using Homebrew:
brew install --cask zed
Alternatively, to install the Preview release:
brew install --cask zed@preview
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.