Marshall Bowers
14a0d8039b
This PR fixes an issue with the `Checkbox` component where the checkbox wasn't being centered within its container element. The problem can be seen when applying a background color to the container element: #### Before <img width="439" alt="Screenshot 2024-03-11 at 5 44 10 PM" src="https://github.com/zed-industries/zed/assets/1486634/11704b1a-3c3e-4250-99c3-973fb442287a"> #### After <img width="447" alt="Screenshot 2024-03-11 at 5 45 59 PM" src="https://github.com/zed-industries/zed/assets/1486634/569a850b-4bd7-4711-8327-bf426fa5d265"> This resulted in issues where, under certain conditions, the checkbox could get cut off, as seen in #8868. Centering the checkbox fixes this issue: <img width="305" alt="Screenshot 2024-03-11 at 5 51 00 PM" src="https://github.com/zed-industries/zed/assets/1486634/14e5642f-59ad-4288-bc25-ea7da2a008a7"> Fixes #8868. Release Notes: - Fixed a positioning issue with checkboxes ([#8868](https://github.com/zed-industries/zed/issues/8868)).
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
You can download Zed today for macOS (v10.15+).
Support for additional platforms is on our roadmap:
- Linux (tracking issue)
- Windows (tracking issue)
- Web (tracking issue)
For macOS users, you can also install Zed from Homebrew:
brew install zed
Developing Zed
- Building Zed for macOS
- Building Zed for Linux
- Building Zed for Windows
- Running Collaboration Locally
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.