Kirill Bulatov
254b369624
Properly toggle diagnostics ( #3243 )
...
Follow-up of https://github.com/zed-industries/zed/pull/3236 that fixes
a bug introduced in that PR: diagnostics warning toggle stopped working.
Release Notes:
- N/A
2023-11-06 19:35:49 +02:00
Kirill Bulatov
bfb860c06c
Properly toggle diagnostics
2023-11-06 19:29:31 +02:00
Kirill Bulatov
128d3696ad
More heuristics for diagnostics updates ( #3236 )
...
Follow-up of https://github.com/zed-industries/zed/pull/3225
That PR enabled every `project::Event::DiskBasedDiagnosticsFinished` to
update the diagnostics, which turned out to be bad, Zed does query for
more diagnostics after every excerpt update, and that seems to be due to
`Event::Edited` emitted by the multibuffers created in the diagnostics
panel.
* now, instead of eagerly updating the diagnostics every time, only do
that if the panel has 0 or 1 caret placed and no changes were made in
the panel yet.
Otherwise, use previous approach and register the updated paths to defer
their update later.
* on every `update_excerpts` in the diagnostics panel, query the entire
diagnostics summary (and store it for the future comparisons), compare
old and new summaries and re-query diagnostics for every path that's not
in both summaries.
Also, query every path that was registered during the
`DiskBasedDiagnosticsFinished` updates that were not eagerly updated
before.
This way we're supposed to get all new diagnostics (for new paths added)
and re-check all old paths that might have stale diagnostics now.
* do diagnostics rechecks concurrently for every path now, speeding the
overall process
Release Notes:
- Fixed diagnostics triggering too eagerly during multicaret edits and
certain stale diagnostics not being removed in time
2023-11-05 16:17:38 +02:00
Kirill Bulatov
ad93d9132f
Correctly update old diagnostics
2023-11-05 15:37:27 +02:00
Kirill Bulatov
fdcb907644
Parallelize diagnostics filling, add more logs
2023-11-05 15:06:39 +02:00
Kirill Bulatov
ff1d692e46
Restructure inner path data
2023-11-05 14:53:13 +02:00
Kirill Bulatov
7145fabb6d
Eagerly refresh diagnostics that do not intercept with user input
2023-11-05 14:44:22 +02:00
Kirill Bulatov
660c3371e4
Refresh all possibly stale diagnostics pat
2023-11-05 14:43:54 +02:00
Kirill Bulatov
9f40a5c53f
Suppress unused vars warning generated by gpui macro
2023-11-04 13:54:37 +02:00
Kirill Bulatov
edacffab58
Refresh diagnostics inside the tab ( #3225 )
...
r-a now has 2 different types of diagnostics:
* "disk-based" ones that come from `cargo check` and related, that emit
`project::Event::DiskBasedDiagnosticsStarted` and
`DiskBasedDiagnosticsFinished`
* "flycheck" diagnostics from r-a itself, that it tries to dynamically
apply to every buffer open, that come with `DiagnosticsUpdated` event.
Latter diagnostics update frequently, on every file close and open, but
`diagnostics.rs` logic had never polled for new diagnostics after
registering the `DiagnosticsUpdated` event, so the only way we could
have newer diagnostics was to re-open the whole panel.
The PR fixes that, and also adds more debug logging to the module.
The logic of the fix looks very familiar to previous related fix:
https://github.com/zed-industries/zed/pull/3128
One notable thing after the fix: "flycheck" diagnostics stay forever if
the diagnostics panel is opened: excerpts in that panel do not allow the
buffer to get dropped (hence, closed in terms of r-a) and get the
updated, zero diagnostics.
If the diagnostics panel is opened and closed multiple times, those
errors gradually disappear.
Release Notes:
- Fixed diagnostics panel not refreshing its contents properly
2023-11-03 22:03:05 +02:00
Kirill Bulatov
918d123284
Fix the test
2023-11-03 21:51:12 +02:00
Kirill Bulatov
6f8947a3d3
Fix a compilation error
2023-11-03 21:51:12 +02:00
Kirill Bulatov
9cb8ce172d
Refresh diagnostics inside the tab
2023-11-03 21:51:12 +02:00
Kirill Bulatov
90d532f0ba
Uncomment more gpui2 ( #3221 )
...
Release Notes:
- N/A
2023-11-03 13:45:35 +02:00
Kirill Bulatov
1a0cd3e09b
Remove and add more todosmerge .
2023-11-03 13:22:11 +02:00
Kirill Bulatov
f1fc07de94
Move journal2 to workspace2
2023-11-03 12:55:06 +02:00
Kirill Bulatov
eb8a0e7148
Uncomment persistence tests
2023-11-03 12:38:09 +02:00
Kirill Bulatov
a9ab413c5a
Detect prettier in npm workspaces correctly ( #3219 )
...
Deals with https://github.com/zed-industries/community/issues/2016
Also refactored project code to spawn less default prettiers.
Release Notes:
- Fixed prettier not working in npm workspaces
2023-11-03 11:14:45 +02:00
Kirill Bulatov
09346fb9f1
Port changes to zed2
2023-11-03 11:02:50 +02:00
Kirill Bulatov
24dd1c5812
Properly order default prettier installations and startups
2023-11-03 11:02:50 +02:00
Kirill Bulatov
244c693968
Reuse already running default prettiers
2023-11-03 11:02:50 +02:00
Kirill Bulatov
cf95f9b082
Make it more clear that missing prettier is to blame
2023-11-03 11:02:50 +02:00
Kirill Bulatov
369b5140fb
Restore LSP names for prettier servers
2023-11-03 11:02:50 +02:00
Kirill Bulatov
b75d8a60a8
Simplify
2023-11-03 11:02:50 +02:00
Kirill Bulatov
ff144def63
Fix the bugs
2023-11-03 11:02:50 +02:00
Kirill Bulatov
6bbb79a9f5
Rework prettier installation and start
2023-11-03 11:02:50 +02:00
Kirill Bulatov
d673efebd2
Add prettier workspace resolution test
2023-11-03 11:02:50 +02:00
Kirill Bulatov
e8857d959b
WIP
2023-11-01 16:10:07 +02:00
Kirill Bulatov
a9d7c86307
WIP
2023-11-01 15:37:51 +02:00
Kirill Bulatov
73c97d0c10
WIP
...
Uncomment more methods in workspace2.rs
2023-11-01 14:47:29 +02:00
Kirill Bulatov
6a3974ddbb
Remove TODOs
2023-10-31 13:08:18 +02:00
Kirill Bulatov
84c5494949
Fix prettier errors around Zed's settings.json/keymap.json files
...
Ports https://github.com/zed-industries/zed/pull/3191 to zed2
Deals with zed-industries/community#2191
Fix Zed starting too many prettier installations in the beginning, and not being able to format the config files.
2023-10-31 12:26:49 +02:00
Kirill Bulatov
45e695c906
Fix prettier errors around Zed's settings.json/keymap.json files ( #3191 )
...
Deals with https://github.com/zed-industries/community/issues/2191
Fix Zed starting too many prettier installations in the beginning, and
not being able to format the config files.
Release Notes:
- Fixed prettier not being able to format Zed's config files and spawning excessive prettier installations
2023-10-31 12:05:32 +02:00
Kirill Bulatov
6ee9beed73
Enqueue default prettier installations
2023-10-31 11:54:40 +02:00
Kirill Bulatov
c98a811c0b
Only process diagnostics if corresponding project is alive
...
Part of https://github.com/zed-industries/zed/pull/3128 that is possible
to apply now.
2023-10-31 10:40:49 +02:00
Kirill Bulatov
fd6f6cc9f8
Return proper full paths for single file workspaces
2023-10-30 22:33:44 +02:00
Kirill Bulatov
29a32039ba
Start message numbering during prettier init, log error message text
2023-10-30 22:26:06 +02:00
Kirill Bulatov
033d0ae610
Remember default prettier and its plugin installation
2023-10-30 22:09:36 +02:00
Kirill Bulatov
b3c3adab50
Port prettier panic fix to gpui2
2023-10-30 13:00:49 +02:00
Kirill Bulatov
bd30ce837d
Do not panic when looking for prettier ( #3182 )
...
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1698655595438009
Instead of checking FS, derive the prettier path needed and let prettier
invocation fail in logs instead.
2023-10-30 12:59:46 +02:00
Kirill Bulatov
6aca2289eb
Do not panic when looking for prettier ( #3182 )
...
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1698655595438009
Instead of checking FS, derive the prettier path needed and let prettier
invocation fail in logs instead.
2023-10-30 12:58:47 +02:00
Kirill Bulatov
b46a4b5680
Be more lenient when searching for prettier instance
...
Do not check FS for existence (we'll error when start running prettier),
simplify the code for looking it up
2023-10-30 12:13:58 +02:00
Kirill Bulatov
249bec3cac
Do not panic on prettier search
2023-10-30 12:13:54 +02:00
Kirill Bulatov
f16ff79ff8
Properly log prettier paths
2023-10-30 11:17:11 +02:00
Kirill Bulatov
96bbb5cdea
Properly log prettier paths
2023-10-30 11:14:00 +02:00
Kirill Bulatov
27d2accb51
Fix the formatting
2023-10-26 13:52:04 +02:00
Kirill Bulatov
0a04c5734b
Update mouse position during file drag and drop
2023-10-26 13:50:35 +02:00
Kirill Bulatov
483ac9491a
Start fixing room2
2023-10-26 11:27:12 +02:00
Kirill Bulatov and Nathan Sobo
a01b507ef4
Add OS file drop event handler
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-10-24 19:26:06 +02:00
Kirill Bulatov
77991ad865
Fix compilation
2023-10-24 18:22:26 +02:00
Kirill Bulatov
18930c33fe
Make audio2
2023-10-24 17:15:59 +02:00
Kirill Bulatov
1ad7f3a16d
Finish ???-ing project2.rs
2023-10-24 16:35:34 +02:00
Kirill Bulatov
b090cefdde
Rework prettier tests ( #3160 )
...
Do not infuse `FakeNodeRuntime` with prettier exceptions, rather keep
the default formatter installation method as no-op.
2023-10-24 15:34:55 +03:00
Kirill Bulatov
e9ce935991
Rework prettier tests
...
Do not infuse `FakeNodeRuntime` with prettier exceptions, rather keep
the default formatter installation method as no-op.
2023-10-24 14:25:46 +02:00
Kirill Bulatov
0e48465adb
Add a draft of the mac platform file drag and drop events
2023-10-24 14:09:46 +02:00
Kirill Bulatov
4d5ca37edb
Fix the branch compilation
2023-10-24 14:04:45 +02:00
Kirill Bulatov
26638748bb
Move prettier parsers data into languages from LSP adapters ( #3150 )
...
Release Notes:
- Fixed incorrect prettier parsers sometimes being applied to certain
files
2023-10-21 02:22:21 +03:00
Kirill Bulatov
7748848b6e
Move prettier parsers data into languages from LSP adapters
2023-10-21 01:14:03 +02:00
Kirill Bulatov
40104c06e2
Sort hint request ranges before asserting to avoid flackiness
2023-10-19 11:05:47 +03:00
Kirill Bulatov
c380d437c6
Cap every language server logs ( #3134 )
...
* on opening a language server's logs, a new editor for server logs is
now created from `\n`-joined `VecDeque` elements instead of a buffer, as
before
* every `VecDeque` entry is a log line we receiver out of stderr or LSP
server, and their general amount is capped with `let
MAX_STORED_LOG_ENTRIES: usize = 2000;`
* currently opened editor with logs (`Editor::multi_line`) keeps getting
log lines appended and may get over this cap, but only last stored 2000
entries will be restored on reopen
* similarly, cap rpc message logs
Release Notes:
- Improved memory usage by storing less language LSP server and rpc logs
2023-10-17 21:51:21 +03:00
Kirill Bulatov
a95cce9a60
Reduce max log lines, clean log buffers better
2023-10-17 21:47:21 +03:00
Kirill Bulatov
08af830fd7
Do not create buffers for rpc logs
2023-10-17 21:43:34 +03:00
Kirill Bulatov
c872c86c4a
Remove another needless log buffer
2023-10-17 21:43:34 +03:00
Kirill Bulatov
ba5c188630
Update editor with current buffer logs
2023-10-17 21:43:34 +03:00
Kirill Bulatov
5a4161d293
Do not detach subscriptions
2023-10-17 21:43:34 +03:00
Kirill Bulatov
33296802fb
Add a rough prototype
2023-10-17 21:43:34 +03:00
Kirill Bulatov
16d9d77d88
Update diagnostics indicator when diagnostics are udpated ( #3128 )
...
Release Notes:
- Fixed diagnostics indicator not showing proper diagnostics count
2023-10-13 12:30:26 +03:00
Kirill Bulatov
803ab81eb6
Update diagnostics indicator when diagnostics are udpated
2023-10-13 12:13:18 +03:00
Kirill Bulatov
634202340b
Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle ( #3127 )
...
rust-analyzer complains about a bunch of dependency cycles:
```
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> assistant(Idx::<CrateData>(35)), alternative path: assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> breadcrumbs(Idx::<CrateData>(88)), alternative path: breadcrumbs(Idx::<CrateData>(88)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> collab_ui(Idx::<CrateData>(129)), alternative path: collab_ui(Idx::<CrateData>(129)) -> feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> feedback(Idx::<CrateData>(219)), alternative path: feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> quick_action_bar(Idx::<CrateData>(480)), alternative path: quick_action_bar(Idx::<CrateData>(480)) -> assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> search(Idx::<CrateData>(553)), alternative path: search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> semantic_index(Idx::<CrateData>(556)), alternative path: semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> terminal_view(Idx::<CrateData>(643)), alternative path: terminal_view(Idx::<CrateData>(643)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> vim(Idx::<CrateData>(748)), alternative path: vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> welcome(Idx::<CrateData>(775)), alternative path: welcome(Idx::<CrateData>(775)) -> vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> assistant(Idx::<CrateData>(35)), alternative path: assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> breadcrumbs(Idx::<CrateData>(88)), alternative path: breadcrumbs(Idx::<CrateData>(88)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> collab_ui(Idx::<CrateData>(129)), alternative path: collab_ui(Idx::<CrateData>(129)) -> feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> feedback(Idx::<CrateData>(219)), alternative path: feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> quick_action_bar(Idx::<CrateData>(480)), alternative path: quick_action_bar(Idx::<CrateData>(480)) -> assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> search(Idx::<CrateData>(553)), alternative path: search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> semantic_index(Idx::<CrateData>(556)), alternative path: semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> terminal_view(Idx::<CrateData>(643)), alternative path: terminal_view(Idx::<CrateData>(643)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> vim(Idx::<CrateData>(748)), alternative path: vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> welcome(Idx::<CrateData>(775)), alternative path: welcome(Idx::<CrateData>(775)) -> vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
```
so move the example into `zed` instead.
2023-10-13 10:35:35 +03:00
Kirill Bulatov
525ff6bf74
Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle
2023-10-13 10:27:08 +03:00
Kirill Bulatov
ef73bf799c
Fix license issue
2023-10-12 16:26:28 +03:00
Kirill Bulatov
7aea95704e
Revert unnecessary style changes
2023-10-12 16:17:41 +03:00
Kirill Bulatov
09ef3ccf67
Fix tailwind prettier plugin discovery
2023-10-12 15:58:00 +03:00
Kirill Bulatov
12d7d8db0a
Make all formatting to happen on the client's buffers, as needed
2023-10-12 15:29:57 +03:00
Kirill Bulatov
1bfde4bfa2
Add more tests
2023-10-12 15:14:51 +03:00
Kirill Bulatov
7f4ebf50d3
Make the first prettier test pass
2023-10-12 13:30:49 +03:00
Kirill Bulatov
a528c6c686
Prettier server style fixes
2023-10-12 12:31:30 +03:00
Kirill Bulatov
e50f4c0ee5
Add prettier tests infrastructure
2023-10-11 19:13:28 +03:00
Kirill Bulatov
4a88a9e253
Initialize prettier right after the buffer gets it language
2023-10-11 14:48:32 +03:00
Kirill Bulatov
986a516bf1
Small style fixes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
9bf22c56cd
Rebase fixes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
b5705e079f
Draft remote prettier formatting
2023-10-11 12:56:29 +03:00
Kirill Bulatov
2ec2036c2f
Invoke remote Prettier commands
2023-10-11 12:56:29 +03:00
Kirill Bulatov
faf1d38a6d
Draft local and remote prettier separation
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6c1c7eaf75
Better detect Svelte plugins
2023-10-11 12:56:29 +03:00
Kirill Bulatov
2d5741aef8
Better prettier format logging
2023-10-11 12:56:29 +03:00
Kirill Bulatov
a9f80a603c
Resolve prettier config before every formatting
2023-10-11 12:56:29 +03:00
Kirill Bulatov
658b58378e
Properly use WorktreeId
2023-10-11 12:56:29 +03:00
Kirill Bulatov
8a807102a6
Properly support prettier plugins
2023-10-11 12:56:29 +03:00
Kirill Bulatov
afee29ad3f
Do not clear cache for default prettiers
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6ec3927dd3
Allow to configure default prettier
2023-10-11 12:56:29 +03:00
Kirill Bulatov
b109075bf2
Watch for prettier file changes
2023-10-11 12:56:29 +03:00
Kirill Bulatov
f4667cbc33
Resolve prettier config on server init
2023-10-11 12:56:29 +03:00
Kirill Bulatov
d021842fa1
Properly log pre-lsp prettier_server events
2023-10-11 12:56:29 +03:00
Kirill Bulatov
f42cb109a0
Improve prettier_server LSP names in the log panel
2023-10-11 12:56:29 +03:00
Kirill Bulatov
1b70e7d0df
Before server startup, log to stderr
2023-10-11 12:56:29 +03:00
Kirill Bulatov
b687270207
Implement missing prettier_server clear method
2023-10-11 12:56:29 +03:00
Kirill Bulatov
06cac18d78
Return message id in prettier_server error responses
2023-10-11 12:56:29 +03:00
Kirill Bulatov
6cac58b34c
Add prettier language servers to LSP logs panel
2023-10-11 12:56:29 +03:00
Kirill Bulatov
4b15a2bd63
Rebase fixes
2023-10-11 12:56:29 +03:00