Max Brunsfeld and Antonio
fbfe108317
Avoid double borrow in tests by drawing windows explicitly in flush_effects
...
Co-authored-by: Antonio <antonio@zed.dev >
2023-12-11 12:37:10 -08:00
Antonio Scandurra and Max Brunsfeld
9b94f1483a
Redraw the window at the end of flush_effects in tests
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-12-11 20:10:27 +01:00
Antonio Scandurra and Max Brunsfeld
f1ebad22db
Defer drawing the scene until macOS's display_layer callback
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2023-12-11 19:55:55 +01:00
Nate Butler
b9bbc4a698
Extend theme colors ( #3587 )
...
[[PR Description]]
Title
Release Notes:
- N/A
2023-12-11 12:34:06 -05:00
Antonio Scandurra
76cea3e7e8
Fire click event only when using left button ( #3584 )
...
Release Notes:
- N/A
2023-12-11 18:00:13 +01:00
Nate Butler and Marshall Bowers
ea9a42b802
Add new colors to themes
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-12-11 12:00:12 -05:00
Conrad Irwin
59d0feafc5
actions3 ( #3586 )
...
- Fix action registrations
Release Notes:
- N/A
2023-12-11 09:48:57 -07:00
Nate Butler and Marshall Bowers
b8f9918f75
Add new colors to One Dark
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com >
2023-12-11 11:43:49 -05:00
Nate Butler
6792a216a6
Add new color defs
2023-12-11 11:30:43 -05:00
Conrad Irwin
d678efe7dd
Fix some action registrations
2023-12-11 09:29:10 -07:00
Piotr Osiewicz
01ecbec2b0
Comment out the tests
2023-12-11 16:52:12 +01:00
Piotr Osiewicz
ddbd5cf2cb
Merge branch 'main' into project_search2
2023-12-11 16:47:48 +01:00
Piotr Osiewicz
40c1ef88e2
Add Editor::Tab and CycleMode actions
2023-12-11 16:39:17 +01:00
Antonio Scandurra
0b7072bf67
Fire click event only when using left button
2023-12-11 16:20:46 +01:00
Piotr Osiewicz
9f1e7a1e21
fixup! Further warnings churn
2023-12-11 15:54:36 +01:00
Piotr Osiewicz
d4a246cae8
Further warnings churn
2023-12-11 15:53:19 +01:00
Piotr Osiewicz
3c49011d08
Fix up warnings (automatic)
2023-12-11 15:48:42 +01:00
Piotr Osiewicz
7330495709
Make match index 1-based
2023-12-11 15:47:02 +01:00
Piotr Osiewicz
3f87c3541f
Make the query editor expand in size less
2023-12-11 15:40:38 +01:00
Piotr Osiewicz
66e0650f75
Forego using dispatch_action for click handlers
2023-12-11 15:32:28 +01:00
Antonio Scandurra
db39c3d582
Fix porting mistake that caused clicking on the editor to misbehave ( #3583 )
...
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.
Release Notes:
- N/A
2023-12-11 14:30:06 +01:00
Antonio Scandurra
b4fc8ea6f7
Fix porting mistake that caused clicking on the editor to misbehave
...
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.
2023-12-11 14:21:55 +01:00
Antonio Scandurra
3c56f6d5c1
Focus editor when confirming outline item
2023-12-11 14:18:46 +01:00
Piotr Osiewicz
38d844ab66
fixup! Add major text
2023-12-11 14:03:43 +01:00
Antonio Scandurra
5768f14a03
Emit Focus events from Pane only when it didn't have focus before
2023-12-11 14:02:08 +01:00
Antonio Scandurra
e7c14dacae
Show the correct outline when clicking on a breadcrumb
2023-12-11 14:01:16 +01:00
Piotr Osiewicz
1599ee5467
Add major text
2023-12-11 13:56:02 +01:00
Piotr Osiewicz
fe315c6111
Bind actions on the whole search bar, not just the query editor
2023-12-11 13:35:25 +01:00
Kirill Bulatov
36d2ab4537
Always open new project search view workspace::NewSearch action ( #3581 )
2023-12-11 13:45:41 +02:00
Kirill Bulatov
da44b51a53
Always open new project search view workspace::NewSearch action
2023-12-11 13:11:07 +02:00
Kirill Bulatov
55374e8ac0
Port to gpui1
2023-12-11 12:28:22 +02:00
Kirill Bulatov
3694265b6b
Finalize the command
2023-12-11 12:28:22 +02:00
Kirill Bulatov
e3fc810b3d
Draft an expand macro recusively command
2023-12-11 12:28:22 +02:00
Antonio Scandurra
e3c0b1f903
Listen for mouse events on scrollbar
2023-12-11 10:33:05 +01:00
Antonio Scandurra
03df63aa00
Merge remote-tracking branch 'origin/main' into scrollbars2
2023-12-11 09:51:43 +01:00
Conrad Irwin
cea26c9d10
actions3 ( #3578 )
...
- Restore impl_actions! and remove derive(Action)
Originally in gpui2 we inferred the action's namespace from the module
it was
defined in. This worked most of the time (ignoring the "remove_the_2"
hack),
but caused unintended (and mostly invisible) behavior in crates with
multiple
modules.
#3577 restored the namespace parameter to actions!, and this PR
reintroduces
`impl_actions!` to do the same for non-unit structs.
I considered trying to keep the struct-attribute API work, because it
does feel
more stylistically appropriate for rust, but two problems lead to it
feeling less good than `impl_actions!` in practice:
1. You have to repeat the namespace for each struct (and usually you're
defining them all in the same namespace)
2. You can't pass an argument to a derive macro inline, you need to use
an attribute instead.
Release Notes:
- N/A
2023-12-10 19:59:53 -07:00
Conrad Irwin
c5367e3085
Correct docs re:Debug
2023-12-10 19:52:17 -07:00
Conrad Irwin
9ce7395b74
Restore impl_actions! and remove derive(Action)
2023-12-10 19:33:38 -07:00
Joseph T. Lyons
ff45b43857
Add code for submission and error states for feedback modal ( #3572 )
...
Release Notes:
- N/A
2023-12-10 20:49:14 -05:00
Conrad Irwin
62d6a85a71
Restore namespace parameter to actions! ( #3577 )
...
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
Although automatically deriving the namespace worked in many situations,
it was
unclear what to do with nested modules. Vim wanted all actions to be
registered
under vim, while collab_ui wanted one namespace per action.
It seems better to make the implicit explicit, and give the flexibility
to hide
implementation details from the end-users.
Release Notes:
- N/A
2023-12-09 15:27:17 -07:00
Conrad Irwin
4290c67b6a
Restore namespace parameter to actions!
...
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
2023-12-09 15:18:31 -07:00
Max Brunsfeld
7b722c326f
Paint code-action/fold buttons above the gutter
2023-12-09 11:41:40 -08:00
Max Brunsfeld
6b58eb202d
Fix crash due to mutating command palette's candidates on confirmation
2023-12-09 11:08:33 -08:00
Piotr Osiewicz
0be58eb61a
Add a bunch of tooltips
2023-12-09 12:24:55 +01:00
Piotr Osiewicz
b09d2219d0
Add basic landing page
2023-12-09 12:00:44 +01:00
Joseph T. Lyons
33c41fb5e1
Show negative numbers after limit is hit
2023-12-09 00:35:19 -05:00
Max Brunsfeld
f3b764b7d2
Enable tests for MentionsEditor
2023-12-08 16:42:36 -08:00
Max Brunsfeld
e4bc346723
Initialize toggle chat panel action
2023-12-08 16:42:22 -08:00
Joseph T. Lyons
9abf5a1bf2
Add code for submission and error states
2023-12-08 19:16:03 -05:00
Max Brunsfeld
049314e84e
Restructure chat message rendering to allow text to wrap
2023-12-08 15:44:27 -08:00