Conrad Irwin cea26c9d10
actions3 ( #3578 ) ...
- Restore impl_actions! and remove derive(Action)
Originally in gpui2 we inferred the action's namespace from the module
it was
defined in. This worked most of the time (ignoring the "remove_the_2"
hack),
but caused unintended (and mostly invisible) behavior in crates with
multiple
modules.
#3577 restored the namespace parameter to actions!, and this PR
reintroduces
`impl_actions!` to do the same for non-unit structs.
I considered trying to keep the struct-attribute API work, because it
does feel
more stylistically appropriate for rust, but two problems lead to it
feeling less good than `impl_actions!` in practice:
1. You have to repeat the namespace for each struct (and usually you're
defining them all in the same namespace)
2. You can't pass an argument to a derive macro inline, you need to use
an attribute instead.
Release Notes:
- N/A
2023-12-10 19:59:53 -07:00
2023-12-09 15:18:31 -07:00
2023-11-14 08:28:57 -05:00
2023-12-05 19:27:15 +01:00
2023-11-30 11:20:51 -05:00
2023-12-09 15:18:31 -07:00
2023-11-02 10:55:02 -07:00
2023-11-17 12:54:16 -08:00
2023-12-09 15:18:31 -07:00
2023-12-08 18:22:53 -05:00
2023-11-19 21:52:28 -05:00
2023-12-04 17:05:44 -08:00
2023-10-25 15:39:02 +02:00
2023-12-08 12:31:07 -08:00
2023-12-04 09:16:04 -05:00
2023-12-09 15:18:31 -07:00
2023-12-08 12:48:02 -05:00
2023-12-08 12:31:07 -08:00
2023-11-17 21:40:56 +02:00
2023-12-10 19:33:38 -07:00
2023-12-05 14:57:20 +01:00
2023-12-05 14:57:20 +01:00
2023-12-10 19:33:38 -07:00
2023-12-06 14:29:09 -08:00
2023-12-09 15:18:31 -07:00
2023-12-04 23:35:31 +00:00
2023-10-25 07:10:21 -07:00
2023-11-02 10:55:02 -07:00
2023-11-30 15:46:30 +02:00
2023-12-09 15:18:31 -07:00
2023-11-23 19:28:11 +02:00
2023-12-10 19:59:53 -07:00
2023-11-28 22:47:04 -07:00
2023-12-10 20:49:14 -05:00
2023-11-30 16:05:45 +02:00
2023-12-09 15:18:31 -07:00
2023-11-03 12:15:23 -04:00
2023-11-24 17:28:59 +01:00
2023-11-02 19:18:01 -06:00
2023-12-09 15:18:31 -07:00
2023-11-14 00:06:33 -08:00
2023-12-10 19:52:17 -07:00
2023-12-10 19:33:38 -07:00
2023-11-04 13:54:37 +02:00
2023-12-09 15:18:31 -07:00
2023-11-18 10:46:35 -08:00
2023-11-30 11:38:16 +02:00
2023-12-06 21:48:39 +02:00
2023-12-09 15:18:31 -07:00
2023-10-17 21:47:21 +03:00
2023-10-31 14:04:03 -07:00
2023-12-10 19:33:38 -07:00
2023-10-19 23:05:06 -06:00
2023-11-30 12:22:23 +02:00
2023-11-30 13:07:47 +02:00
2023-12-09 15:18:31 -07:00
2023-10-25 19:31:47 +02:00
2023-11-08 19:29:00 -08:00
2023-12-06 14:29:09 -08:00
2023-10-22 17:10:21 +02:00
2023-11-08 21:23:31 -08:00
2023-12-09 15:18:31 -07:00
2023-12-06 11:01:22 -05:00
2023-11-29 10:58:22 +02:00
2023-11-29 11:52:26 +02:00
2023-12-05 16:13:39 +02:00
2023-12-05 16:13:39 +02:00
2023-12-05 12:30:29 +02:00
2023-12-09 15:18:31 -07:00
2023-12-06 16:14:39 -05:00
2023-12-07 12:52:34 +01:00
2023-12-09 15:18:31 -07:00
2023-11-09 13:23:31 -08:00
2023-10-23 12:50:57 +02:00
2023-12-08 15:44:27 -08:00
2023-11-16 16:03:14 -08:00
2023-11-16 16:03:14 -08:00
2023-12-05 12:30:29 +02:00
2023-12-05 16:13:39 +02:00
2023-11-23 09:53:00 +02:00
2023-12-10 19:33:38 -07:00
2023-11-27 15:06:20 -08:00
2023-12-05 15:38:36 +01:00
2023-12-09 15:18:31 -07:00
2023-11-16 10:40:02 +02:00
2023-11-21 13:42:00 -05:00
2023-12-09 15:18:31 -07:00
2023-12-09 15:18:31 -07:00
2023-12-05 12:30:29 +02:00
2023-12-10 19:33:38 -07:00
2023-11-03 14:53:08 +01:00
2023-11-03 12:15:23 -04:00
2023-10-25 15:39:02 +02:00
2023-12-08 17:56:25 -05:00
2023-12-08 17:56:25 -05:00
2023-12-09 15:18:31 -07:00
2023-12-09 15:18:31 -07:00
2023-12-06 12:53:02 +01:00
2023-10-25 18:34:14 +02:00
2023-12-05 14:57:20 +01:00
2023-10-23 11:06:58 +02:00
2023-12-09 15:18:31 -07:00
2023-12-05 12:30:29 +02:00
2023-12-10 19:33:38 -07:00
2023-12-06 14:29:09 -08:00
2023-12-09 15:18:31 -07:00
2023-12-10 19:33:38 -07:00
2023-10-28 11:37:25 -04:00
Conrad Irwin
cea26c9d10