Marshall Bowers
a0224b975b
Use link_text_hover for go-to-definition links
2023-12-19 18:24:52 -05:00
Marshall Bowers
53b76e3e4d
Style pane drop targets ( #3726 )
...
This PR styles the pane drop targets using the `drop_target_background`
color from the theme.
We do have to adjust the alpha channel of the color so that it doesn't
obscure the contents of the buffer.
Release Notes:
- N/A
2023-12-19 18:06:21 -05:00
Marshall Bowers
547ad77243
Style tab drop targets for project entries ( #3725 )
...
This PR styles the drop targets when dragging a project entry onto a tab
or the tab bar.
I also adjusted the existing tab drop targets to use the
`drop_target_background` from the theme.
Release Notes:
- N/A
2023-12-19 17:45:42 -05:00
Max Brunsfeld
599ec5c25b
Make collab panel usable from the keyboard, add missing styling ( #3724 )
...
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items
2023-12-19 14:33:56 -08:00
Max Brunsfeld
afd3bf7746
Add missing selected state and keyboard action for some collab panel items
2023-12-19 14:16:44 -08:00
Max Brunsfeld
901795bcb9
Don't reset the collab panel when it loses focus
2023-12-19 14:12:29 -08:00
Max Brunsfeld
1b09862384
Restrcit context for some editor bindings that don't apply to single-line editors
2023-12-19 14:11:59 -08:00
Kirill Bulatov
acbb3f39f6
Better display items from different sources with different z-indices in the same place ( #3723 )
2023-12-20 00:01:37 +02:00
Kirill Bulatov and Antonio Scandurra
cf12d62fc5
Tidy up z-index handling
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 23:50:42 +02:00
Marshall Bowers
097640e7c5
Fix typo in ButtonCommon doc comment ( #3722 )
...
This PR fixes a small typo in the doc comments for `ButtonCommon`.
Was waiting to roll this up into another PR, but it never ended up
happening.
Release Notes:
- N/A
2023-12-19 16:32:57 -05:00
Kirill Bulatov
f6d31917c1
Optimize stack id in-memory layout
2023-12-19 23:31:17 +02:00
Kirill Bulatov and Antonio Scandurra
8f1c5375ef
Fix more z-index and rendering issues
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 23:30:17 +02:00
825a8f0927
Initial fix of the z-index
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2023-12-19 23:29:08 +02:00
Marshall Bowers
a9fe108dbb
Fix typo in "Quote Selection" tooltip ( #3721 )
...
This PR fixes a typo in the "Quote Selection" tooltip.
Release Notes:
- N/A
2023-12-19 16:21:58 -05:00
Marshall Bowers
7bc9319871
Apply padding at the toolbar level ( #3720 )
...
This PR adjusts the padding in the toolbar to be applied within the
toolbar itself.
Previously the different elements within the toolbar were applying their
own padding, which led to inconsistencies.
Release Notes:
- N/A
2023-12-19 16:01:03 -05:00
Max Brunsfeld
407478d411
Add missing collab panel features ( #3719 )
...
* channel modal
* channel invites in collab panel
2023-12-19 12:16:01 -08:00
Max Brunsfeld and Nathan
a9b1273e2b
Clean up commented code
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-12-19 12:06:47 -08:00
Max Brunsfeld and Nathan
1c3698ae20
Implement channel modal
...
Co-authored-by: Nathan <nathan@zed.dev >
2023-12-19 12:02:35 -08:00
Marshall Bowers
4e07167288
Use child instead of children ( #3718 )
...
This PR refactors some code where we were using `children` when we could
have used `child` instead.
Release Notes:
- N/A
2023-12-19 13:49:52 -05:00
Max Brunsfeld
80b6922de7
wip
2023-12-19 10:20:40 -08:00
Max Brunsfeld
a4bfd0147d
Render channel invites in collab panel, fix unused warnings
2023-12-19 10:20:40 -08:00
Marshall Bowers
a3bab25792
Style contact finder ( #3717 )
...
This PR styles the contact finder.
<img width="598" alt="Screenshot 2023-12-19 at 12 59 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ca9d9345-bf27-4256-aabc-6017a0c4d217 ">
Release Notes:
- N/A
2023-12-19 13:16:14 -05:00
Julia
ef39382c84
Allow editor mouse drag selection outside interactive bounds ( #3716 )
...
Release Notes:
- N/A
2023-12-19 13:07:31 -05:00
Julia
961f989388
Match zed1 scrollbar drag behavior ( #3715 )
...
Still not ideal, but we need to ship and this is more than reasonable
Release Notes:
- N/A
2023-12-19 13:00:26 -05:00
Julia and Antonio Scandurra
e08fc0bbc0
Allow editor mouse drag selection outside interactive bounds
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 13:00:21 -05:00
Julia and Antonio Scandurra
51396344a3
Match zed1 scrollbar drag behavior
...
Still not ideal, but we need to ship and this is more than reasonable
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2023-12-19 12:50:06 -05:00
Nate Butler
e778e17f54
Style assistant panel ( #3711 )
...
[[PR Description]]
Styles most of the assistant panel. A few notes:
- We now cut off the title if it gets to long so the assistant tools
don't get cut off
- I wasn't able to get to the "no api key" state, so that hasn't been
style checked yet.
- A few of icons were updated in this PR
I also added a new tooltip that teaches you a bit about role cycling:
🐜 Known issues 🐜
- There is a bug where zooming the panel makes it shift 1px (@maxdeviant
I think this has to do with panel borders)
- We are showing a timestamp for new conversations before you have sent
a message/launched an assist action. I wasn't sure how to case this out.
Before:
After:
Release Notes:
- N/A
2023-12-19 12:11:18 -05:00
Marshall Bowers
616ea131af
Style buffer search input ( #3713 )
...
This PR styles the text input for the buffer search.
Release Notes:
- N/A
2023-12-19 12:11:06 -05:00
Max Brunsfeld
b797cd3e71
Fix panel resize ( #3707 )
...
* [x] Reposition right dock handle
* [x] Handle mouse events correctly for drag and drop
* [x] Prevent drag events from passing through the resize handle to the
draggable items in the panels (channels, files)
* [x] Stop the editor gutter from stealing mouse move events
2023-12-19 09:08:56 -08:00
Nate Butler
5d95e13cc8
Update assistant editor
2023-12-19 12:04:01 -05:00
Max Brunsfeld
e655d2434a
Don't stop propagation on mouse move over editor gutter
2023-12-19 09:02:25 -08:00
Nate Butler
d8eea949ef
Update assistant panel message header, model switcher
2023-12-19 11:58:20 -05:00
Nate Butler
a1085184a1
use to_string to return the format distance string from FormatDistance
2023-12-19 11:57:57 -05:00
Max Brunsfeld
cf037ea4a8
Merge branch 'main' into fix-panel-resize
2023-12-19 08:55:55 -08:00
Nate Butler
d8a8feb45c
Add FormatDistance struct, add hide_prefix option
2023-12-19 11:41:14 -05:00
Marshall Bowers
3e6b84a726
Wire up the middle mouse button to close tabs ( #3714 )
...
This PR wires up the middle mouse button to close tabs.
Right now we're doing this using `on_mouse_down`, but we need a way in
GPUI2 to have an `on_click` for a mouse button other than the left one.
Release Notes:
- N/A
2023-12-19 11:26:55 -05:00
Nate Butler
79653d2175
Rename format distance test names
2023-12-19 11:19:18 -05:00
Nate Butler
ae313ff830
Allow format_distance to take a DateTimeType
2023-12-19 11:16:59 -05:00
Nate Butler
30b01b9bc0
Update imports, tab height const
2023-12-19 11:03:08 -05:00
Nate Butler
286f654517
Update assistant header
2023-12-19 10:57:36 -05:00
Antonio Scandurra
cc107f72f8
Maintain scroll position in CollabPanel after updating entries ( #3712 )
...
Release Notes:
- N/A
2023-12-19 16:41:25 +01:00
Nate Butler
57efaa92cf
Style assistant header, update icons
2023-12-19 10:30:46 -05:00
Antonio Scandurra and Julia
dd84993d76
Maintain scroll position in CollabPanel after updating entries
...
Co-Authored-By: Julia <julia@zed.dev >
2023-12-19 16:06:00 +01:00
Nate Butler
42a02e4fb6
Remove red border
2023-12-19 10:03:59 -05:00
Nate Butler
2c402f9b5d
Ensure conversation items fill the container
2023-12-19 10:03:26 -05:00
Nate Butler
49502af4d3
Update conversation item rendering
2023-12-19 09:56:29 -05:00
Antonio Scandurra
91b65958a7
Fix janky editor scrollbar dragging ( #3710 )
...
We can receive multiple events before computing the next frame, and in
that case we want to compute a drag delta between the position for the
previous mouse event and the current one.
Release Notes:
- N/A
2023-12-19 15:41:15 +01:00
Antonio Scandurra
b30fd3f574
Fix janky editor scrollbar dragging
...
We can receive multiple events before computing the next frame, and
in that case we want to compute a drag delta between the position for the
previous mouse event and the current one.
2023-12-19 15:32:42 +01:00
Antonio Scandurra
1bb85c1b9a
Prevent default when mousing down on a button that responds to clicks ( #3709 )
...
This ensures that ancestors that track focus don't accidentally steal it
on mouse down, which was preventing the editor from deploying the code
actions menu.
Release Notes:
- N/A
2023-12-19 14:41:58 +01:00
Antonio Scandurra
afbc61a344
Prevent default when mousing down on a button that responds to clicks
...
This ensures that ancestors that track focus don't accidentally steal
it on mouse down, which was preventing the editor from deploying the
code actions menu.
2023-12-19 14:27:19 +01:00
Marshall Bowers