oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,157 Commits 1 Branch 0 Tags
9efe5a30aab08aded81b45addea299123e77dc41
Commit Graph
61 Commits
Author SHA1 Message Date
Joseph T. Lyons 73b527ec8f Store email address on modal close 2023-12-21 09:04:54 -05:00
Joseph T. Lyons 036636ee80 Fix layout issues with feedback modal 
The feedback modal still needs a styling update
 2023-12-20 23:54:50 -05:00
Joseph T. Lyons 4e7005b4f7 Use bitflags to hold error states 2023-12-14 17:22:13 -05:00
Joseph T. Lyons 8a361c93e2 Prep feedback code for testing 2023-12-14 13:22:41 -05:00
Joseph T. Lyons 837b4c3462 Avoid unnecessary match 2023-12-13 21:43:21 -05:00
Joseph T. Lyons d9adfdeac2 Highlight email address field as red when invalid 2023-12-13 21:39:31 -05:00
Joseph T. Lyons 435256ab0f Remove completed TODOs 2023-12-13 21:35:30 -05:00
Joseph T. Lyons 900a2bfb87 Use an enum to represent modal states and simplify logic 2023-12-13 21:20:09 -05:00
Joseph T. Lyons be2ad2ff86 Add Duration dependency 2023-12-13 21:19:36 -05:00
Joseph T. Lyons 052e05fc74 Use existing convention to silence warnings 2023-12-13 21:19:12 -05:00
Joseph T. Lyons 7ba7b925ff Simulate sending feedback in dev 2023-12-13 21:18:50 -05:00
Joseph T. Lyons 1ad1cc1148 Fix variable name 2023-12-13 17:31:51 -05:00
Joseph T. Lyons 985d4c7429 Remove TODO 
Thanks @ConradIrwin
 2023-12-13 17:09:26 -05:00
Conrad Irwin e91ecec8cd fix modal exchange (#3620) 
- Fix opening GoToLine from Command
- Extend test to cover go_to_line behavior too

Release Notes:

- N/A
 2023-12-12 21:30:34 -07:00
Conrad Irwin a2f0accb74 Fix opening GoToLine from Command 
This was broken because of the async hop introduced by should_dismiss.

Change that API to instead be syncronous, and require that implementors
(of which there is only one) to call dismiss again if they want to.
 2023-12-12 20:46:27 -07:00
Joseph T. Lyons a63b4c598c Use release channel display name for feedback 2023-12-12 17:29:37 -05:00
Joseph T. Lyons c9aa4a0e00 Fix placeholder text 2023-12-12 16:56:43 -05:00
Joseph T. Lyons 906505f4dc Fix rustfmt in feedback_modal.rs 2023-12-11 13:56:58 -05:00
Joseph T. Lyons ff45b43857 Add code for submission and error states for feedback modal (#3572) 
Release Notes:

- N/A
 2023-12-10 20:49:14 -05:00
Conrad Irwin 4290c67b6a Restore namespace parameter to actions! 
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
 2023-12-09 15:18:31 -07:00
Joseph T. Lyons 33c41fb5e1 Show negative numbers after limit is hit 2023-12-09 00:35:19 -05:00
Joseph T. Lyons 9abf5a1bf2 Add code for submission and error states 2023-12-08 19:16:03 -05:00
Joseph T. Lyons cbbcc3502a Fix bug where feedback dismissal prompt is shown twice 2023-12-08 17:21:14 -05:00
Joseph T. Lyons 13dad89a85 Move all dismissal logic into dismiss_event 2023-12-08 16:14:45 -05:00
Joseph T. LyonsandMikayla Maki 113c7287df Allow modals to override their dismissal 
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com>
 2023-12-08 15:29:44 -05:00
Joseph T. Lyons be6c909587 Remove some unused imports 2023-12-08 13:13:40 -05:00
Joseph T. Lyons 63cc9e5068 Move character counter up above editor in feedback modal 2023-12-08 13:07:16 -05:00
Joseph T. Lyons 4596e7a68a Use consistent text 2023-12-08 11:39:10 -05:00
Joseph T. Lyons b66e1d2d58 Fix compiler error 2023-12-08 11:35:49 -05:00
Joseph T. Lyons 260a753005 Fix rustfmt 2023-12-08 11:33:18 -05:00
Joseph T. Lyons 1f51f74670 Add TODO 2023-12-07 22:24:32 -05:00
Joseph T. Lyons 8b9b19195d Fix bug with how characters limits are being displayed 2023-12-07 13:19:03 -05:00
Joseph T. Lyons 0ee4ad6ba0 Skip using map 2023-12-07 13:00:49 -05:00
Joseph T. Lyons 794b795800 Add TODO 2023-12-07 12:04:04 -05:00
Nate Butler 5e5eb25aab WIP 
[no-ci]
 2023-12-07 10:50:07 -05:00
Nate Butler f798b193d0 WIP 2023-12-07 01:46:28 -05:00
Nate Butler 7a1eb54106 checkpoint 2023-12-07 00:33:24 -05:00
Joseph T. Lyons 79e0d8ce3b WIP 2023-12-06 23:15:04 -05:00
Joseph T. Lyons 256f0308ae Renove unused code 2023-12-06 21:32:33 -05:00
Joseph T. Lyons d62b151bc0 Improve character limit bounds indicator 2023-12-06 21:23:51 -05:00
Joseph T. Lyons 668f5accab Highlight whole modal as needing UI tweaks 2023-12-06 19:35:41 -05:00
Joseph T. Lyons 57a9f024e7 Remove email address from local database if user removes it 2023-12-06 19:26:25 -05:00
Joseph T. Lyons bbe9986f38 Start work to add a confirmation when exiting feedback containing text 2023-12-06 19:13:38 -05:00
Joseph T. Lyons 1abc9800af Switch to if let statement 2023-12-06 19:11:24 -05:00
Joseph T. Lyons 034c11cc96 Hook up community repo button 2023-12-06 19:11:03 -05:00
Joseph T. Lyons 0885fa67fc Hook up submit 2023-12-06 19:10:45 -05:00
Joseph T. Lyons 110612bf26 Reduce amount of state being stored 2023-12-06 18:36:17 -05:00
Joseph T. Lyons 46c998ca8d WIP 2023-12-06 17:27:10 -05:00
Joseph T. Lyons f4c7b13397 temp 2023-12-06 16:15:44 -05:00
Joseph T. Lyons 02a6a2e1a3 Revert "Delete feedback_modal.rs" 
This reverts commit eff925cb6a.
 2023-12-06 14:13:56 -05:00