oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move character counter up above editor in feedback modal

Browse Source
This commit is contained in:
Joseph T. Lyons
2023-12-08 13:07:16 -05:00
parent 4596e7a68a
commit 63cc9e5068
1 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/feedback2/src/feedback_modal.rs
+23 -23
View File
@@ -301,6 +301,29 @@ impl Render for FeedbackModal {
// TODO: Add Headline component to `ui2`
div().text_xl().child("Share Feedback"),
))
.child(
Label::new(if self.character_count < *FEEDBACK_CHAR_LIMIT.start() {
format!(
"Feedback must be at least {} characters.",
FEEDBACK_CHAR_LIMIT.start()
)
} else if self.character_count > *FEEDBACK_CHAR_LIMIT.end() {
format!(
"Feedback must be less than {} characters.",
FEEDBACK_CHAR_LIMIT.end()
)
} else {
format!(
"Characters: {}",
*FEEDBACK_CHAR_LIMIT.end() - self.character_count
)
})
.color(if valid_character_count {
Color::Success
} else {
Color::Error
}),
)
.child(
div()
.flex_1()
@@ -313,29 +336,6 @@ impl Render for FeedbackModal {
)
.child(
div()
.child(
Label::new(if self.character_count < *FEEDBACK_CHAR_LIMIT.start() {
format!(
"Feedback must be at least {} characters.",
FEEDBACK_CHAR_LIMIT.start()
)
} else if self.character_count > *FEEDBACK_CHAR_LIMIT.end() {
format!(
"Feedback must be less than {} characters.",
FEEDBACK_CHAR_LIMIT.end()
)
} else {
format!(
"Characters: {}",
*FEEDBACK_CHAR_LIMIT.end() - self.character_count
)
})
.color(if valid_character_count {
Color::Success
} else {
Color::Error
}),
)
.child(
h_stack()
.bg(cx.theme().colors().editor_background)