Jason Lee
f1281c14dd
Revert Windows normal window title style to WS_EX_APPWINDOW ( #14132 )
...
Release Notes:
- N/A
@ConradIrwin we must revert this little change.
https://github.com/zed-industries/zed/pull/14063#issuecomment-2221867379
2024-07-10 20:49:55 -06:00
Jason Lee
5bc3846d59
Fix #14106 Windows title bar broken ( #14122 )
...
Release Notes:
- N/A
----
Fix #14106
Sorry, the previous change in #14063 I have made a mistake. I shouldn't
have changed the previous logic.
```diff
- if !state_ptr.hide_title_bar {
+ if state_ptr.hide_title_bar {
```
## Test
https://github.com/zed-industries/zed/assets/5518/e03fbcac-be6b-4a9d-8937-d3b5e236b564
And the popup window limit is still works.
2024-07-10 18:55:51 -06:00
Jason Lee
15662f105e
gpui: Fix TextStyle default font_family crash on Windows, use Segoe UI for Windows ( #14040 )
...
Release Notes:
- Fixed default font_family crash on Windows, use `Segoe UI`.
## Crash error message
```
thread 'main' panicked at crates\gpui\src\text_system.rs:150:9:
failed to resolve font 'Helvetica' or any of the fallbacks:
Zed Plex Mono, Helvetica, Cantarell, Ubuntu, Noto Sans, DejaVu Sans
```
2024-07-10 13:40:42 -06:00
Jason Lee
1887a6db53
gpui: Fix popup kind window support on Windows ( #14063 )
...
Release Notes:
- N/A
----
Continue #14044 for Windows
## The problem
The `cx.open_window` method has provided us a `window_kind` option to
allows creating a Popup kind. This behavior can work on macOS, the popup
kind window have no-border, no-shadow, no-resize, and followed the
`is_movable` if present true it can't move.
This PR to fix those supports on Windows.
The border and shadow still exist, I have tried to use WS_POPUP
window_style, but it will crash:
> This is looks like complex, it is out of my known.
```
Blocking waiting for file lock on build directory
Compiling gpui v0.1.0 (F:\work\zed\crates\gpui)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.96s
Running `target\debug\examples\window_positioning.exe`
thread 'main' panicked at F:\Users\jason\.cargo\git\checkouts\blade-b2bcd1de1cf7ab6a\21a56f7\blade-graphics\src\vulkan\init.rs:864:18:
called `Result::unwrap()` on an `Err` value: ERROR_OUT_OF_DEVICE_MEMORY
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\examples\window_positioning.exe` (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN)
```
So I just make a simple change, to use `WS_EX_TOOLWINDOW` this can
disable resize, and connect `is_movable` to `handle_hit_test_msg` to
disable move, and also no Status Bar icon.
## Before
https://github.com/zed-industries/zed/assets/5518/76740a71-e0ba-401f-958d-f4afdeb417c6
## After
https://github.com/zed-industries/zed/assets/5518/dca49f13-914c-425a-b8b6-b9fc15f8d208
2024-07-10 13:39:54 -06:00
Jason Lee
b693cbfcb7
Fix line wrap for CJK characters ( #11296 )
...
Release Notes:
- Fixed line wrap for CJK characters.
## Demo
https://github.com/zed-industries/zed/assets/5518/c6695bb4-b170-4ce0-9a84-c36b051de438

Fix issues: #4623 #11202
### Render case
```
## fr
Bien démarrer avec la documentation GitHub Découvrez comment commencer à créer, à livrer et à gérer des logiciels avec GitHub. Explorez nos produits, inscrivez-vous pour obtenir un compte et connectez-vous à la plus grande communauté de développement du monde.
## zh
GitHub 入门文档 了解如何开始构建、运输和维护具有 GitHub 的软件。 了解我们的产品,注册一个帐户,与世界上最大的发展社区建立联系。
## es
Documentación sobre la introducción a GitHub Aprende cómo comenzar a crear, enviar y mantener software con GitHub. Explora nuestros productos, regístrate para una cuenta y conéctate con la comunidad de desarrollo más grande del mundo.
## kr
GitHub 설명서 시작 GitHub를 사용하여 소프트웨어 빌드, 납품 및 유지 관리를 시작하는 방법을 알아봅니다. 제품을 탐색하고, 계정에 등록하고, 세계 최대의 개발 커뮤니티와 연결합니다.
## ja
GitHub の概要に関するドキュメント GitHub を使用してソフトウェアの構築、出荷、および保守を始める方法を学びます。 当社の製品を探索し、アカウントにサインアップして、世界最大の開発コミュニティと繋がりましょう。
## pt
Documentação de introdução ao GitHub Aprenda a começar a criar, enviar e manter um software com a GitHub. Explore nossos produtos, inscreva-se em uma conta e conecte-se com a maior comunidade de desenvolvimento do mundo.
## ru
Начало работы с документацией по GitHub Узнайте, как начать создание, доставку и обслуживание программного обеспечения с помощью GitHub. Изучите наши продукты, зарегистрируйте учетную запись и присоединитесь к крупнейшему в мире сообществу разработчиков.
```
2024-07-10 13:10:19 -06:00
Jason Lee
d4ddc4c62c
gpui: Fix cx.bounds, cx.open_window position on macOS ( #14044 )
...
Release Notes:
- gpui: Fixed `cx.bounds` method to get correct `y` position on macOS.
- gpui: Fixed `cx.open_window` position when macOS Dock is existed.
- Fixed call notification and reopen window position.
## Before

https://github.com/zed-industries/zed/assets/5518/ab925779-4253-4b27-9084-01023888087f
## After
<img width="533" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/142e9aaa-ae82-4a72-9acf-04097c545bf0 ">
https://github.com/zed-industries/zed/assets/5518/8793824a-8b74-4913-8204-7b39649aeeed
---
The case is I have made a Popover by use child window, the coordinate of
the window is always can't placement a right position.
So, I make this example to test the `cx.bounds` and set bounds to
window.
---
By this test, is the `cx.bounds` have a bug?
For example the **Top Left** window, we give it origin (150,150), but it
`cx.bounds()` returns (150,262)
> On the window label, middle line is the `bounds` that we set to the
window, last line is `cx.bounds()` result.
Display 1:
<img width="1512" alt="CleanShot 2024-07-10 at 14 52 26@2x"
src="https://github.com/zed-industries/zed/assets/5518/3adf9e79-f237-431a-a72b-02face7b2361 ">
---
Or is there something I missed. Is it correct to use `cx.bounds` method
to get the bounds of the current window?
At the same time, I also found that when there are multiple screens, the
information obtained by cx.bounds is very different on different
screens, and it seems that the origin is not relative to the screen.
Display 2:
<img width="2560" alt="SCR-20240710-nkmq"
src="https://github.com/zed-industries/zed/assets/5518/d87d4151-0562-4bf8-b3b3-5da3b4d09d82 ">
2024-07-10 09:52:33 -06:00
Jason Lee
ae414e21f0
gpui: Fix hide titlebar on Windows, with titlebar: None option ( #13975 )
...
Release Notes:
- N/A
Ref the macOS Window:
When the `titlebar` is none, the titlebar should be hidden.
https://github.com/zed-industries/zed/blob/adaa4831766cde63b408909cf65cdeb1641e5888/crates/gpui/src/platform/mac/window.rs#L516-L528
```
cargo run -p gpui --example window_positioning
```
## Before

## After
<img width="466" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/176ce4ea-14e9-44c8-8f2d-01e20ff3e543 ">
2024-07-09 12:04:55 -07:00
Jason Lee
6cedfa0ce7
example: Fix Input example mistake ( #13574 )
...

Release Notes:
- N/A
2024-06-27 11:28:44 +03:00
Jason Lee
d501a877a0
windows: Improve file_finder to support match with unix style path ( #12357 )
...
Release Notes:
- Improved file_finder to support match with Unix style path.
Sometimes we may get the Unix style path string, for example the result
of `git status`:
```bash
$ git status
On branch improve-file-finder-match-unix-paths
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: crates/file_finder/src/file_finder.rs
```
For example, from GitHub page:
<img width="760" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/c6fe8d8a-839e-4eef-a162-43b1dde09593 ">
If we copy that path to file_finder, it will not match any files on
Windows.
## Before
<img width="699" alt="屏幕截图 2024-05-28 001037"
src="https://github.com/zed-industries/zed/assets/5518/2d2d729e-7d27-421b-9a38-cfe4e53cc033 ">
## After
Use Unix style path:
<img width="689" alt="屏幕截图 2024-05-28 001150"
src="https://github.com/zed-industries/zed/assets/5518/e82dc8d6-bd6c-4b78-bd91-5b5210da73c4 ">
Use Windows style path:
<img width="629" alt="屏幕截图 2024-05-28 001302"
src="https://github.com/zed-industries/zed/assets/5518/4892019e-b2f4-41aa-bbf7-2f5f8af7aafa ">
2024-06-20 11:33:49 -07:00
Jason Lee and Thorsten Ball
ae55d35f19
windows: Fix project prepare_ssh_shell to support setting PATH on Windows ( #12370 )
...
Release Notes:
- N/A
Update to use `std::env::join_paths` to prepare `PATH` env.
Ref
https://github.com/zed-industries/zed/pull/12087#issuecomment-2122852384
@mrnugget
---------
Co-authored-by: Thorsten Ball <mrnugget@gmail.com >
2024-06-03 11:57:50 +02:00
Jason Lee and Piotr Osiewicz
3c6c850390
task: Add re-run task button to terminal title ( #12379 )
...
Release Notes:
- Added re-run task button to terminal title.
Close #12277
## Demo
https://github.com/zed-industries/zed/assets/5518/4cd05fa5-4255-412b-8583-68e22f86561e
---------
Co-authored-by: Piotr Osiewicz <piotr@zed.dev >
2024-05-29 11:40:43 +02:00
Jason Lee
8c8c1769c7
docs: Fix quote in default.json ( #11900 )
...
Release Notes:
- N/A
2024-05-16 12:46:08 +02:00
Jason Lee
6df1bc85aa
Fix runnable, code_actions button can not trigger when editor not focused ( #11729 )
...
## Before
https://github.com/zed-industries/zed/assets/5518/546450fc-ad2c-45d0-8bdb-7b15cfebe235
## After
https://github.com/zed-industries/zed/assets/5518/efc4f863-9db1-4846-83ae-c99ae4dcb3ed
Release Notes:
- Fixed code actions/runnable buttons not triggering when editor is not focused.
2024-05-13 11:02:15 +02:00
Jason Lee and Marshall Bowers
5e06ce4df3
Add zip extract support for Windows ( #11156 )
...
Release Notes:
- [x] Fixed install Node.js runtime and NPM lsp installation on Windows.
- [x] Update Node runtime command to execute on Windows with no window
popup.
Ref #9619 , #9424
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-05-09 09:23:21 -04:00
Jason Lee and Marshall Bowers
beee79a9e7
toml: Fix language server installation on Windows ( #11251 )
...
Release Notes:
- N/A
---
Follow #11156 , to make sure extensions install on window.
https://github.com/tamasfe/taplo/releases/tag/0.8.1
The Taplo have `gz` for windows, so we can just use `gz`.
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-05-03 11:11:46 -04:00
Jason Lee
7065da2b98
Fix project-panel double click file support on Windows ( #10917 )
...
Release Notes:
- Fixed project panel double click to force open file on Windows.
Ref issue: #10898
@bennetbo
I saw you was also used `event.down.click_count` in Markdown Preview.
https://github.com/zed-industries/zed/commit/7dccbd8e3b61c48ae174807a4023332b7c1df06a#diff-c8d1735cb347ea08d03198df112343ec50a74de8d50414a6f3be6c6d674c6d19R161
And this also used in other place:
<img width="870" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/b844e700-b95f-4cd2-987f-9e4305ebdd7c ">
## Test demo after updated
Looks like it is no side effect

2024-04-25 10:01:24 -07:00
Jason Lee
0861ceaac2
Add yield keyword highlight for Rust ( #10104 )
...
Release Notes:
- Added `yield` keyword highlight for Rust
Ref:
- https://github.com/rust-lang/rust-analyzer/pull/7209
-
https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide/src/syntax_highlighting/highlight.rs#L177
-
https://doc.rust-lang.org/reference/keywords.html?highlight=yield#reserved-keywords
In VS Code:

docs.rs:
https://docs.rs/async-stream/latest/async_stream/macro.try_stream.html

## Before
<img width="644" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/da349187-57e6-4cea-b3e3-f628ce6a99e8 ">
## After update in Zed

2024-04-04 17:56:33 +02:00
Jason Lee
8eeecdafec
Add crate keyword to Rust ( #10110 )
...
Release Notes:
- Fixed `crate` keyword not being highlighted in Rust files.
Ref: #10104
And I make a sort for them.
2024-04-03 17:27:22 +02:00
Jason Lee
0ce5cdc48f
Only allow opening one Extensions view ( #9569 )
...
Release Notes:
- Changed the extensions view to only allow one open instance at a time.
## Before
<img width="494" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/9329e685-1946-4384-bec3-f7eadf18a0cc ">
2024-03-20 14:49:36 -04:00
Jason Lee and Marshall Bowers
269d2513ca
Add support for applying theme after extension is installed ( #9529 )
...
Release Notes:
- Added support for opening the theme selector with installed themes
after installing an extension containing themes.
([#9228 ](https://github.com/zed-industries/zed/issues/9228 )).
<img width="1315" alt="Screenshot 2024-03-20 at 11 00 35 AM"
src="https://github.com/zed-industries/zed/assets/1486634/593389b3-eade-4bce-ae17-25c02a074f21 ">
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-03-20 11:13:58 -04:00
Jason Lee
5abcc1c3c5
Let LineColumn on StatusBar as clickable to open GoToLineColumn ( #9002 )
...
Release Notes:
- Added to let LineColumn on StatusBar as clickable to open
GoToLineColumn.
- Added placeholder to GoToLineColumn input, and show help message on
input changed.
## Screenshot

2024-03-08 14:11:17 -07:00
Jason Lee
bc7fb9f253
Show tooltip with item paths for recent project picker items ( #8987 )
...
Before

After

Release Notes:
- Fixed empty tooltip for recent projects picker items
2024-03-07 17:35:48 +02:00
Jason Lee
2f15676b7c
Update App Menus to add ... for some modal action menu, and group menu items by type. ( #8951 )
...
Release Notes:
- Improved App Menu, add `...` for modal action menu, and group menu
items by type.
In macOS and Windows, the `...` suffix of menu item, is means that will
open a dialog.
2024-03-06 12:10:09 -05:00
Jason Lee
4a60326c1c
Remove workspace border, avoid the main window having double borders ( #8922 )
...
Release Notes:
- Fixed main window border, avoid double borders.
## Diff (Left is Before, Right is After)


Reference to Safari:

## More Theme tests




2024-03-06 10:03:59 -05:00
Jason Lee
567fee4219
Update Project search to Project Search. ( #8943 )
...
Release notes:
- N/A
2024-03-06 15:23:55 +01:00
Jason Lee
0b34b1de7b
Fix first/last item margin on scroll ( #8880 )
...

Before:
https://github.com/zed-industries/zed/assets/5518/f7a4563a-504a-4a41-bfd4-21e9439cd02b
After:
https://github.com/zed-industries/zed/assets/5518/0ba41527-46fd-404f-8207-1b8c5cf37434
Release Notes:
- Fixed first and last item margin when scroll view has padding
2024-03-05 15:54:48 +02:00
Jason Lee
fae5e83d93
Fix all Picker Item cursor to use Pointer. ( #8877 )
...
Before:
https://github.com/zed-industries/zed/assets/5518/84874858-7847-4fa4-b7a3-41ecc65a2f7d
After:
https://github.com/zed-industries/zed/assets/5518/d395ea96-aa26-4de1-8bfc-73cc43ee75cf
Release Notes:
- Made picker items to use `Pointer` cursor style
2024-03-05 11:32:57 +02:00
Jason Lee
6a268e959f
Improve VCS Menu header top margin. ( #8879 )
...
## Before


## After


Release Notes:
- Improve VCS Menu header top margin, and use `TextMuted` color for
matched count label.
2024-03-05 10:19:52 +01:00
Jason Lee
538298378a
Return "open in new window" as default in recent projects ( #8798 )
...
https://github.com/zed-industries/zed/assets/5518/8bbd13a7-9144-48b0-9bc8-6651725476f8
Closes https://github.com/zed-industries/zed/issues/8651
Reworks `recent_projects::OpenRecent` action with collab projects in mind:
* keep the "open in new window" behavior for corresponding menu and command entries
* use new, "reuse current window" behavior in the recent projects picker up in the toolbar
This way, old Zed behavior is not customizable, kept as original in all main use cases — so that projects shared via remote entities: a channel and a call, are never accidentally closed, breaking the sharing.
Release Notes:
- Return "open in new window" as default in recent projects
2024-03-04 11:42:30 +02:00
Jason Lee
47bcb305af
Use Pointer cursor style on Recent Projects, VCS Menu. ( #8595 )
...
Release Notes:
- Improved to use `Pointer` style cursor on VCS and Recent Projects
menu.
https://github.com/zed-industries/zed/assets/5518/4f638c6a-00b8-4fa8-b469-4d3109827bc2
2024-02-29 12:27:56 +01:00
Jason Lee and Marshall Bowers
225dd0f9a0
Improve extensions UI detail ( #8578 )
...
Release Notes:
- Improved "Extensions" UI details to tidy layout, add border, add
placeholder to search input.
## Before

## After



---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-02-28 22:34:40 -05:00
Jason Lee
aff858bd00
Added a cmd-backspace keybinding to delete files in the project panel. ( #8163 )
...
Fixes #7228
Release Notes:
- Added a `cmd-backspace` keybinding to delete files in the project panel ([7228](https://github.com/zed-industries/zed/issues/7228 ))
2024-02-22 12:59:01 +02:00
Jason Lee and Marshall Bowers
e7fcddff69
Parse version from GitHub tag name instead of release name ( #7423 )
...
If we not change this, some release will parse error.
https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28
```json
{
"name": {
"type": [
"string",
"null"
]
}
}
```
<img width="1188" alt="image"
src="https://github.com/zed-industries/zed/assets/5518/bd53dbc4-ae2c-4f19-afd7-58e70b4f87d8 ">
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-02-08 15:28:51 -05:00