Agus Zubiaga
6912dc8399
Fix CC tool state on cancel ( #35763 )
...
When we stop the generation, CC tells us the tool completed, but it was
actually cancelled.
Release Notes:
- N/A
2025-08-07 20:26:19 -03:00
Ben Brandt and Antonio Scandurra
90fa921756
Wire up find_path tool in agent2 ( #35799 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com >
2025-08-07 22:21:26 +00:00
03876d076e
Add system prompt and tool permission to agent2 ( #35781 )
...
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com >
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2025-08-07 13:40:12 +00:00
Agus Zubiaga and Cole Miller
bd1c26cb5b
Fix interrupting ACP threads and CC cancellation ( #35752 )
...
Fixes a bug where generation wouldn't continue after interrupting the
agent, and improves CC cancellation so we don't display "[Request
interrupted by user]"
Release Notes:
- N/A
---------
Co-authored-by: Cole Miller <cole@zed.dev >
2025-08-06 22:55:17 -03:00
Agus Zubiaga
69dc870828
Fix CC todo tool parsing ( #35721 )
...
It looks like the TODO tool call no longer requires a priority.
Release Notes:
- N/A
2025-08-06 13:27:11 +00:00
Agus Zubiaga
22fa41e9c0
Handle CC thinking ( #35722 )
...
Release Notes:
- N/A
2025-08-06 13:20:53 +00:00
Agus Zubiaga
3bbd32b70e
Support CC migrate-installer path ( #35717 )
...
If we can't find CC in the PATH, we'll now fall back to a known local
install path.
Release Notes:
- N/A
2025-08-06 12:23:47 +00:00
eb4b73b88e
ACP champagne ( #35609 )
...
cherry pick changes from #35510 onto latest main
Release Notes:
- N/A
---------
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Antonio Scandurra <me@as-cii.com >
Co-authored-by: Lukas Wirth <lukas@zed.dev >
2025-08-06 09:01:06 +00:00
Cole Miller and Agus
bc2108cbba
Render error state when agent binary exits unexpectedly ( #35651 )
...
This PR adds handling for the case where an agent binary exits
unexpectedly after successfully establishing a connection.
Release Notes:
- N/A
---------
Co-authored-by: Agus <agus@zed.dev >
2025-08-05 22:52:08 +00:00
Agus Zubiaga
b7469f5bc3
Fix ACP connection and thread leak ( #35670 )
...
When you switched away from an ACP thread, the `AcpThreadView` entity
(and thus thread, and subprocess) was leaked. This happened because we
were using `cx.processor` for the `list` state callback, which uses a
strong reference.
This PR changes the callback so that it holds a weak reference, and adds
some tests and assertions at various levels to make sure we don't
reintroduce the leak in the future.
Release Notes:
- N/A
2025-08-05 19:10:51 -03:00
Cole Miller and Agus
a508a9536f
Handle startup failure for gemini-cli ( #35624 )
...
This PR adds handling for the case where the user's gemini-cli binary
fails to start up because it's too old to support the
`--experimental-acp` flag. We previously had such handling, but it got
lost as part of #35578 .
This doesn't yet handle the case where the server binary exits
unexpectedly after the connection is established; that'll be dealt with
in a follow-up PR since it needs different handling and isn't specific
to gemini-cli.
Release Notes:
- N/A
Co-authored-by: Agus <agus@zed.dev >
2025-08-05 16:29:19 -04:00
Agus Zubiaga
1325bf1420
Update to acp 0.0.18 ( #35595 )
...
Release Notes:
- N/A
2025-08-04 18:45:17 +00:00
Agus Zubiaga
a6a34dad0f
Fix gemini e2e tests ( #35583 )
...
Release Notes:
- N/A
2025-08-04 15:02:22 +00:00
Ben Brandt and Agus Zubiaga
f17943e4a3
Update to new agent schema ( #35578 )
...
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <agus@zed.dev >
2025-08-04 13:49:41 +00:00
Finn Evers and Danilo Leal
397b5f9301
Ensure context servers are spawned in the workspace directory ( #35271 )
...
This fixes an issue where we were not setting the context server working
directory at all.
Release Notes:
- Context servers will now be spawned in the currently active project
root.
---------
Co-authored-by: Danilo Leal <danilo@zed.dev >
2025-07-29 18:03:43 +02:00
Agus Zubiaga
9353ba7887
Fix remaining agent server integration tests ( #35222 )
...
Release Notes:
- N/A
2025-07-29 12:40:59 +00:00
Agus Zubiaga
fd68265efd
Fix integration tests for claude ( #35212 )
...
Release Notes:
- N/A
2025-07-28 16:18:01 +00:00
Agus Zubiaga and Ben Brandt
c2fc70eef7
ACP over MCP server impl ( #35196 )
...
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com >
2025-07-28 14:14:10 +00:00
Ben Brandt
c995d45bd9
agent_servers: Include result text in Claude error messages ( #35156 )
...
This will better surfaces issues that are classified as "success" but
actually have a more meaningful error message attached.
Release Notes:
- N/A
2025-07-27 13:58:02 +00:00
Ben Brandt
a5b7cfd128
agent_servers: Use built-in interrupt handling for Claude sessions ( #35154 )
...
We no longer have to stop and restart the entire process.
I left in the Start/Resume mode handling since we will likely need to
handle restarting Claude in other situations.
Release Notes:
- N/A
2025-07-27 13:50:04 +00:00
Agus Zubiaga
af0c909924
McpServerTool output schema ( #35069 )
...
Add an `Output` associated type to `McpServerTool`, so that we can
include its schema in `tools/list`.
Release Notes:
- N/A
2025-07-25 02:57:18 +00:00
Agus Zubiaga
15c9da4ea4
Add ability to register tools in McpServer ( #35068 )
...
Makes it easier to add tools to a server by implementing a trait
Release Notes:
- N/A
2025-07-25 02:19:20 +00:00
2d0f10c48a
Refactor to use new ACP crate ( #35043 )
...
This will prepare us for running the protocol over MCP
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com >
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com >
Co-authored-by: Richard Feldman <oss@rtfeldman.com >
2025-07-24 14:39:29 -03:00
Agus Zubiaga
5d985fa1d8
Improve MCP server responses ( #34927 )
...
Release Notes:
- N/A
2025-07-22 22:14:34 +00:00
Agus Zubiaga and Ben Brandt
722a05bc21
Wire up stop button in claude threads ( #34839 )
...
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com >
2025-07-21 20:33:59 +00:00
Agus Zubiaga
cc56196152
Fix loading agent server settings ( #34662 )
...
Release Notes:
- N/A
2025-07-21 14:26:00 +00:00
Agus Zubiaga and Danilo Leal
405244d422
Display ACP plans ( #34816 )
...
Release Notes:
- N/A
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com >
2025-07-21 11:11:37 -03:00
Ben Brandt
57ab09c2da
claude: Don't quote executable path in mcp configuration ( #34805 )
...
This was generating an invalid string for the configuration, removing
the extra quotes makes it work. This affected the versions of Zed that
have a space in their name.
Release Notes:
- N/A
2025-07-21 09:53:05 +00:00
Ben Brandt
cfe1adc792
E2E Claude tests ( #34702 )
...
- **Fix cancellation of tool calls**
- **Make tool_call test more resilient**
- **Fix tool call confirmation test**
Release Notes:
- N/A
2025-07-18 13:17:41 +00:00
Agus Zubiaga
dab0b3509d
Unify agent server settings and extract e2e tests out ( #34642 )
...
Release Notes:
- N/A
2025-07-17 17:34:38 +00:00
Ben Brandt
b0eac4267d
Mark glob/grep as code blocks ( #34628 )
...
Release Notes:
- N/A
2025-07-17 15:01:02 +00:00
8e4555455c
Claude experiment ( #34577 )
...
Release Notes:
- N/A
---------
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com >
Co-authored-by: Anthony Eid <hello@anthonyeid.me >
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com >
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Oleksiy Syvokon <oleksiy.syvokon@gmail.com >
2025-07-17 14:25:55 +00:00
fc24102491
Tweaks to ACP for the Gemini PR ( #34506 )
...
- **Update to use --experimental-acp**
- **Fix tool locations**
Closes #ISSUE
Release Notes:
- N/A *or* Added/Fixed/Improved ...
---------
Co-authored-by: mkorwel <matt.korwel@gmail.com >
Co-authored-by: Agus Zubiaga <agus@zed.dev >
2025-07-15 17:52:50 -06:00
Conrad Irwin
495ec7a109
ACP ( #34030 )
...
Implements an ACP client that can be used from the agent panel
2025-07-09 16:02:31 +00:00
Agus Zubiaga