oak-gpui

3 Commits

Author SHA1 Message Date

Author	SHA1	Message	Date
waffle	f738fbd4f8	gpui: Disable rounding in the layout engine (#31836 ) Rounding broke (among other things, probably) pixel-perfect image rendering with non-power-of-two scaling factor. An example which reproduces the problem can be found [here](https://github.com/WaffleLapkin/gpui_taffy_rounding_whyyyyy). How it looks with `gpui` from `main`: ![2025-05-31 11:34:25+CEST](https://github.com/user-attachments/assets/2cb19312-6ba6-4e80-8072-f89ddedff77b) How it looks with this patch: ![2025-05-31 11:35:28+CEST](https://github.com/user-attachments/assets/114b52a9-58c0-4600-871c-a20eceb7179e) Both screenshots are made on kde+wayland with magnification using kde's built-in magnification (`Meta`+`+`, `Meta`+`-`). Note that screenshot apps have a high chance of lying 🙃 The image itself is 400 by 300 pixels of red/green checkerboard pattern made specifically to exaggerate scaling issues. Release Notes: - N/A	2025-06-24 20:28:57 +00:00
waffle	c7da6283cc	gpui: Fix typo in doc comment (#31397 ) Release Notes: - N/A	2025-05-26 07:59:51 +03:00
Waffle MaybeandMarshall Bowers	eec8660759	Use `.is_some_and()` instead of `.is_some() && .unwrap()` (#9704 ) That's nicer & more readable. (I just noticed that this looks weird while trying to understand why zed changes my cursor, so decided to make a quick fix (btw the issue with the cursor is that zed always loads cursor named "default" on wayland)) Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>	2024-03-25 11:11:35 -04:00

f738fbd4f8

gpui: Disable rounding in the layout engine (#31836 )

Rounding broke (among other things, probably) pixel-perfect image
rendering with non-power-of-two scaling factor.

An example which reproduces the problem can be found
[here](https://github.com/WaffleLapkin/gpui_taffy_rounding_whyyyyy).

How it looks with `gpui` from `main`:
![2025-05-31
11:34:25+CEST](https://github.com/user-attachments/assets/2cb19312-6ba6-4e80-8072-f89ddedff77b)

How it looks with this patch:
![2025-05-31
11:35:28+CEST](https://github.com/user-attachments/assets/114b52a9-58c0-4600-871c-a20eceb7179e)

Both screenshots are made on kde+wayland with magnification using kde's
built-in magnification (`Meta`+`+`, `Meta`+`-`). Note that screenshot
apps have a high chance of lying 🙃

The image itself is 400 by 300 pixels of red/green checkerboard pattern
made specifically to exaggerate scaling issues.

Release Notes:

- N/A

2025-06-24 20:28:57 +00:00

waffle

c7da6283cc

gpui: Fix typo in doc comment (#31397 )

Release Notes:

- N/A

2025-05-26 07:59:51 +03:00

Waffle MaybeandMarshall Bowers

eec8660759

Use .is_some_and() instead of .is_some() && .unwrap() (#9704 )

That's nicer & more readable.

(I just noticed that this looks weird while trying to understand why zed
changes my cursor, so decided to make a quick fix (btw the issue with
the cursor is that zed always loads cursor named "default" on wayland))

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

2024-03-25 11:11:35 -04:00