- src/facade/rust -> src/engine/rust; package oakfacade -> oakengine
- crate-type += cdylib; module crates are real deps; linkage anchors
force-link module C ABIs into the dylib
- build.rs: -undefined dynamic_lookup for host-provided oakcore_*/fb_*
- nm: 749 oakengine_* + 687 module oak*_* exports; undefined set is
only the intended host-provided symbols
- worker/cli updated to the new path/name; undo test race fix
- oakcore-rs: Rational/TimeRange/TimeRangeList/PixelFormat/SampleFormat
mirroring oakcore C++ semantics (91.6% coverage)
- oakundo: UndoCommand/UndoStack with vtable commands (99.6%)
- oakcommon: config/XML/VideoParams/logging etc. (89.8%, 516 tests);
XML via quick-xml, logging via the log facade
- oaktimeline: markers/workarea/edit commands (95.4%)
- oakaudio: processor/manager/sync/waveform/levelmeter (88.4%)
- unified -MMCCCC error codes across all C ABI headers (registry in
include/common/error.h; pass-through rule)
- olive::Variant moved node -> common (cross-module value type)
- oakcommon_videoparams_set_is_3d added to the C ABI
- M11 (oakplugin Rust rewrite) plan + notes.md freeze line for the
inter-module C ABI wiring
- oakrender cache C API: add create_for_node (four cache kinds),
get_uuid, request, load/save_state, set_saving_enabled,
set_passthrough, get_passthroughs, get_valid_cache_filename,
get_timebase, lock/unlock, invalidate_range (rational variant),
get_native (C++ only, for the in-module PreviewAutoCacher)
- Node's four caches become owned OakRenderCache value handles; all
cache access in node.cpp/clip/viewer/traverser/serializers goes
through the C ABI
- oaknode_node_get_video_frame_cache returns an addref'd
OakRenderCache; drop OakNodeFrameCache; oaktask precache/export and
oakrender_video_ticket_params take the value handle
- color: OCIOBaseNode/OCIOLutNode hold OakColorProcessor handles
(dtors added); oakrender gains color_processor_create_transform/
create_lut/create_grading_primary/get_native and LUT library
queries, keeping all OCIO transform construction inside oakrender;
oaknode gains colormanager_wrap_borrowed/get_native
- RenderManager::instance() check -> oakrender_manager_available();
cancel_video_tasks and disk cache path go through manager C API
- remaining node->render C++ symbol: only olive::Texture::~Texture
via Variant's shared_ptr payload (recorded exception, same class as
the UndoCommand inheritance)
Tests: new cache/color/manager/colormanager cases; all standalone
trees green (common 196, codec 22, audio 40, task 112, render 63,
timeline 125, node 98, plugin 102).
- ViewerOutput owns timeline markers/work area via refcounted
OakTimeline* value handles (oaktimeline_*_create) instead of C++
objects
- oaktimeline C API: add marker_list_create/marker_add/
workarea_create/workarea_set_enabled; handle boxes gain an optional
deleter for owning handles
- oaknode_node_get_markers/get_work_area return addref'd OakTimeline*
handles via out params (named-struct forward declarations avoid the
public header cycle); drop OakNodeMarkerList/OakNodeWorkArea
- serializers 210528-230220 load/save markers and work areas through
the oaktimeline C API; SerializedMarker POD replaces
std::vector<TimelineMarker*> in the serializer interface
- Sequence::add_default_nodes uses oaktimeline_add_track_command
- clip.cpp display-mode enums come from the new neutral
include/timeline/displaymode.h; delete src/node/transition/timeline
- oakcommon xml: add oakcommon_xml_reader/writer_wrap_native borrowed
wrappers (C++ adapter use)
- liboaknode now has zero C++ symbol references into liboaktimeline
Tests: new owning-handle and wrap_native cases; all standalone trees
green (common 196, codec 22, audio 40, task 110, render 49,
timeline 123, node 96, plugin 100).
- de-Qt src/plugin/src (olivehost/oliveplugininstance/oliveclip/
paraminstance/image/pluginprogressreporter); QMessageBox/
QApplication replaced by facade callbacks
- new C ABI in include/plugin/{error,host,instance}.h with
refcounted OakPluginInstance value handle
- paraminstance bridges via oaknode C ABI (OakNodeNode value handle,
oaknode_node_identity registry); undo via oakundo C ABI
- oliveclip textures are OakRenderTexture value handles; oakrender
gains texture/copier/ticket C API additions
- oaknode gains get_input_at_time/set_input_at_time_undoable/
node_identity/sequence_from_node/sequence_set_default_parameters/
find_input_footage
- move avframeptr.h to src/common/src (shared by codec and render)
- node transition pluginSupport stubs bridge the real oakplugin
headers; all oaknode-building standalone trees add src/plugin and
link oakplugin into their test binaries
- plugin tests self-sufficient (ipc shim, OfxHost force_load,
PRE_TEST discovery, OCIO env); timeline standalone gains
render/c_api
- restore ffmpegdecoder.cpp in src/codec/src/ffmpeg/CMakeLists.txt
(dropped in 3d004c081, caused jump-to-0 in decoder/encoder tests)
All six standalone trees green: codec 22, audio 40, task 110,
render 49, timeline 121, plugin 100.
- oakrender: renderer/texture/frame/cache/colorprocessor/ticket/copier
all become by-value {ctx, addref, release, abi_version} handles over a
generic box; retain() folds into addref; new
oakrender_cache_wrap_borrowed for native caches from oaknode
- oaktimeline: marker list/workarea borrowed handles become value
handles (non-owning boxes) with explicit free
- oaktask: OakTaskTask becomes a value handle; ownership still moves
to the manager on start (owns flag flips)
- consumers (timeline/task/codec sources) migrated; tests everywhere
updated; suites green: render 45, timeline 117, task 106, node 96,
common 193, codec 18, audio 36
- LoadOTIOTask/SaveOTIOTask de-Qt'd: graph traversal and construction
through oaknode C ABI (find_input_footage, sequence defaults, block
factories, context positions), track creation through oaktimeline's
add_track command; the OTIO import dialog becomes a facade callback
(headless default: accept all)
- oaknode additions: find_input_footage, sequence_set_default_parameters
- USE_OTIO + otio-install libs wired into oaktask; OTIO dylibs copied
next to liboaktask for @loader_path resolution
- OTIO round-trip test passes; build-oaktask 106/106 green
- oakrender: new ticket family (render_frame/render_audio with finished
callback, result frame/samples access, cancel/wait), project copier
C API, cache get_invalidated_ranges, manager set_aggressive_gc
- oaknode: node_copy_inputs, set_value_hint_track, viewer params
setters, video frame cache borrowed outlet, project copy_settings
- oakcodec: encoder desired pixel format, export format extension,
encoding generate_matrix, custom range in encoding params POD
- oaktask: RenderTask orchestrates oakrender tickets (no Qt threads/
watchers), PreCacheTask and ExportTask rewritten over the oaknode/
oakrender/oakcodec C ABIs; frames cross from oakrender to oakcodec
handles by pixel copy (different control blocks)
- the two-step texture/download render path collapses into single-step
(tickets always yield frames); subtitle sidecar kept
- tests: 105 in build-oaktask (export/precache factory paths,
construction, conform end-to-end); regressions all green
- Task base: Qt signals become lifecycle listeners (the async-command
callback exception), cancellation uses oakrender's OakCancelAtom C
handle; TaskManager runs std::thread workers, no signals
- ConformTask/ProxyTask implement oakcodec's submit-callback contract
(synchronous interim); register_codec_task_submitter() closes the
conform/proxy loop - conform of demo.mp4 produces pcm caches in tests
- ProjectImportTask/ProjectLoadTask/ProjectSaveTask over the oaknode
C ABI; image-sequence confirmation becomes a facade callback
(default: not a sequence)
- C API additions needed by oaktask: oaknode serializer file-level
save/load (auto-initializing), footage video-params/cancel-atom/
as-node, folder add-child command factory; oakcodec decoder
conform_audio + image-sequence helpers; oakrender cancelatom
get_native
- fix double-ownership: submitting a task to the manager transfers
ownership, freeing its handle only releases the wrapper
- C ABI in include/task (task/manager/project, OakTaskTask opaque
handle + lifecycle subscribe), every function tested (103 cases in
build-oaktask incl. regressions)
- RenderTask family and OTIO tasks follow in separate commits
- de-Qt all 11 sources: markers/workarea lose QObject/signals (list
re-sort via direct resort() call, drawing moves to the app layer),
explicit unique_ptr ownership for marker lists and viewer's
workarea/markers
- timeline undo command families (split/pointer/ripple/general/track)
now hold oaknode C handles and do all graph work through the oaknode
C ABI (no adapter layer); gaps are attached to the project graph
before insertion, orphan handles tracked and freed
- fix the de-Qt severed Block->Track length-changed chain with a
direct block_length_changed() call (positions were stale after
split/trim)
- expand oaknode C API by ~20 functions needed by timeline
(copy_in_graph, block kind/casts, connect_element, input arrays,
tracklist family, marker/workarea borrowed outlets)
- pure C ABI in include/timeline (marker/workarea/edit, command
factories returning OakUndoCommand), oakcommon XML get_native
accessors
- oaknode<->oaktimeline resolve each other at runtime; standalone
drivers link both into test binaries
- tests: oaktimeline 117, regressions oakcommon 193 / oaknode 96 /
oakrender 42 / oakcodec 18 / oakaudio 36 all green
- config moves into oakcommon as ConfigStore + oakcommon_config_* C
API (INI storage, typed entries, error-handler injection); node and
render call sites keep OAK_CONFIG() macro shape via a local shim
that forwards to the C API; transition config stubs removed
- oakaudio: de-Qt all six classes, C ABI in include/audio with
refcounted handles (processor/manager/waveform/levelmeter/sync,
48 functions); PreviewAudioDevice moved in from render; recording
goes through oakcodec encoder; waveform extract uses probe +
ffmpeg_bridge decode (decode_audio needs M8 task system)
- fix re_sum_samples min/max init bug (values clamped to 0 for
same-sign ranges)
- every C API function has positive + error-path tests; suites:
oakcommon 193, oakaudio 36, oaknode 96, oakrender 42, oakcodec 18
- oakcodec: de-Qt all 20 sources (QThread decode loop -> std::thread,
QObject/signals -> callbacks), pure C ABI in include/codec with
refcounted neutral handles (OakFrame/OakDecoder/OakEncoder),
framemanager moved in from render, frame_to_buffer/buffer_to_frame
moved in from oakcommon oiioutils, codec->task via submit callback
(M8 will register), all cross-module calls go through the other
side's C API, -fvisibility=hidden + OAKCODEC_API
- oakcommon: handles become refcounted value structs
{ctx, addref, release, abi_version} (FFmpeg-style), pass-by-value
signatures, free() as release wrapper; init_from_native/get_native
for copyable value objects; OakCommonXxx renamed to OakXxx
- oakcommon: add logging (log_debug/info/warning/critical with level
filtering and sink injection) + printf-style oakcommon_log C wrapper
- oakrender: add CancelAtom C API family; complete
oakrender_color_processor_convert_frame; fix get_processor() missing
definition and OCIO env var lookup
- tests: oakcommon 174, oaknode 96, oakrender 42, oakcodec 18, all
green in their standalone builds
- copy engine/render to src/render/src (sunk param types excluded),
de-Qt in five parallel groups: core machinery (tickets/worker pool/
jobs), caches, color/texture, preview/IPC, GPU backends
- replace Qt GL/Vulkan wrappers with native context abstractions
(CGL/EGL/WGL, raw vulkan.h), QProcess with POSIX WorkerProcess,
QJsonObject with a minimal NDJSON-compatible workerjson (wire
protocol unchanged), QDataStream disk state with a byte-compatible
BinaryStream
- signals become single std::function callbacks or facade-triggered
calls per the documented signal/slot strategy
- pure C ABI in include/render + src/render/c_api (renderer/cache/
color/manager families, OAKRENDER_E_* codes), 37 gtest cases
- bridge src/node/transition/render/* stubs to the real oakrender
headers, closing the node<->render cycle: liboaknode links
liboakrender, zero dangling symbols
- docs: M7 implementation status + oakrender semantic-change notes
- strip QAbstractItemModel/QAction/signals-slots from UndoStack (UI
concerns belong to the app layer), index_changed becomes a
std::function callback
- decouple UndoCommand from Project via an optional modified-flag
callback pair
- add pure C ABI in include/undo + src/undo/c_api (oakundo_ prefix,
vtable-based command wrapper, OAKUNDO_E_* error codes)
- fix three engine-side defects: jump(0) infinite loop,
MultiUndoCommand child leak, push_pre_executed not undoable
- add gtest suites (22 cases) and a standalone build driver
- de-Qt all classes under src/common (std::string/vector/mutex,
std::filesystem, expat-based XmlStreamReader/Writer)
- add pure C ABI in include/common + src/common/c_api: opaque handles,
init returns NULL on failure, free(NULL) is a no-op, out-params with
negative OAKCOMMON_E_* error codes (include/common/error.h)
- remove single-consumer classes from oakcommon (html, jobtime,
otioutils, playbackaudioclock, tohex, util, avframeptr,
crashpadinterface/crashpadutils, autoscroll, digit, range); their
destinations are recorded in docs/zh/plans/riir/notes.md
- add gtest suites under src/common/tests (127 cases), standalone
build driver in src/common/standalone
- TimelineAndTrackView: disconnect the scrollbar sync connections in the
destructor. Child views reset their scene during destruction, which can
re-emit QScrollBar::valueChanged into a half-destroyed object and trip
Qt's assertObjectType abort.
- TimeScaledObject: keep minimum <= maximum when setting scale limits so
set_scale()'s std::clamp is never called with inverted limits (UB).
Setting the maximum below the minimum now pulls the minimum down, and
vice versa, matching QAbstractSlider conventions.
- riir.md: split project file read/write into standalone oakstorage
module (pluggable backend, DB-replaceable); add Mermaid data flow
diagram of all modules; adjust batch table and milestones
- riir/04-interfaces.md: new provides/consumes contract matrix for
all modules
- riir/M10-oakstorage.md: new manual with frozen C API (typed opaque
handles, manual vtable for storage backends, URI addressing)
- riir/01: codify pure-C OO interface rules (typed handles instead of
void*, init/free pairs, manual vtables, no C++ objects or member
calls across shared library boundaries); upper layers issue commands
only, no module-to-module event subscriptions (async task callbacks
excepted)
- sync 00/02/03 and M2-M9 manuals: remove subscribe APIs, replace
void* with typed handles, update tests accordingly
New app/playback/playbackcontroller.{h,cpp}: a lazily created
process-wide singleton whose set_playhead() forwards to
oakengine_viewer_set_playhead and re-broadcasts playhead_changed as a
plain Qt signal. Every app-side oakengine_viewer_set_playhead call site
(17 across viewer, timelinewidget, timelineview, import tool,
timebasedwidget, keyframecontrol, export dialog, mainwindow) now goes
through it.
Migrate the first four playhead subscribers off the raw C event
subscription / EngineEventBridge to the controller signal:
- TimeBasedView (issue 1)
- NodeParamViewWidgetBridge (issue 2)
- NodeParamViewKeyframeControl (issue 3)
- NodeParamViewConnectedLabel (issue 4)
Each stores a QMetaObject::Connection filtered on its viewer node and
disconnects on teardown; the viewer_sub_ members are gone. Plan docs
mark issues 0c and 1-4 as done.
Closes#30, closes#31, closes#32, closes#51, closes#52.
Compiler hygiene (all platforms):
- Silence warnings across the tree: missing override, -Wreorder ctor
init, -Wshadow, -Wsign-compare, missing switch cases, unused
functions/captures, Qt 6.11 deprecations (QMouseEvent/QDropEvent
accessors, qAsConst, Q_FOREACH over non-shared containers,
AA_UseHighDpiPixmaps) and the .bak/ backup tree removal.
- Fix regressions from the cleanup: missing clip decls in
capi/timeline.cpp, plugin.cpp rename fallout, panel setFocus
ambiguity, QGraphicsItem::pos vs event->position(), duplicate
k_push_button case, boolean test variable.
Windows:
- Qt portability: CommandLineParser is_set/add_option, QTimeZone
systemTimeZone (QTimeZone::LocalTime is 6.11-only), k_progress_* enum.
- Linking: stop adding oakengine to OLIVE_LIBRARIES (import lib plus
oakengine-obj caused multiple definitions); add OAKENGINE_STATIC so
internal consumers no longer reference __imp_* stubs.
- oakengine.ver: export olive::Renderer typeinfo so liboakgl.so can be
dlopened (Linux), DynamicRenderer no longer dlcloses backend libraries
(crash in RenderManager's dtor calling into unmapped memory).
- OTIO runtime: copy DLLs next to every binary on Windows instead of
relying on PATH (0xc0000135 in gtest discovery).
- Headless GL: the runner only has GDI OpenGL 1.1, killing every render
worker. Deploy Mesa llvmpipe as opengl32sw.dll (Qt's software-GL
channel) with QT_OPENGL=software, and let QT_OPENGL override the
AA_UseDesktopOpenGL default. ExportTask fails fast after 8 consecutive
undelivered frames instead of segfaulting or grinding forever;
FFmpegEncoder::write_frame tolerates null frames.
- Tests: GetTempPathA+PID temp dirs, GetLongPathNameA for 8.3 names,
forward-slash normalization when comparing project filenames.
Linux:
- Install libshaderc-dev so oakvulkan compiles GLSL (Vulkan tests).
- Accept UNORM floor-or-round (63/64) in the blit ping-pong test.
- Skip MainWindow construction test on the offscreen QPA (cannot paint
QOpenGLWidget).
Also: oak_cli_transcode gets a 300s ctest timeout, worker logs GL
context version and LoadGraph/render_frame stages, and
docs/plans/eliminate-event-bridge-issues.md (English translation).
vulkanrenderer.cpp is NOT part of oakengine-obj (unlike
openglrenderer.cpp), so the entry-point-only treatment from the
previous change left VulkanRenderer symbols undefined. Compile the
renderer into the plugin and link oakengine-obj + olive-version-obj.
Install libvulkan-dev + mesa-vulkan-drivers (lavapipe = software Vulkan,
no GPU needed) and stop passing CMAKE_DISABLE_FIND_PACKAGE_Vulkan so the
Vulkan backend and its tests are built and exercised.
oakengine-obj already contains openglrenderer.cpp and its moc output;
compiling them again into oakgl.dll plus embedding oakengine-obj caused
duplicate definitions and a stray k_app_version reference. On Windows
the plugins now compile only the C entry point and link oakengine-obj +
olive-version-obj.
- make_oakengine_gtest embeds oakengine-obj; test code must see
OAKENGINE_API as dllexport too (OAKENGINE_BUILD), otherwise MinGW
resolves nothing against __imp_* stubs
- the render worker intentionally drops QT_QPA_PLATFORM=offscreen and
needs a real display for its GL context; run the Linux ctest and the
filtered gtest steps under xvfb-run
- liboakengine.dll does not export engine-internal C++ symbols
(olive::Renderer, FileFunctions, VideoParams, Texture), so oakgl.dll
failed to link on Windows. Embed oakengine-obj instead (same pattern
as the engine tests); MinGW's name-based RTTI keeps cross-DLL casts
working.
- ci.yml: move to warp runners
- pointer.cpp/transition.cpp: same Qt 6.4 incompatibility as import.cpp
- Windows: DLLs cannot have undefined symbols, so the
executable-provides-k_app_version trick does not link; embed
olive-version-obj into oakengine on WIN32 (each module keeps its own
copy)
- import.cpp: pass the const char* input ids directly; the QLatin1String
roundtrip uses toUtf8(), unavailable in distro Qt 6.4
- sharedmemoryregion.cpp: the Windows branch still used the pre-refactor
API (Open/Close/kCreate); rewritten to the current lowercase
open/close/k_create interface
- resizabletimelinescrollbar instantiates QMetaType over OakEngineMarker
via timeline.h includes; the declaration belongs there, not serializer.h
- execinfo.h doesn't exist on Windows; the OAK_DEBUG_INVALID_INPUT
backtrace diagnostic is now Unix-only
The scripted Q_DECLARE_OPAQUE_POINTER sweep missed the QtCore/qmetatype.h
include (cascade of stdlib errors) and declared a few types in two headers
(redefinition of IsPointerDeclaredOpaque). Include qmetatype.h everywhere
and declare each handle in exactly one header.
Mike-Solar
lulumumu9999