oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

colordifferencekey: revert values to 1.0

Browse Source 
I changed these which made them worse, using the original values with a custom "base" is a much better approach
This commit is contained in:
itsmattkc
2022-05-08 22:04:49 -07:00
parent c1ddf0b724
commit 53a3cfc9b2
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node/keying/colordifferencekey/colordifferencekey.cpp
+4 -2
View File
@@ -37,11 +37,13 @@ ColorDifferenceKeyNode::ColorDifferenceKeyNode()
AddInput(kColorInput, NodeValue::kCombo, 0);
AddInput(kHighlightsInput, NodeValue::kFloat, 100.0f);
AddInput(kHighlightsInput, NodeValue::kFloat, 1.0f);
SetInputProperty(kHighlightsInput, QStringLiteral("min"), 0.0);
SetInputProperty(kHighlightsInput, QStringLiteral("base"), 0.01);
AddInput(kShadowsInput, NodeValue::kFloat, 100.0f);
AddInput(kShadowsInput, NodeValue::kFloat, 1.0f);
SetInputProperty(kShadowsInput, QStringLiteral("min"), 0.0);
SetInputProperty(kShadowsInput, QStringLiteral("base"), 0.01);
AddInput(kMaskOnlyInput, NodeValue::kBoolean, false);
app/shaders/colordifferencekey.frag
+1 -1
View File
@@ -51,7 +51,7 @@ void main(void) {
}
// Crush blacks and push whites
mask = highlights_in * 0.01 * (shadows_in * 0.01 * mask - 1.0) + 1.0;
mask = highlights_in * (shadows_in * mask - 1.0) + 1.0;
mask = clamp(mask, 0.0, 1.0);
// Invert mask