From 53a3cfc9b256e5d0b4aca9b3e55c603571be18eb Mon Sep 17 00:00:00 2001
From: itsmattkc <34096995+itsmattkc@users.noreply.github.com>
Date: Sun, 8 May 2022 22:04:49 -0700
Subject: [PATCH] colordifferencekey: revert values to 1.0

I changed these which made them worse, using the original values with a custom "base" is a much better approach
---
 app/node/keying/colordifferencekey/colordifferencekey.cpp | 6 ++++--
 app/shaders/colordifferencekey.frag                       | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/node/keying/colordifferencekey/colordifferencekey.cpp b/app/node/keying/colordifferencekey/colordifferencekey.cpp
index 6039c1c03..aaf9b77f0 100644
--- a/app/node/keying/colordifferencekey/colordifferencekey.cpp
+++ b/app/node/keying/colordifferencekey/colordifferencekey.cpp
@@ -37,11 +37,13 @@ ColorDifferenceKeyNode::ColorDifferenceKeyNode()
 
   AddInput(kColorInput, NodeValue::kCombo, 0);
 
-  AddInput(kHighlightsInput, NodeValue::kFloat, 100.0f);
+  AddInput(kHighlightsInput, NodeValue::kFloat, 1.0f);
   SetInputProperty(kHighlightsInput, QStringLiteral("min"), 0.0);
+  SetInputProperty(kHighlightsInput, QStringLiteral("base"), 0.01);
 
-  AddInput(kShadowsInput, NodeValue::kFloat, 100.0f);
+  AddInput(kShadowsInput, NodeValue::kFloat, 1.0f);
   SetInputProperty(kShadowsInput, QStringLiteral("min"), 0.0);
+  SetInputProperty(kShadowsInput, QStringLiteral("base"), 0.01);
 
   AddInput(kMaskOnlyInput, NodeValue::kBoolean, false);
 
diff --git a/app/shaders/colordifferencekey.frag b/app/shaders/colordifferencekey.frag
index 5ed5fb9ec..e47ee88db 100644
--- a/app/shaders/colordifferencekey.frag
+++ b/app/shaders/colordifferencekey.frag
@@ -51,7 +51,7 @@ void main(void) {
     }
 
     // Crush blacks and push whites
-    mask = highlights_in * 0.01 * (shadows_in * 0.01 * mask - 1.0) + 1.0;
+    mask = highlights_in * (shadows_in * mask - 1.0) + 1.0;
     mask = clamp(mask, 0.0, 1.0);
 
     // Invert mask