Danilo Leal
eff592c447
agent_ui: Refine "reject"/"keep" behavior when regenerating previous prompts ( #43347 )
...
Closes https://github.com/zed-industries/zed/issues/42753
Consider the following flow: you submit prompt A. Prompt A generates
some edits. You don't click on either "reject" or "keep"; they stay in a
pending state. You then submit prompt B, but before the agent outputs
any response, you click to edit prompt B, thus submitting a
regeneration.
Before this PR, the above flow would make the edits originated from
prompt A to be auto-rejected. This feels very incorrect and can surprise
users when they see that the edits that were pending got rejected. It
feels more correct to only auto-reject changes if you're regenerating
the prompt that directly generated those edits in the first place. Then,
it also feels more correct to assume that if there was a follow-up
prompt after some edits were made, those edits were passively
"accepted".
So, this is what this PR is doing. Consider the following flow to get a
picture of the behavior change:
- You submit prompt A.
- Prompt A generates some edits.
- You don't click on either "reject" or "keep"; they're pending.
- You then submit prompt B, but before the agents outputs anything, you
click to edit prompt B, submitting a regeneration.
- Now, edits from prompt A will be auto-kept.
Release Notes:
- agent: Improved the "reject"/"keep" behavior when regenerating older
prompts by auto-keeping pending edits that don't originate from the
prompt to-be-regenerated.
2025-11-24 11:13:38 -03:00
..
2025-11-23 00:33:18 -03:00
2025-11-02 18:11:21 +00:00
2025-11-07 22:27:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 09:43:20 +00:00
2025-11-20 17:12:00 +00:00
2025-11-10 11:11:24 -03:00
2025-11-24 11:13:38 -03:00
2025-10-20 08:35:28 -03:00
2025-11-22 00:10:26 +00:00
2025-11-22 00:46:53 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-07 22:27:14 +00:00
2025-11-20 22:16:07 +00:00
2025-11-07 22:27:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-11 12:55:19 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-29 16:41:43 +01:00
2025-11-20 12:18:50 +01:00
2025-11-03 19:25:15 +00:00
2025-11-12 20:27:04 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-11-06 09:16:45 +00:00
2025-11-10 23:00:55 -07:00
2025-10-17 18:58:14 +00:00
2025-11-17 20:36:05 +02:00
2025-11-18 23:46:29 +00:00
2025-11-21 16:39:08 +00:00
2025-11-24 13:34:04 +01:00
2025-11-22 22:26:26 -03:00
2025-10-17 18:58:14 +00:00
2025-11-07 22:27:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-18 16:39:08 +00:00
2025-11-21 16:39:08 +00:00
2025-11-21 17:31:57 +01:00
2025-10-17 18:58:14 +00:00
2025-11-19 12:34:41 +01:00
2025-11-21 09:20:15 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-17 11:01:34 -07:00
2025-11-22 23:28:34 -03:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-20 12:18:50 +01:00
2025-10-23 14:13:35 -04:00
2025-11-21 16:39:08 +00:00
2025-11-20 23:59:02 +00:00
2025-11-07 22:27:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-09-11 13:56:06 -07:00
2025-10-31 21:18:22 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-11 15:42:00 +02:00
2025-10-17 18:58:14 +00:00
2025-11-22 00:33:32 +01:00
2025-10-20 10:30:06 +00:00
2025-11-20 22:17:50 -07:00
2025-10-20 23:54:56 +03:00
2025-11-22 00:33:32 +01:00
2025-11-09 21:37:22 -05:00
2025-11-20 11:30:34 +00:00
2025-11-19 22:00:58 +00:00
2025-11-19 05:41:24 +00:00
2025-11-24 13:35:24 +00:00
2025-11-17 12:31:00 +00:00
2025-10-26 13:24:26 +00:00
2025-10-17 18:58:14 +00:00
2025-11-24 12:51:45 +02:00
2025-10-17 18:58:14 +00:00
2025-11-18 01:00:26 +00:00
2025-11-07 22:27:14 +00:00
2025-11-11 16:34:25 -05:00
2025-10-17 18:58:14 +00:00
2025-11-19 22:00:58 +00:00
2025-11-11 15:43:25 +02:00
2025-11-18 19:20:34 +01:00
2025-11-21 14:19:55 +05:30
2025-11-21 14:19:55 +05:30
2025-11-20 22:16:07 +00:00
2025-11-24 13:34:04 +01:00
2025-10-17 18:58:14 +00:00
2025-10-22 19:52:38 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 11:36:04 +02:00
2025-10-22 19:52:38 +00:00
2025-10-17 18:58:14 +00:00
2025-11-07 09:42:55 +00:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-19 23:40:54 +00:00
2025-11-19 22:00:58 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-20 17:12:00 +00:00
2025-11-24 10:33:03 +01:00
2025-10-17 18:58:14 +00:00
2025-11-20 19:47:39 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-12 22:03:59 -06:00
2025-10-20 17:20:09 +00:00
2025-11-11 16:10:47 +01:00
2025-11-18 23:25:12 +00:00
2025-11-13 14:15:46 +00:00
2025-10-17 18:58:14 +00:00
2025-11-19 22:00:58 +00:00
2025-11-20 18:57:22 -03:00
2025-10-17 18:58:14 +00:00
2025-11-12 15:31:20 +01:00
2025-11-18 21:57:30 -05:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-13 14:56:40 +01:00
2025-11-19 22:00:58 +00:00
2025-11-24 13:34:04 +01:00
2025-10-29 16:27:30 +00:00
2025-11-24 12:13:20 +00:00
2025-11-24 13:34:04 +01:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-11-19 22:00:58 +00:00
2025-11-18 01:00:26 +00:00
2025-11-03 19:25:15 +00:00
2025-11-24 14:49:00 +01:00
2025-10-24 07:52:51 -04:00
2025-11-21 19:56:00 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-20 19:47:39 +00:00
2025-10-17 18:58:14 +00:00
2025-11-24 11:24:05 +00:00
2025-10-27 10:13:26 -04:00
2025-11-21 08:28:17 -07:00
2025-11-07 22:27:14 +00:00
2025-11-23 16:52:50 -05:00
2025-10-17 18:58:14 +00:00
2025-11-11 16:34:25 -05:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-20 01:52:13 -03:00
2025-11-03 19:25:15 +00:00
2025-11-24 14:49:00 +01:00
2025-11-21 16:39:08 +00:00
2025-10-17 18:58:14 +00:00
2025-11-20 12:18:50 +01:00
2025-11-24 13:34:04 +01:00
2025-11-07 22:27:14 +00:00
2025-11-20 10:12:59 -05:00
2025-11-19 22:00:58 +00:00
2025-11-07 11:36:05 +00:00
2025-11-24 13:34:04 +01:00
2025-11-21 14:01:06 -05:00
2025-11-23 12:24:01 +00:00
2025-11-20 19:54:47 +00:00
2025-11-24 11:36:04 +02:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-14 22:46:35 +00:00
2025-10-22 19:52:38 +00:00
2025-11-22 22:26:26 -03:00
2025-11-22 23:28:34 -03:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-24 11:11:45 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-07 22:27:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-22 22:26:26 -03:00
2025-11-18 10:23:16 -07:00
2025-11-07 22:27:14 +00:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-18 19:20:34 +01:00
2025-10-17 18:58:14 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 13:34:04 +01:00
2025-11-21 16:39:08 +00:00
2025-11-24 13:34:04 +01:00
2025-11-24 11:30:19 +02:00
2025-11-07 22:27:14 +00:00