oak-team/oak-gpui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
cb7bd5fe19097003190542deeff7208f166ddfc9
oak-gpui/crates
T
History
Dino b709996ec6 editor: Fix pane's tab buttons flicker on right-click (#42549) 
Whenever right-click was used on the editor, the pane's tab buttons
would flicker, which was confirmed to happen because of the following
check:

```
self.focus_handle.contains_focused(window, cx)
    || self
        .active_item()
        .is_some_and(|item| {
            item.item_focus_handle(cx).contains_focused(window, cx)
        })
```

This check was returning `false` right after right-clicking but
returning `true` right after. When digging into it a little bit more,
this appears to be happening because the editor's `MouseContextMenu`
relies on `ContextMenu` which is rendered in a deferred fashion but
`MouseContextMenu` updates the window's focus to it instantaneously.

Since the `ContextMenu` is rendered in a deferred fashion, its focus
handle is not yet a descendant of the editor (pane's active item) focus
handle, so the `contains_focused(window, cx)` call would return `false`,
with it returning `true` after the menu was rendered.

This commit updates the `MouseContextMenu::new` function to leverage
`cx.on_next_frame` and ensure that the focus is only moved to the
`ContextMenu` 2 frames later, ensuring that by the time the focus is
moved, the `ContextMenu`'s focus handle is a descendant of the editor's.

Closes #41771 

Release Notes:

- Fixed pane's tab buttons flickering when using right-click on the
editor
2025-11-13 15:57:26 +00:00
..
acp_thread
Stop thread on Restore Checkpoint (#42537)
2025-11-12 15:13:40 +00:00
acp_tools
acp_tools: Add vertical scrollbar to ACP logs (#41740)
2025-11-02 18:11:21 +00:00
action_log
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
activity_indicator
git: Add notification to git clone (#41712)
2025-11-11 01:02:13 -05:00
agent
agent: Workaround for Sonnet inserting </parameter> tag (#42634)
2025-11-13 15:09:16 +00:00
agent_servers
agent_servers: Fix panic when setting default mode (#42452)
2025-11-11 15:25:27 +00:00
agent_settings
agent: Add ability to set a default_model per profile (#39220)
2025-11-10 11:11:24 -03:00
agent_ui
Disabled agent commands (#42579)
2025-11-13 10:10:02 -05:00
ai_onboarding
ai onboarding: Add dismiss button to the sign in banner (#40660)
2025-10-20 08:35:28 -03:00
anthropic
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
askpass
askpass: Quote paths in generated askpass script (#42622)
2025-11-13 14:37:47 +01:00
assets
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_command
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_commands
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
assistant_text_thread
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
audio
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
auto_update
settings: Skip terminal env vars with substitutions in vscode import (#42464)
2025-11-11 16:15:12 +00:00
auto_update_helper
auto_update: Ignore dir removal errors on windows (#42435)
2025-11-11 12:55:19 +00:00
auto_update_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
aws_http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
bedrock
bedrock: Add support for Claude Haiku 4.5 model (#41045)
2025-10-29 16:41:43 +01:00
breadcrumbs
project_search: Add button to collapse/expand all excerpts (#41654)
2025-11-03 14:50:34 -03:00
buffer_diff
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
call
Bump Rust to 1.91.1 (#42561)
2025-11-12 20:27:04 +00:00
channel
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
cli
rope: Prevent stack overflows by bumping rayon stack sizes (#41397)
2025-10-28 20:21:49 +00:00
client
agent_ui: Allow to uninstall agent servers from the settings view (#42445)
2025-11-11 12:47:08 -03:00
clock
text: Improve panic messages with more information (#42072)
2025-11-06 09:16:45 +00:00
cloud_api_client
Use cloud for auto-update (#42246)
2025-11-10 23:00:55 -07:00
cloud_api_types
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_llm_client
Report discarded zeta predictions and indicate whether they were shown (#42403)
2025-11-12 16:41:04 -08:00
cloud_zeta2_prompt
zeta eval: Improve determinism and debugging ergonomics (#42478)
2025-11-12 18:16:13 +00:00
codestral
zeta2: Build edit prediction prompt and process model output in client (#41870)
2025-11-06 18:36:58 -05:00
collab
collab: Remove unused methods from User model (#42536)
2025-11-12 15:38:16 +00:00
collab_ui
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
collections
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
command_palette
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
command_palette_hooks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
context_server
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
copilot
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
crashes
Fix windows crash handler (#42039)
2025-11-05 22:34:05 +00:00
credentials_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
dap_adapters
Allow for using config specific gdb binaries in gdb adapter (#37193)
2025-11-06 12:53:59 -05:00
db
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debug_adapter_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_tools
Keep selection in SwitchToHelixNormalMode (#41583)
2025-10-31 01:53:46 +00:00
debugger_ui
Add support for multi-word snippet prefixes (#42398)
2025-11-11 16:34:25 -05:00
deepseek
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
denoise
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
diagnostics
Implement pretty TypeScript errors (#42494)
2025-11-12 10:32:46 -08:00
docs_preprocessor
docs: Ensure macOS and Linux keybindings are escaped in HTML (#39802)
2025-10-23 14:13:35 -04:00
edit_prediction
Report discarded zeta predictions and indicate whether they were shown (#42403)
2025-11-12 16:41:04 -08:00
edit_prediction_button
Use enterprise_uri for settings when provided (#42485)
2025-11-11 21:31:42 +00:00
edit_prediction_context
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
editor
editor: Fix pane's tab buttons flicker on right-click (#42549)
2025-11-13 15:57:26 +00:00
eval
Add more secrets to eval workflows (#42459)
2025-11-11 16:07:57 +00:00
explorer_command_injector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension
Improve error messages on extension loading (#42266)
2025-11-11 15:45:03 +02:00
extension_api
Windows: Fix issues with paths in extensions (#37811)
2025-09-11 13:56:06 -07:00
extension_cli
Fix categorization of agent server extensions (#41689)
2025-10-31 21:18:22 +00:00
extension_host
Improve error messages on extension loading (#42266)
2025-11-11 15:45:03 +02:00
extensions_ui
extensions_ui: Add XML extension suggestion for XML files (#42514)
2025-11-12 10:12:02 +00:00
feature_flags
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feedback
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
file_finder
Add clear recent files history command (#42176)
2025-11-11 15:42:00 +02:00
file_icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs
fs: Fix wrong watcher trace log on Linux (#42544)
2025-11-12 16:26:53 +00:00
fs_benchmarks
fs: Reintroduce benchmarks crate (#40689)
2025-10-20 10:30:06 +00:00
fsevent
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fuzzy
file_finder: Include worktree root name in multi-worktrees workspace (#40415)
2025-10-20 23:54:56 +03:00
git
git: Fix panic in git2 due to empty repo paths (#42304)
2025-11-10 09:27:51 +00:00
git_hosting_providers
git: Fix support for self-hosted Bitbucket (#42002)
2025-11-09 21:37:22 -05:00
git_ui
git_panel: Fix partially staged changes not showing up (#42530)
2025-11-12 15:13:29 +01:00
go_to_line
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
google_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui
Bump Rust to 1.91.1 (#42561)
2025-11-12 20:27:04 +00:00
gpui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui_tokio
workspace: Handle non-cloneable items better (#41215)
2025-10-26 13:24:26 +00:00
html_to_markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client
Use cloud for auto-update (#42246)
2025-11-10 23:00:55 -07:00
http_client_tls
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
icons
agent_ui: Add icon button to trigger the @-mention completions menu (#42449)
2025-11-11 12:50:56 -03:00
image_viewer
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
inspector_ui
Add support for multi-word snippet prefixes (#42398)
2025-11-11 16:34:25 -05:00
install_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
journal
Avoid panics in LSP store path handling (#42117)
2025-11-11 20:51:57 +02:00
json_schema_store
Replace deprecated json.schemastore.org with www.schemastore.org (#42336)
2025-11-11 15:43:25 +02:00
keymap_editor
Add support for multi-word snippet prefixes (#42398)
2025-11-11 16:34:25 -05:00
language
Absolutize LSP and DAP paths more conservatively (#42482)
2025-11-12 01:36:22 +00:00
language_extension
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
language_model
Add retry support for OpenAI-compatible LLM providers (#37891)
2025-11-13 14:15:46 +00:00
language_models
Add retry support for OpenAI-compatible LLM providers (#37891)
2025-11-13 14:15:46 +00:00
language_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
language_tools
Fix circular reference issue around PopoverMenu (#42461)
2025-11-11 19:20:38 +02:00
languages
Add additional comment for context in Tyepscript highlights (#42564)
2025-11-12 19:59:10 +00:00
line_ending_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
livekit_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_client
gpui: Add to support check state to MenuItem (#39876)
2025-11-07 09:42:55 +00:00
lmstudio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lsp
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown
Remove Markdown CodeBlock metadata and Custom rendering (#42211)
2025-11-08 14:00:53 +01:00
markdown_preview
markdown: Add support for HTML href elements (#42265)
2025-11-13 15:12:17 +01:00
media
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
menu
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
migrator
project_panel: Add auto_open settings (#40435)
2025-11-12 03:23:40 +05:30
miniprofiler_ui
Miniprofiler (#42385)
2025-11-12 15:31:20 +01:00
mistral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
multi_buffer
diagnostics: Workaround weird panic in update_path_excerpts (#42602)
2025-11-13 09:13:54 +00:00
nc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
net
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
node_runtime
Disable env clearing for npm subcommands (#42587)
2025-11-12 22:03:59 -06:00
notifications
sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)
2025-10-20 17:20:09 +00:00
ollama
ollama: Fix tool calling (#42275)
2025-11-11 16:10:47 +01:00
onboarding
Rename ThemeMode to ThemeAppearanceMode (#42279)
2025-11-10 14:26:01 -07:00
open_ai
Add retry support for OpenAI-compatible LLM providers (#37891)
2025-11-13 14:15:46 +00:00
open_router
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
outline
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
outline_panel
editor: Unfold buffers with selections on edit + Remove selections on buffer fold (#37953)
2025-11-11 16:59:44 +05:30
panel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
paths
Miniprofiler (#42385)
2025-11-12 15:31:20 +01:00
picker
gpui: Add 'Nearest' scrolling strategy to 'UniformList' (#41844)
2025-11-12 16:37:14 +01:00
prettier
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
project
settings: Add tilde expansion support for LSP binary path (#41715)
2025-11-13 09:14:18 -05:00
project_benchmarks
search: New recent old search implementation (#40835)
2025-11-13 14:56:40 +01:00
project_panel
project_panel: Add auto_open settings (#40435)
2025-11-12 03:23:40 +05:30
project_symbols
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
prompt_store
prompt_store: Remove unused code (#41473)
2025-10-29 16:27:30 +00:00
proto
git: Add askpass delegate to git-commit handlers (#42239)
2025-11-10 07:57:50 +00:00
recent_projects
Use cloud for auto-update (#42246)
2025-11-10 23:00:55 -07:00
refineable
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
release_channel
Use cloud for auto-update (#42246)
2025-11-10 23:00:55 -07:00
remote
askpass: Quote paths in generated askpass script (#42622)
2025-11-13 14:37:47 +01:00
remote_server
search: New recent old search implementation (#40835)
2025-11-13 14:56:40 +01:00
repl
Miniprofiler (#42385)
2025-11-12 15:31:20 +01:00
reqwest_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rich_text
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
rope
Replace {floor/ceil}_char_boundary polyfills with std (#42599)
2025-11-13 08:11:18 +00:00
rpc
ACP Extensions (#40663)
2025-10-24 07:52:51 -04:00
rules_library
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
scheduler
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
schema_generator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
search
editor: Respect search case sensitivity when selecting occurrences (#42121)
2025-11-11 10:26:40 +00:00
semantic_version
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
session
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings
Bump Rust to 1.91.1 (#42561)
2025-11-12 20:27:04 +00:00
settings_json
settings_ui: Show migration banner (#41112)
2025-10-27 10:13:26 -04:00
settings_macros
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
settings_profile_selector
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
settings_ui
terminal: Add setting for scroll multiplier (#39463)
2025-11-12 16:38:06 +01:00
snippet
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippet_provider
Add support for multi-word snippet prefixes (#42398)
2025-11-11 16:34:25 -05:00
snippets_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
story
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
storybook
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
streaming_diff
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
sum_tree
diagnostics: Keep diagnostic excerpt ranges properly ordered (#42298)
2025-11-09 10:55:56 +00:00
supermaven
zeta2: Build edit prediction prompt and process model output in client (#41870)
2025-11-06 18:36:58 -05:00
supermaven_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
svg_preview
svg_preview: Update preview on every buffer edit (#41270)
2025-10-29 18:49:39 +01:00
system_specs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tab_switcher
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
task
Use ShellKind::try_quote whenever we need to quote shell args (#41104)
2025-10-24 18:19:53 +02:00
tasks_ui
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
telemetry
Fix telemetry (#42184)
2025-11-07 11:36:05 +00:00
telemetry_events
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
terminal
terminal: Add setting for scroll multiplier (#39463)
2025-11-12 16:38:06 +01:00
terminal_view
terminal: Add setting for scroll multiplier (#39463)
2025-11-12 16:38:06 +01:00
text
Bump Rust to 1.91.1 (#42561)
2025-11-12 20:27:04 +00:00
theme
Rename ThemeMode to ThemeAppearanceMode (#42279)
2025-11-10 14:26:01 -07:00
theme_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_importer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
time_format
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
title_bar
Add support for closing window tabs with middle mouse click (#41628)
2025-11-10 15:09:37 +01:00
toolchain_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
ui
gpui: Add to support check state to MenuItem (#39876)
2025-11-07 09:42:55 +00:00
ui_input
Fix integer underflow in autosave mode after delay in the settings (#41898)
2025-11-04 14:12:05 -05:00
ui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util
Replace {floor/ceil}_char_boundary polyfills with std (#42599)
2025-11-13 08:11:18 +00:00
util_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vercel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vim
vim: Make each vim repeat its own transaction (#41735)
2025-11-13 06:46:14 +00:00
vim_mode_setting
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
watch
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
workspace
Improve pane: reopen closed item to not reopen closed tabs (#42568)
2025-11-12 21:08:41 +00:00
worktree
settings: Add tilde expansion support for LSP binary path (#41715)
2025-11-13 09:14:18 -05:00
worktree_benchmarks
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
x_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed
zed: Enable line wrapping for cli help (#42496)
2025-11-13 10:46:51 -05:00
zed_actions
Miniprofiler (#42385)
2025-11-12 15:31:20 +01:00
zed_env_vars
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta
Report discarded zeta predictions and indicate whether they were shown (#42403)
2025-11-12 16:41:04 -08:00
zeta2
zeta eval: --repeat flag (#42569)
2025-11-12 16:58:22 -05:00
zeta2_tools
zeta2: Targeted retrieval search (#42240)
2025-11-08 01:06:12 +00:00
zeta_cli
zeta eval: Allow no headings under "Expected Context" (#42638)
2025-11-13 15:43:22 +00:00
zlog
Try to download wasi-sdk ahead of time (#42377)
2025-11-10 19:50:43 +00:00
zlog_settings
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00