oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
641ae90cd62ef5ea4a59f7adbc053f130c479a1f
oak-gpui/crates
T
History
DongandBen Kunkle 641ae90cd6 settings_ui: Fix IEEE 754 floating point error when serializing value to JSON (#40677) 
Closes #40556

Release Notes:

- settings-ui: Fixed an issue where modifying floating point number fields could result in the values written to the settings file containing IEEE 754 floating point error

> [!Note]
> Seems like there's another pull request fixing the centered layout in
#40661 by normalizing the whole `settings.json` file when updating it.
Not sure which is the better way to handle this issue.

## Description

This pull request solves the IEEE 754 floating point error when
serializing values from settings-ui into `settings.json` by creating a
two `serde_helper` to convert the problematic f32 into a formatted two
decimal placed f32.

Fields currently exists the IEEE 754 error:
- Appearance → Unnecessary Code Fade
- Editor → Drop Size Target
- Window & Layout → Centered Layout Left/Right Padding
- Window & Layout → Inactive Opacity

## How to verify

### Unnecessary Code Fade

As Is | To Be
--- | ---
<video
src="https://github.com/user-attachments/assets/1bf4bad2-63c5-4b03-ac29-8b6b59569e16"
/> | <video
src="https://github.com/user-attachments/assets/dadcd4a1-651b-43dd-913f-edae073ceb68"
/>

### Drop Size Target

As Is | To Be
--- | ---
<video
src="https://github.com/user-attachments/assets/9d5b4173-fcac-44d0-b7fc-772a2e426ef1"
/> | <video
src="https://github.com/user-attachments/assets/4b5adeaf-e678-494d-bd1b-6c1d55824c43"
/>

### Centered Layout Left/Right Padding

As Is | To Be
--- | ---
<video
src="https://github.com/user-attachments/assets/33b4e1ff-7ab2-44f7-9e9b-8abad1565d9a"
/> | <video
src="https://github.com/user-attachments/assets/63d8de9e-28d1-4bd7-a6c9-02452e105486"
/>

### Inactive Opacity

As Is | To Be
--- | ---
<video
src="https://github.com/user-attachments/assets/a7fe2e72-deb6-41dc-82f3-e2649503b8a4"
/> | <video
src="https://github.com/user-attachments/assets/993c314f-b6f6-4dcd-8f74-fa357ab063e9"
/>

---------

Co-authored-by: Ben Kunkle <ben@zed.dev>
2025-10-21 16:45:40 +00:00
..
acp_thread
acp_thread: Fix panic when following acp agents across buffers (#40798)
2025-10-21 14:37:16 +00:00
acp_tools
Update to acp 0.5 (#40701)
2025-10-20 13:52:05 +00:00
action_log
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
activity_indicator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
agent
zeta2 inspector: Feedback box (#40732)
2025-10-21 10:30:21 +00:00
agent_servers
Update to acp 0.5 (#40701)
2025-10-20 13:52:05 +00:00
agent_settings
settings: Remove unused stream_edits setting in agent (#40640)
2025-10-19 15:52:28 +00:00
agent_ui
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
ai_onboarding
ai onboarding: Add dismiss button to the sign in banner (#40660)
2025-10-20 08:35:28 -03:00
anthropic
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
askpass
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assets
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_context
clock: Cleanup ReplicaId, Lamport and Global (#40600)
2025-10-20 13:26:20 +02:00
assistant_slash_command
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_commands
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
audio
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
auto_update
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
auto_update_helper
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
auto_update_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
aws_http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
bedrock
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
breadcrumbs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
buffer_diff
clock: Cleanup ReplicaId, Lamport and Global (#40600)
2025-10-20 13:26:20 +02:00
call
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
channel
clock: Cleanup ReplicaId, Lamport and Global (#40600)
2025-10-20 13:26:20 +02:00
cli
cli: Add --reuse flag for replacing workspace in existing window (#38131)
2025-10-20 22:41:13 -06:00
client
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
clock
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
cloud_api_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_api_types
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_llm_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
cloud_zeta2_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
codestral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
collab
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
collab_ui
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
collections
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
command_palette
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
command_palette_hooks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
context_server
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
copilot
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
crashes
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
credentials_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dap_adapters
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
db
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debug_adapter_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_tools
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debugger_ui
pane: Ignore max tabs on terminal pane (#40740)
2025-10-20 21:19:40 -04:00
deepseek
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
denoise
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
diagnostics
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
docs_preprocessor
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction_button
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
edit_prediction_context
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
editor
editor: Improve text color in document color highlight (#39372)
2025-10-21 21:35:40 +05:30
eval
settings: Remove unused stream_edits setting in agent (#40640)
2025-10-19 15:52:28 +00:00
explorer_command_injector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension_api
Windows: Fix issues with paths in extensions (#37811)
2025-09-11 13:56:06 -07:00
extension_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension_host
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extensions_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feature_flags
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
feedback
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
file_finder
file_finder: Include worktree root name in multi-worktrees workspace (#40415)
2025-10-20 23:54:56 +03:00
file_icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs
fs: Implement FileHandle::current_path for windows (#40804)
2025-10-21 15:48:40 +00:00
fs_benchmarks
fs: Reintroduce benchmarks crate (#40689)
2025-10-20 10:30:06 +00:00
fsevent
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fuzzy
file_finder: Include worktree root name in multi-worktrees workspace (#40415)
2025-10-20 23:54:56 +03:00
git
git: Add diff view for stash entries (#38280)
2025-10-20 11:47:15 -04:00
git_hosting_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
git_ui
Fix Git UI truncation for long branch names (#40598)
2025-10-21 16:42:43 +00:00
go_to_line
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
google_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
gpui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
gpui_tokio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
html_to_markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client_tls
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
image_viewer
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
inspector_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
install_cli
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
journal
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
json_schema_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
keymap_editor
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language
language: Fix hang when editing certain tailwind class names (#40791)
2025-10-21 19:00:02 +05:30
language_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_model
ci: Update typos versions and fix new occurrences (#40784)
2025-10-21 10:43:22 +00:00
language_models
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_tools
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
languages
Add comment language injection for supported languages (#39884)
2025-10-20 14:45:51 +02:00
line_ending_selector
Add line endings indicator in status bar (#39609)
2025-10-20 15:24:41 -06:00
livekit_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lmstudio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lsp
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
markdown_preview
markdown_preview: Apply few appearance tweaks for tables (#39190)
2025-10-21 00:38:47 +00:00
media
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
menu
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
migrator
settings_ui: Add more settings (#40708)
2025-10-20 12:37:55 -04:00
mistral
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
multi_buffer
acp_thread: Fix panic when following acp agents across buffers (#40798)
2025-10-21 14:37:16 +00:00
nc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
net
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
node_runtime
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
notifications
sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)
2025-10-20 17:20:09 +00:00
ollama
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
onboarding
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
open_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
open_router
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
outline
Reduce display_map snapshot creation (#39354)
2025-10-17 21:56:57 +02:00
outline_panel
Add dock state to workspace context (#40454)
2025-10-20 18:23:46 +00:00
panel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
paths
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
picker
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
prettier
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
project
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
project_benchmarks
search: New old search implementation (#39956)
2025-10-20 16:40:02 +02:00
project_panel
Add dock state to workspace context (#40454)
2025-10-20 18:23:46 +00:00
project_symbols
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
prompt_store
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
proto
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
recent_projects
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
refineable
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
release_channel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
remote
remote: Use SFTP over SCP for uploading files and directories (#40510)
2025-10-20 00:01:43 +05:30
remote_server
search: New old search implementation (#39956)
2025-10-20 16:40:02 +02:00
repl
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
reqwest_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rich_text
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rope
multi_buffer: Assert char boundary for panic due to point_to_buffer_offset (#40777)
2025-10-21 19:01:35 +05:30
rpc
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
rules_library
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
scheduler
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
schema_generator
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
search
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
semantic_version
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
session
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings
settings_ui: Fix IEEE 754 floating point error when serializing value to JSON (#40677)
2025-10-21 16:45:40 +00:00
settings_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_profile_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
settings_ui
settings_ui: Fix focus bugs (#40806)
2025-10-21 12:25:07 -04:00
snippet
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippet_provider
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippets_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
story
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
storybook
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
streaming_diff
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sum_tree
sum_tree: Implement recursive Sumtree::find, use it over Cursor::seek if possible (#40700)
2025-10-20 17:20:09 +00:00
supermaven
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
supermaven_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
svg_preview
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
system_specs
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tab_switcher
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
task
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
tasks_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
telemetry
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
telemetry_events
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
terminal
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
terminal_view
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
text
multi_buffer: Assert char boundary for panic due to point_to_buffer_offset (#40777)
2025-10-21 19:01:35 +05:30
theme
Theme-able Vim Mode wrapper (#39813)
2025-10-21 04:30:30 +00:00
theme_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_importer
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
time_format
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
title_bar
title_bar: Add configurable window controls position (#38834)
2025-10-21 00:00:56 +00:00
toolchain_selector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_input
Add DelayMs type for settings (#40659)
2025-10-20 04:34:55 +00:00
ui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vercel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vim
vim: Fix hang in visual block motion (#40723)
2025-10-21 12:23:00 +01:00
vim_mode_setting
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
watch
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
workspace
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
worktree
persistence: More error contexts (#40787)
2025-10-21 11:29:43 +00:00
worktree_benchmarks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
x_ai
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed
project: Spawn terminal process on background executor (#40774)
2025-10-21 13:10:21 +00:00
zed_actions
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zed_env_vars
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zeta
clock: Cleanup ReplicaId, Lamport and Global (#40600)
2025-10-20 13:26:20 +02:00
zeta2
zeta2 inspector: Feedback box (#40732)
2025-10-21 10:30:21 +00:00
zeta2_tools
zeta2 inspector: Feedback box (#40732)
2025-10-21 10:30:21 +00:00
zeta_cli
zeta2: Max retrieved definitions option (#40515)
2025-10-20 15:26:41 +00:00
zlog
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
zlog_settings
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00