oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
60d17cccd35b919d6226ae86559c4505d7c1e833
oak-gpui/crates
T
History
Ben Kunkle 60d17cccd3 settings_ui: Move settings UI trait to file content (#37337) 
Closes #ISSUE

Initially, the `SettingsUi` trait was tied to `Settings`, however, given
that the `Settings::FileContent` type (which may be the same as the type
that implements `Settings`) will be the type that more directly maps to
the JSON structure (and therefore have the documentation, correct field
names (or `serde` rename attributes), etc) it makes more sense to have
the deriving of `SettingsUi` occur on the `FileContent` type rather than
the `Settings` type.

In order for this to work a relatively important change had to be made
to the derive macro, that being that it now "unwraps" options into their
inner type, so a field with type `Option<Foo>` where `Foo: SettingsUi`
will treat the field as if it were just `Foo`, expecting there to be a
default set in `default.json`. This imposes some restrictions on what
`Settings::FileContent` can be as seen in 1e19398 where `FileContent`
itself can't be optional without manually implementing `SettingsUi`, as
well as introducing some risk that if the `FileContent` type has
`serde(default)`, the default value will override the default value from
`default.json` in the UI even though it may differ (but it should!).

A future PR should probably replace the other settings with `FileContent
= Option<T>` (all of which currently have `T == bool`) with wrapper
structs and have `KEY = None` so the further niceties
`derive(SettingsUi)` will provide such as path renaming, custom UI, auto
naming and doc comment extraction can be used.

Release Notes:

- N/A *or* Added/Fixed/Improved ...
2025-09-01 18:42:33 -04:00
..
acp_thread
ACP Terminal support (#37129)
2025-09-01 18:57:15 +00:00
acp_tools
acp: Rename dev command (#36908)
2025-08-25 16:04:44 -06:00
action_log
Enforce style lints which do not have violations (#36580)
2025-08-20 14:07:37 +02:00
activity_indicator
Enforce style lints which do not have violations (#36580)
2025-08-20 14:07:37 +02:00
agent
Revert "ai: Auto select user model when there's no default" (#36932)
2025-08-26 13:55:09 +00:00
agent2
ACP Terminal support (#37129)
2025-09-01 18:57:15 +00:00
agent_servers
ACP Terminal support (#37129)
2025-09-01 18:57:15 +00:00
agent_settings
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
agent_ui
ACP Terminal support (#37129)
2025-09-01 18:57:15 +00:00
ai_onboarding
Make fields of AiUpsellCard private (#36888)
2025-08-25 17:21:20 +00:00
anthropic
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
askpass
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
assets
Use IBM Plex Sans / Lilex (#36084)
2025-08-13 13:25:52 -06:00
assistant_context
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
assistant_slash_command
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
assistant_slash_commands
Make SanitizedPath wrap Path instead of Arc<Path> to avoid allocation (#37106)
2025-08-28 13:32:30 -06:00
assistant_tool
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
assistant_tools
agent: Make it so delete_path tool needs user confirmation (#37191)
2025-08-31 19:52:43 -04:00
audio
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
auto_update
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
auto_update_helper
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
auto_update_ui
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
aws_http_client
bedrock: Fix remaining streaming delays (#33931)
2025-07-22 11:55:24 -04:00
bedrock
bedrock: Inference Config updates (#35808)
2025-08-29 18:13:06 -04:00
breadcrumbs
Revert "Remote LSP logs (#36709)" (#37051)
2025-08-27 23:24:19 +00:00
buffer_diff
acp: Fix panic with edit file tool (#36732)
2025-08-22 03:48:47 -04:00
call
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
channel
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
cli
windows: Update documents about WSL (#37292)
2025-09-01 08:33:59 +00:00
client
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
clock
…
cloud_api_client
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
cloud_api_types
Establish WebSocket connection to Cloud (#35734)
2025-08-07 01:28:41 +00:00
cloud_llm_client
agent2: Add now, grep, and web search tools (#35974)
2025-08-11 15:34:34 +02:00
collab
Update lsp-types to properly handle brackets (#37166)
2025-08-29 17:08:42 +03:00
collab_ui
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
collections
…
command_palette
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
command_palette_hooks
…
component
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
context_server
acp: Support calling tools provided by MCP servers (#36752)
2025-08-22 13:16:42 +00:00
copilot
language_models: Fix grok-code-fast-1 support for Copilot (#37116)
2025-08-31 18:51:17 -04:00
crashes
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
credentials_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
dap
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
dap_adapters
debugger: Add ability to only show stack frame entries from visible work trees (#37061)
2025-08-28 07:53:32 +00:00
db
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
debug_adapter_extension
…
debugger_tools
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
debugger_ui
Inject venv environment via the toolchain (#36576)
2025-08-28 14:40:43 +00:00
deepseek
deepseek: Fix API URL (#33905)
2025-09-01 10:49:09 +02:00
diagnostics
Update lsp-types to properly handle brackets (#37166)
2025-08-29 17:08:42 +03:00
docs_preprocessor
windows: Fix keystroke & keymap (#36572)
2025-08-27 03:24:50 +08:00
edit_prediction
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
edit_prediction_button
onboarding: Remove accept AI ToS from within Zed (#36612)
2025-08-22 11:45:47 -04:00
editor
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
eval
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
explorer_command_injector
…
extension
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
extension_api
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
extension_cli
Remove /docs slash command (#36325)
2025-08-16 19:00:31 +00:00
extension_host
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
extensions_ui
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
feature_flags
acp: Enable feature flag for everyone (#36928)
2025-08-26 15:30:26 +02:00
feedback
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
file_finder
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
file_icons
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
fs
Make SanitizedPath wrap Path instead of Arc<Path> to avoid allocation (#37106)
2025-08-28 13:32:30 -06:00
fsevent
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
fuzzy
Prevent out of bounds access in recursive_score_match (#35630)
2025-08-06 10:53:20 +02:00
git
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations (#36613)
2025-08-20 20:14:30 +02:00
git_hosting_providers
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
git_ui
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
go_to_line
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
google_ai
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
gpui
gpui: Fix typo in Windows alpha correction shader (#37328)
2025-09-01 15:33:11 -04:00
gpui_macros
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
gpui_tokio
Use Tokio::spawn instead of getting an executor handle (#36701)
2025-08-21 17:19:57 +00:00
html_to_markdown
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
http_client
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
http_client_tls
…
icons
debugger: Add ability to only show stack frame entries from visible work trees (#37061)
2025-08-28 07:53:32 +00:00
image_viewer
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
inspector_ui
Fix crash when opening inspector on Windows debug build (#36829)
2025-08-24 11:01:42 +00:00
install_cli
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
jj
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
jj_ui
…
journal
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
keymap_editor
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
language
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
language_extension
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
language_model
acp: Add more logs to model selector to diagnose issue (#36997)
2025-08-27 12:53:07 +00:00
language_models
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
language_selector
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
language_tools
Do not send any LSP logs by default to collab clients (#37163)
2025-08-29 12:23:45 +00:00
languages
Update lsp-types to properly handle brackets (#37166)
2025-08-29 17:08:42 +03:00
livekit_api
…
livekit_client
Add Rodio audio pipeline as alternative to current LiveKit pipeline (#36607)
2025-08-21 15:56:16 +02:00
lmstudio
lmstudio: Propagate actual error message from server (#34538)
2025-07-25 09:36:43 -04:00
lsp
Update lsp-types to properly handle brackets (#37166)
2025-08-29 17:08:42 +03:00
markdown
thread view: Refine tool call UI (#36937)
2025-08-26 12:55:40 -03:00
markdown_preview
markdown: Add HTML img tag support (#36700)
2025-08-31 11:43:24 +03:00
media
…
menu
…
migrator
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
mistral
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
multi_buffer
multi_buffer: Pre-allocate IDs when editing (#36819)
2025-08-24 09:59:32 +03:00
nc
…
net
…
node_runtime
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
notifications
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
ollama
ollama: Add support for gpt-oss (#35648)
2025-08-06 10:44:15 -04:00
onboarding
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
open_ai
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
open_router
Trim API key when submitting requests to LLM providers (#37082)
2025-08-28 12:00:44 +00:00
outline
…
outline_panel
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
panel
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
paths
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
picker
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
prettier
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
project
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
project_panel
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
project_symbols
Make project symbols picker entry consistent with outline picker (#37176)
2025-08-29 14:07:27 -03:00
prompt_store
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
proto
Inject venv environment via the toolchain (#36576)
2025-08-28 14:40:43 +00:00
recent_projects
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
refineable
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
release_channel
…
remote
Add initial support for WSL (#37035)
2025-08-29 17:18:52 -07:00
remote_server
Update lsp-types to properly handle brackets (#37166)
2025-08-29 17:08:42 +03:00
repl
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
reqwest_client
lints: A bunch of extra style lint fixes (#36568)
2025-08-20 12:05:58 +02:00
rich_text
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
rope
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
rpc
Fix overlooked Clippy lints (#36659)
2025-08-21 06:48:04 +00:00
rules_library
Add macOS window tabs (#33334)
2025-08-28 03:51:22 +00:00
schema_generator
…
search
Add a setting to control the number of context lines in excerpts (#37138)
2025-08-29 03:50:24 +00:00
semantic_index
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
semantic_version
…
session
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
settings
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
settings_profile_selector
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
settings_ui
settings_ui: Add dynamic settings UI item (#37331)
2025-09-01 17:53:43 -04:00
settings_ui_macros
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
snippet
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippet_provider
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
snippets_ui
Auto-fix clippy::collapsible_if violations (#36428)
2025-08-19 13:27:24 +00:00
sqlez
Fix workspace migration failure (#36911)
2025-08-26 00:27:52 +00:00
sqlez_macros
…
story
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
storybook
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
streaming_diff
Fix clippy::needless_borrow lint violations (#36444)
2025-08-18 21:54:35 +00:00
sum_tree
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
supermaven
supermaven: Improve completion caching and position validation (#37047)
2025-08-29 16:17:22 -04:00
supermaven_api
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
svg_preview
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
system_specs
Add GPU info to Sentry crashes (#36624)
2025-08-21 19:59:42 -04:00
tab_switcher
Activate preview for initially selected item (#37112)
2025-08-28 21:07:02 +00:00
task
Inject venv environment via the toolchain (#36576)
2025-08-28 14:40:43 +00:00
tasks_ui
Fix clippy::len_zero lint style violations (#36589)
2025-08-20 14:35:59 +00:00
telemetry
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
telemetry_events
Remove old telemetry events and transformation layer (#36263)
2025-08-15 15:37:52 -04:00
terminal
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
terminal_view
editor: Add an option to disable rounded corners for text selection (#36987)
2025-09-01 11:21:55 +03:00
text
Fix a bunch of other low-hanging style lints (#36498)
2025-08-19 21:26:17 +02:00
theme
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
theme_extension
…
theme_importer
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
theme_selector
Redesign and clean up all icons across Zed (#35856)
2025-08-08 15:34:36 -03:00
time_format
…
title_bar
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
toolchain_selector
remote: Fix toolchain RPC messages not being handled because of the entity getting dropped (#36665)
2025-08-21 09:37:45 +00:00
ui
Refactor KeybindingKeystroke (#37065)
2025-08-28 08:40:43 +00:00
ui_input
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
ui_macros
…
ui_prompt
ui_prompt: Fix prompt dialog is hard to see on large screen (#35348)
2025-07-30 23:03:53 +05:30
util
Make SanitizedPath wrap Path instead of Arc<Path> to avoid allocation (#37106)
2025-08-28 13:32:30 -06:00
util_macros
…
vercel
openai: Don't send prompt_cache_key for OpenAI-compatible models (#36231)
2025-08-15 13:54:24 +03:00
vim
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
vim_mode_setting
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00
watch
acp: Model-specific prompt capabilities for 1PA (#36879)
2025-08-25 14:28:11 -04:00
web_search
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
web_search_providers
Another batch of lint fixes (#36521)
2025-08-19 20:33:44 +00:00
workspace
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
worktree
settings_ui: Move settings UI trait to file content (#37337)
2025-09-01 18:42:33 -04:00
x_ai
Add xAI's Grok Code Fast 1 model (#36959)
2025-08-26 21:08:45 +00:00
zed
windows: Update documents about WSL (#37292)
2025-09-01 08:33:59 +00:00
zed_actions
acp: Add onboarding modal & title bar banner (#36784)
2025-08-26 16:59:12 -03:00
zeta
zeta: Improve efficiency and clarity of license detection patterns (#37242)
2025-08-31 07:23:21 +00:00
zeta_cli
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
zlog
Fix clippy::redundant_clone lint violations (#36558)
2025-08-20 12:20:13 +02:00
zlog_settings
settings ui: Start work on creating the initial structure (#36904)
2025-08-29 16:56:10 -04:00