There's still a bit more work to do on this, but this PR is compiling (with warnings) after eliminating the key types. When the tasks below are complete, this will be the new narrative for GPUI: - `Entity<T>` - This replaces `View<T>`/`Model<T>`. It represents a unit of state, and if `T` implements `Render`, then `Entity<T>` implements `Element`. - `&mut App` This replaces `AppContext` and represents the app. - `&mut Context<T>` This replaces `ModelContext` and derefs to `App`. It is provided by the framework when updating an entity. - `&mut Window` Broken out of `&mut WindowContext` which no longer exists. Every method that once took `&mut WindowContext` now takes `&mut Window, &mut App` and every method that took `&mut ViewContext<T>` now takes `&mut Window, &mut Context<T>` Not pictured here are the two other failed attempts. It's been quite a month! Tasks: - [x] Remove `View`, `ViewContext`, `WindowContext` and thread through `Window` - [x] [@cole-miller @mikayla-maki] Redraw window when entities change - [x] [@cole-miller @mikayla-maki] Get examples and Zed running - [x] [@cole-miller @mikayla-maki] Fix Zed rendering - [x] [@mikayla-maki] Fix todo! macros and comments - [x] Fix a bug where the editor would not be redrawn because of view caching - [x] remove publicness window.notify() and replace with `AppContext::notify` - [x] remove `observe_new_window_models`, replace with `observe_new_models` with an optional window - [x] Fix a bug where the project panel would not be redrawn because of the wrong refresh() call being used - [x] Fix the tests - [x] Fix warnings by eliminating `Window` params or using `_` - [x] Fix conflicts - [x] Simplify generic code where possible - [x] Rename types - [ ] Update docs ### issues post merge - [x] Issues switching between normal and insert mode - [x] Assistant re-rendering failure - [x] Vim test failures - [x] Mac build issue Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Co-authored-by: Joseph <joseph@zed.dev> Co-authored-by: max <max@zed.dev> Co-authored-by: Michael Sloan <michael@zed.dev> Co-authored-by: Mikayla Maki <mikaylamaki@Mikaylas-MacBook-Pro.local> Co-authored-by: Mikayla <mikayla.c.maki@gmail.com> Co-authored-by: joão <joao@zed.dev>
179 lines
6.0 KiB
Rust
179 lines
6.0 KiB
Rust
use super::Axis;
|
|
use crate::{
|
|
Autoscroll, Bias, Editor, EditorMode, NextScreen, NextScrollCursorCenterTopBottom,
|
|
ScrollAnchor, ScrollCursorBottom, ScrollCursorCenter, ScrollCursorCenterTopBottom,
|
|
ScrollCursorTop, SCROLL_CENTER_TOP_BOTTOM_DEBOUNCE_TIMEOUT,
|
|
};
|
|
use gpui::{Context, Point, Window};
|
|
|
|
impl Editor {
|
|
pub fn next_screen(&mut self, _: &NextScreen, window: &mut Window, cx: &mut Context<Editor>) {
|
|
if self.take_rename(true, window, cx).is_some() {
|
|
return;
|
|
}
|
|
|
|
if self.mouse_context_menu.is_some() {
|
|
return;
|
|
}
|
|
|
|
if matches!(self.mode, EditorMode::SingleLine { .. }) {
|
|
cx.propagate();
|
|
return;
|
|
}
|
|
self.request_autoscroll(Autoscroll::Next, cx);
|
|
}
|
|
|
|
pub fn scroll(
|
|
&mut self,
|
|
scroll_position: Point<f32>,
|
|
axis: Option<Axis>,
|
|
window: &mut Window,
|
|
cx: &mut Context<Self>,
|
|
) {
|
|
self.scroll_manager.update_ongoing_scroll(axis);
|
|
self.set_scroll_position(scroll_position, window, cx);
|
|
}
|
|
|
|
pub fn scroll_cursor_center_top_bottom(
|
|
&mut self,
|
|
_: &ScrollCursorCenterTopBottom,
|
|
window: &mut Window,
|
|
cx: &mut Context<Self>,
|
|
) {
|
|
let snapshot = self.snapshot(window, cx).display_snapshot;
|
|
let visible_rows = if let Some(visible_rows) = self.visible_line_count() {
|
|
visible_rows as u32
|
|
} else {
|
|
return;
|
|
};
|
|
|
|
let scroll_margin_rows = self.vertical_scroll_margin() as u32;
|
|
let mut new_screen_top = self.selections.newest_display(cx).head();
|
|
*new_screen_top.column_mut() = 0;
|
|
match self.next_scroll_position {
|
|
NextScrollCursorCenterTopBottom::Center => {
|
|
*new_screen_top.row_mut() = new_screen_top.row().0.saturating_sub(visible_rows / 2);
|
|
}
|
|
NextScrollCursorCenterTopBottom::Top => {
|
|
*new_screen_top.row_mut() =
|
|
new_screen_top.row().0.saturating_sub(scroll_margin_rows);
|
|
}
|
|
NextScrollCursorCenterTopBottom::Bottom => {
|
|
*new_screen_top.row_mut() = new_screen_top
|
|
.row()
|
|
.0
|
|
.saturating_sub(visible_rows.saturating_sub(scroll_margin_rows));
|
|
}
|
|
}
|
|
self.set_scroll_anchor(
|
|
ScrollAnchor {
|
|
anchor: snapshot
|
|
.buffer_snapshot
|
|
.anchor_before(new_screen_top.to_offset(&snapshot, Bias::Left)),
|
|
offset: Default::default(),
|
|
},
|
|
window,
|
|
cx,
|
|
);
|
|
|
|
self.next_scroll_position = self.next_scroll_position.next();
|
|
self._scroll_cursor_center_top_bottom_task = cx.spawn(|editor, mut cx| async move {
|
|
cx.background_executor()
|
|
.timer(SCROLL_CENTER_TOP_BOTTOM_DEBOUNCE_TIMEOUT)
|
|
.await;
|
|
editor
|
|
.update(&mut cx, |editor, _| {
|
|
editor.next_scroll_position = NextScrollCursorCenterTopBottom::default();
|
|
})
|
|
.ok();
|
|
});
|
|
}
|
|
|
|
pub fn scroll_cursor_top(
|
|
&mut self,
|
|
_: &ScrollCursorTop,
|
|
window: &mut Window,
|
|
cx: &mut Context<Editor>,
|
|
) {
|
|
let snapshot = self.snapshot(window, cx).display_snapshot;
|
|
let scroll_margin_rows = self.vertical_scroll_margin() as u32;
|
|
|
|
let mut new_screen_top = self.selections.newest_display(cx).head();
|
|
*new_screen_top.row_mut() = new_screen_top.row().0.saturating_sub(scroll_margin_rows);
|
|
*new_screen_top.column_mut() = 0;
|
|
let new_screen_top = new_screen_top.to_offset(&snapshot, Bias::Left);
|
|
let new_anchor = snapshot.buffer_snapshot.anchor_before(new_screen_top);
|
|
|
|
self.set_scroll_anchor(
|
|
ScrollAnchor {
|
|
anchor: new_anchor,
|
|
offset: Default::default(),
|
|
},
|
|
window,
|
|
cx,
|
|
)
|
|
}
|
|
|
|
pub fn scroll_cursor_center(
|
|
&mut self,
|
|
_: &ScrollCursorCenter,
|
|
window: &mut Window,
|
|
cx: &mut Context<Editor>,
|
|
) {
|
|
let snapshot = self.snapshot(window, cx).display_snapshot;
|
|
let visible_rows = if let Some(visible_rows) = self.visible_line_count() {
|
|
visible_rows as u32
|
|
} else {
|
|
return;
|
|
};
|
|
|
|
let mut new_screen_top = self.selections.newest_display(cx).head();
|
|
*new_screen_top.row_mut() = new_screen_top.row().0.saturating_sub(visible_rows / 2);
|
|
*new_screen_top.column_mut() = 0;
|
|
let new_screen_top = new_screen_top.to_offset(&snapshot, Bias::Left);
|
|
let new_anchor = snapshot.buffer_snapshot.anchor_before(new_screen_top);
|
|
|
|
self.set_scroll_anchor(
|
|
ScrollAnchor {
|
|
anchor: new_anchor,
|
|
offset: Default::default(),
|
|
},
|
|
window,
|
|
cx,
|
|
)
|
|
}
|
|
|
|
pub fn scroll_cursor_bottom(
|
|
&mut self,
|
|
_: &ScrollCursorBottom,
|
|
window: &mut Window,
|
|
cx: &mut Context<Editor>,
|
|
) {
|
|
let snapshot = self.snapshot(window, cx).display_snapshot;
|
|
let scroll_margin_rows = self.vertical_scroll_margin() as u32;
|
|
let visible_rows = if let Some(visible_rows) = self.visible_line_count() {
|
|
visible_rows as u32
|
|
} else {
|
|
return;
|
|
};
|
|
|
|
let mut new_screen_top = self.selections.newest_display(cx).head();
|
|
*new_screen_top.row_mut() = new_screen_top
|
|
.row()
|
|
.0
|
|
.saturating_sub(visible_rows.saturating_sub(scroll_margin_rows));
|
|
*new_screen_top.column_mut() = 0;
|
|
let new_screen_top = new_screen_top.to_offset(&snapshot, Bias::Left);
|
|
let new_anchor = snapshot.buffer_snapshot.anchor_before(new_screen_top);
|
|
|
|
self.set_scroll_anchor(
|
|
ScrollAnchor {
|
|
anchor: new_anchor,
|
|
offset: Default::default(),
|
|
},
|
|
window,
|
|
cx,
|
|
)
|
|
}
|
|
}
|