oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
18,510 Commits 1 Branch 0 Tags
ffebe2e4a6daeefa2dea585cdb44fbf3d26a5ba1
Commit Graph
304 Commits
Author SHA1 Message Date
Max BrunsfeldandConrad 35c516fda9 Log the time incoming RPC messages were queued (#8909) 
Release Notes:

- N/A

Co-authored-by: Conrad <conrad@zed.dev>
 2024-03-05 14:40:09 -08:00
Conrad Irwin 27c5343707 hosted projects (#8627) 
- **Allow joining a hosted project**

You can't yet do anything in a hosted project, but you can join it and
look how empty it is.

Release Notes:

- N/A
 2024-03-04 19:17:40 -07:00
Marshall Bowers d19957b705 Enable clippy::redundant_locals (#8750) 
This PR enables the
[`clippy::redundant_locals`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_locals)
rule and fixes the outstanding violations.

Release Notes:

- N/A
 2024-03-02 21:57:40 -05:00
Marshall Bowers ca2cda8d2a Remove unneeded 'static lifetimes on &strs in constants (#8698) 
This PR removes unneeded `'static` lifetimes on `&str`s stored in
`const` declarations.

This addresses some Clippy lints about
[`redundant_static_lifetimes`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_static_lifetimes).

In item-level `const` declarations we can rely on lifetime elision and
use the default `'static` lifetime.

Note that associated constants still require an explicit `'static`
lifetime, as explained in
https://github.com/rust-lang/rust/issues/115010.

Release Notes:

- N/A
 2024-03-02 00:40:49 -05:00
Conrad IrwinandMax 5523a510c5 Allow reconnect before disconnect (#8684) 
Co-Authored-By: Max <max@zed.dev>



Release Notes:

- Improved handling of reconnections during calls

---------

Co-authored-by: Max <max@zed.dev>
 2024-03-01 15:41:32 -07:00
Max BrunsfeldandConrad 9e4b3ce94c Avoid an unwrap when loading languages (#8562) 
We couldn't reproduce the panic, but I believe it was possible when
uninstalling an extension while one if its grammars was still loading.

Release Notes:
- Fixed a crash that could happen when uninstalling a language extension
while its grammar was loading.

---------

Co-authored-by: Conrad <conrad@zed.dev>
 2024-02-28 14:08:45 -08:00
Leon Huston b716035d02 Editor: support go to implementation (#7890) 
Release Notes:

- Added "Go to implementation" support in editor.
 2024-02-22 14:22:04 +01:00
Conrad Irwin 2294d99046 revert single channel click (#7738) 
- Revert "collab tweaks (#7706)"
- Revert "2112 (#7640)"
- Revert "single click channel (#7596)"
- Reserve protobufs
- Don't revert migrations

Release Notes:

- N/A

**or**

- N/A
 2024-02-13 12:53:49 -07:00
Conrad IrwinandNathan Sobo efe23ebfcd single click channel (#7596) 
- Open channel notes and chat on channel click
- WIP
- Fix compile error
- Don't join live kit until requested
- Track in_call state separately from in_room



Release Notes:

- Improved channels: you can now be in a channel without joining the
audio call automatically

**or**

- N/A

---------

Co-authored-by: Nathan Sobo <nathan@zed.dev>
 2024-02-09 14:18:27 -07:00
Max BrunsfeldandMarshall 1264e36429 Remove Default impl for ConnectionId (#7452) 
We noticed the following message in my logs when trying to debug some
lag when collaborating:

```
2024-02-06T09:42:09-08:00 [ERROR] error handling message. client_id:3, sender_id:Some(PeerId { owner_id: 327, id: 1123430 }), type:GetCompletions, error:no such connection: 0/0
```

That `0/0` looks like a bogus connection id, constructed via a derived
`Default`. We didn't ever find a code path that would *use* a default
`ConnectionId` and lead to this error, but it did seem like an
improvement to not have a `Default` for that type.

Release Notes:

- N/A

Co-authored-by: Marshall <marshall@zed.dev>
 2024-02-06 15:45:15 -05:00
Conrad IrwinPiotrMikayla
 		dcca48482b disallow opening private files (#7165) 
- Disallow sharing gitignored files through collab
- Show errors when failing to open files
- Show a warning to followers when view is unshared

/cc @mikaylamaki, let's update this to use your `private_files` config
before merge.


Release Notes:

- Added the ability to prevent sharing private files over collab.

---------

Co-authored-by: Piotr <piotr@zed.dev>
Co-authored-by: Mikayla <mikayla@zed.dev>
 2024-01-31 12:05:51 -08:00
Conrad Irwin b72c037199 TEMP 2024-01-25 13:24:45 -07:00
Conrad Irwin df420c3767 Better naming 2024-01-24 20:48:29 -07:00
Conrad Irwin 4bcd3494b7 Try to send typed errors back and forth 
TEMP

TEMP

First pass of structured errors

Improved error handling for channel joining failures
 2024-01-24 20:32:39 -07:00
Conrad Irwin 276bfa0fab Merge branch 'main' into guest-promotion 2024-01-09 16:28:42 -07:00
Piotr Osiewicz ab6cd1d93a chore: cfg(test) a test in rpc. (#3978) 
The test in particular should be included in our release binary at
present. :/
Release Notes:

- N/A
 2024-01-09 18:00:54 +01:00
Conrad Irwin 844d161c40 Allow adding write access to guests 2024-01-08 22:02:56 -07:00
Max Brunsfeld 18b31f1552 Check user is host for host-broadcasted project messages 2024-01-08 12:04:59 -08:00
Max BrunsfeldandMikayla 83f4c61657 Remove 2 suffix from gpui_macros, fix compile errors in tests 
Co-authored-by: Mikayla <mikayla@zed.dev>
 2024-01-03 13:12:21 -08:00
Max BrunsfeldandMikayla 5ddd298b4d Remove 2 suffix for fs, db, semantic_index, prettier 
Co-authored-by: Mikayla <mikayla@zed.dev>
 2024-01-03 12:09:42 -08:00
Kirill Bulatov 55374e8ac0 Port to gpui1 2023-12-11 12:28:22 +02:00
Kirill Bulatov 1f6c69c7dc Allow opening buffers without a project entry 2023-12-05 12:30:29 +02:00
Max Brunsfeld 2c5caf91bc Bump RPC version for channels + notifications changes 2023-10-25 17:37:14 +02:00
Max BrunsfeldConradKyleJoseph
 		5c03b6a610 Remove logic for multiple channel parents 
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Kyle <kyle@zed.dev>
Co-authored-by: Joseph <joseph@zed.dev>
 2023-10-24 17:29:23 +02:00
Max Brunsfeld 4a0358a513 Mark contact acceptance notifications as read automatically 2023-10-22 12:22:47 +02:00
Max Brunsfeld 851d7d0bc4 Rename NewNotification proto message to AddNotification 2023-10-19 13:29:14 -07:00
Max Brunsfeld b07f9fe3b5 Merge branch 'main' into notifications 2023-10-18 17:20:04 -07:00
Max Brunsfeld ee87ac2f9b Start work on chat mentions 2023-10-17 17:59:42 -07:00
Max Brunsfeld 660021f5e5 Fix more issues with the channels panel 
* Put the newest notifications at the top
* Have at most 1 notification toast, which is non-interactive,
  but focuses the notification panel on click, and auto-dismisses
  on a timer.
 2023-10-17 15:43:06 -07:00
Max Brunsfeld f2d36a47ae Generalize notifications' actor id to entity id 
This way, we can retrieve channel invite notifications when
responding to the invites.
 2023-10-17 10:34:50 -07:00
Max Brunsfeld f225039d36 Display invite response buttons inline in notification panel 2023-10-17 09:12:55 -07:00
Conrad Irwin 9cc55f895c Merge branch 'main' into guests 2023-10-17 09:54:17 -06:00
Max Brunsfeld 5a0afcc835 Simplify notification serialization 2023-10-13 16:09:46 -07:00
Max Brunsfeld 83fb8d20b7 Remove contact notifications when cancelling a contact request 2023-10-13 16:09:46 -07:00
Conrad Irwin f6f9b5c8cb Wire through public access toggle 2023-10-13 16:59:30 -06:00
Max Brunsfeld e590b43545 Merge branch 'main' into notifications 2023-10-13 11:31:53 -07:00
Max Brunsfeld bc6ba5f547 Bump protocol version 2023-10-13 11:23:39 -07:00
Max Brunsfeld 8db86dcebf Connect notification panel to notification toasts 2023-10-13 11:21:45 -07:00
Max Brunsfeld 034e9935d4 Remove old contact request notification mechanism, use notification instead 2023-10-12 17:42:32 -07:00
Max Brunsfeld 3241128840 Make notification db representation more flexible 2023-10-12 17:42:32 -07:00
Max Brunsfeld 69c65597d9 Fix use statement order 2023-10-12 17:41:09 -07:00
Max Brunsfeld d1756b621f Start work on notification panel 2023-10-12 17:41:09 -07:00
Max Brunsfeld 50cf25ae97 Add notification doc comments 2023-10-12 17:41:09 -07:00
Max Brunsfeld cf6ce0dbad Start work on storing notifications in the database 2023-10-12 17:41:07 -07:00
Conrad Irwin 540436a1f9 Push role refactoring through RPC/client 2023-10-12 13:05:54 -06:00
Julia 354882f2c0 Enable completion menu to resolve documentation when guest 2023-10-10 00:16:15 -04:00
Mikayla 32b4b4d24d Add message and operation ACK messages to protos 2023-10-02 17:10:03 -07:00
Max BrunsfeldConradAntonio
 		545b5e0161 Assign unique color indices to room participants, use those instead of replica_ids 
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
 2023-09-28 11:06:09 -07:00
Max Brunsfeld c71566e7f5 Make project id optional when following - server only 2023-09-21 13:14:15 -07:00
Mikayla 5f9c56c8b0 WIP: Send the channel name and the channel edges seperately, so we're not repeating them constantly 
This commit is currently broken and includes debug data for a failed attempt at rewriting the insert_edge logic
 2023-09-15 17:57:23 -07:00