oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
22,671 Commits 1 Branch 0 Tags
fe1078ef685d4e34ea079f779c2ac0c87ca806c9
Commit Graph
4 Commits
Author SHA1 Message Date
Thorsten BallandBennet 9d197ddc99 ssh remoting: Fix SSH connection not being closed (#18329) 
This fixes the `SshSession` being leaked.

There were two leaks:

1. `Arc<SshSession>` itself got leaked into the `SettingsObserver` that
   lives as long as the application. Fixed with a weak reference.
2. The two tasks spawned by an `SshSession` had a circular dependency
   and didn't exit while the other one was running. Fixed by fixing (1)
   and then attaching one of the tasks to the `SshSession`, which means
   it gets dropped with the session itself, which leads the other task
   to error and exit.

Co-authored-by: Bennet <bennet@zed.dev>

Release Notes:

- N/A

---------

Co-authored-by: Bennet <bennet@zed.dev>
 2024-09-25 12:03:24 +02:00
Stanislav Alekseev 8103ac12bf ssh-remoting: Tidy up the code a bit after #18094 (#18102) 
Release Notes:

- N/A
 2024-09-19 21:36:50 -06:00
Conrad IrwinandMikayla fbbf0393cb ssh-remoting: Fix go to definition out of worktree (#18094) 
Release Notes:

- ssh-remoting: Fixed go to definition outside of worktree

---------

Co-authored-by: Mikayla <mikayla@zed.dev>
 2024-09-19 14:04:46 -06:00
Max Brunsfeld 01bb10f518 Move ProtoClient to RPC crate, behind feature flag disabled in collab (#17908) 
This fixes a bug where we accidentally added a `gpui` transitive
dependency in `collab`.

Release Notes:

- N/A
 2024-09-16 14:50:30 -07:00