oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,281 Commits 1 Branch 0 Tags
e2ec96e44a54ab9bf02fa5a71ce35cd882bcf414
Commit Graph
217 Commits
Author SHA1 Message Date
Nathan Sobo 51d1d92d66 Attempt to return impl Element from render. 3 errors. 2024-01-01 14:23:02 +01:00
Marshall Bowers 0e145a8435 Make current call controls in title bar smaller (#3800) 
This PR adjusts the sizes of the current call controls in the title bar
to be smaller.

This matches the size of the other title bar items that are always
present.

Release Notes:

- N/A
 2023-12-22 19:32:07 -05:00
Piotr Osiewicz ca7e504817 titlebar: show "Share project" button only in local projects. (#3795) 
Fixes '"Share" button is shown even for remote projects'.

Release Notes:

- N/A
 2023-12-23 00:49:51 +01:00
Antonio Scandurra 30340535e9 Prevent panels from getting so small they can't be resized (#3788) 
This also switches to using `Pixels` instead of `f32` to store the panel
size everywhere.

Release Notes:

- N/A
 2023-12-22 18:37:13 +01:00
Antonio Scandurra 3715ddfa74 Use Pixels instead of f32 for panel size 2023-12-22 18:26:33 +01:00
Piotr Osiewicz dc1ed3c39d Titlebar project menu double click (#3784) 
This addresses a bug where popover menus in the titlebar were rendered
only after a 2nd click. The first click was creating the View which the
second one then rendered.
In addition to this, `PopoverMenu::menu` function argument can now
return an `Option<View<T>>` instead of `View<T>` as the creation of the
menu can fail (as it might in case of git popover).

Release Notes:

- N/A
 2023-12-22 17:18:12 +01:00
Antonio Scandurra 2f3b408880 Dismiss mention notification when x icon is clicked 
We were emitting the wrong kind of event, which caused the workspace
to never remove the notification.
 2023-12-22 15:12:01 +01:00
Antonio Scandurra 3de72f8366 Fix context menu in tab bar 2023-12-22 10:23:27 +01:00
Marshall Bowers 248458cef5 Indent contacts in collab panel (#3773) 
This PR indents contacts in the collab panel.

Release Notes:

- N/A
 2023-12-21 23:35:50 -05:00
Marshall Bowers cd9156886f Increase the indent step size for the collab panel (#3772) 
This PR increases the indent step size for the collab panel.

This gives the channel list a clearer hierarchy for nested channels, as
well as help align the disclosures with the parent channel's icon.

Release Notes:

- N/A
 2023-12-21 23:22:22 -05:00
Marshall Bowers 5307b75b2f Add more left padding to title bar (#3768) 
This PR adds more left padding to the title bar to achieve the same
positioning of the title bar items that we have in Zed1.

Release Notes:

- N/A
 2023-12-21 22:29:30 -05:00
Marshall Bowers 71a222abcb Use sparse spacing for ListItems in Pickers 2023-12-21 16:33:41 -05:00
Marshall Bowers dabc98690c Use small labels for title bar buttons (#3763) 
This PR adjusts the sizing of the labels in the buttons in the title bar
to use the small label size.

This should bring them more in line with how things looked in Zed1.

Release Notes:

- N/A
 2023-12-21 15:48:37 -05:00
Marshall Bowers 824b68788f Improve chat panel styling (#3758) 
This PR improves the chat panel styling, especially with regards to the
spacing.

Release Notes:

- N/A
 2023-12-21 12:15:11 -05:00
Max Brunsfeld afbc655100 Ensure that views' on_release callbacks are always called (#3747) 
* Ensure that views' on_release callbacks are always called (even if
their window is gone), by passing them a `AppContext`, not a
`WindowContext`.
* Fix leaked handles to `CollabPanel`, `NotificationPanel`, and
`ChatPanel` caused by captures in a `ListState` render callback.

This fixes two issues we were seeing with following:
* inability to rejoin a remote project after you closed it
* following not working if a window had previously been closed
 2023-12-20 16:45:37 -08:00
Max Brunsfeld 24970c1da9 Fix view handle leaks in ListState callbacks 2023-12-20 16:33:10 -08:00
Marshall Bowers 7b51f73826 Tighten up project share notifications 2023-12-20 16:06:59 -05:00
Marshall Bowers 9a06b7e77d Style incoming call notifications 2023-12-20 15:59:01 -05:00
Marshall Bowers c1df27c792 Style notification panel (#3741) 
This PR makes a first pass at styling the notification panel.

#### Signed out

<img width="381" alt="Screenshot 2023-12-20 at 11 41 25 AM"
src="https://github.com/zed-industries/zed/assets/1486634/f045fa17-4ebc-437f-a25b-d7695d47f18b">

#### No notifications

<img width="380" alt="Screenshot 2023-12-20 at 11 44 23 AM"
src="https://github.com/zed-industries/zed/assets/1486634/3a7543f2-8cd8-4788-8059-d5663f5f6b4c">

#### Notifications

<img width="386" alt="Screenshot 2023-12-20 at 1 27 08 PM"
src="https://github.com/zed-industries/zed/assets/1486634/13b81722-c47a-4c06-b37d-e6515cbfdb9d">

Release Notes:

- N/A
 2023-12-20 14:06:33 -05:00
Marshall Bowers da34dd49bb Fix text wrapping issues with overflow_hidden 
This seems to influence sizing calculations in ways I don't fully understand.
 2023-12-20 13:25:17 -05:00
Marshall Bowers b0b4610a73 Fix positioning of right items 2023-12-20 13:05:21 -05:00
Marshall Bowers 87f879bfa9 Add text wrapping to notifications 2023-12-20 12:48:30 -05:00
Marshall Bowers 9c4e8699ba Remove unneeded wrapping element 2023-12-20 12:45:18 -05:00
Marshall Bowers 636c12ec3f Style signed-out and empty states for the notification panel 2023-12-20 11:45:18 -05:00
Marshall Bowers 3886b1993d Fix formatting breakage 2023-12-20 11:41:51 -05:00
Marshall Bowers 5145795f33 Adjust styles for notification panel container 2023-12-20 11:27:28 -05:00
Kirill BulatovandAntonio Scandurra fe40e3920b Fix remaining z-index bugs 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-20 18:23:09 +02:00
Antonio Scandurra 6e1ba645f3 Show button as selected if screen sharing is on 2023-12-20 14:17:15 +01:00
Piotr Osiewicz 2f57a3ccfb Popover buttons titlebar (#3732) 
Migrate project picker/vcs menu to use popover_menu.

Release Notes:
- N/A
 2023-12-20 12:47:53 +01:00
Max Brunsfeld 599ec5c25b Make collab panel usable from the keyboard, add missing styling (#3724) 
* allow confirming all items via the keyboard
* allow deploying the channel context menu via the keyboard
* add missing selected styling for list items
 2023-12-19 14:33:56 -08:00
Max Brunsfeld afd3bf7746 Add missing selected state and keyboard action for some collab panel items 2023-12-19 14:16:44 -08:00
Max Brunsfeld 901795bcb9 Don't reset the collab panel when it loses focus 2023-12-19 14:12:29 -08:00
Kirill BulatovandAntonio Scandurra cf12d62fc5 Tidy up z-index handling 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-19 23:50:42 +02:00
Kirill BulatovandAntonio Scandurra 8f1c5375ef Fix more z-index and rendering issues 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-19 23:30:17 +02:00
Max BrunsfeldandNathan a9b1273e2b Clean up commented code 
Co-authored-by: Nathan <nathan@zed.dev>
 2023-12-19 12:06:47 -08:00
Max BrunsfeldandNathan 1c3698ae20 Implement channel modal 
Co-authored-by: Nathan <nathan@zed.dev>
 2023-12-19 12:02:35 -08:00
Max Brunsfeld 80b6922de7 wip 2023-12-19 10:20:40 -08:00
Max Brunsfeld a4bfd0147d Render channel invites in collab panel, fix unused warnings 2023-12-19 10:20:40 -08:00
Marshall Bowers a3bab25792 Style contact finder (#3717) 
This PR styles the contact finder.

<img width="598" alt="Screenshot 2023-12-19 at 12 59 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/ca9d9345-bf27-4256-aabc-6017a0c4d217">

Release Notes:

- N/A
 2023-12-19 13:16:14 -05:00
Antonio ScandurraandJulia dd84993d76 Maintain scroll position in CollabPanel after updating entries 
Co-Authored-By: Julia <julia@zed.dev>
 2023-12-19 16:06:00 +01:00
Marshall Bowers 91f1be213b Style project share notification (#3706) 
This PR styles the project share notification, so we're not staring a
red rectangle.

<img width="425" alt="Screenshot 2023-12-18 at 6 06 14 PM"
src="https://github.com/zed-industries/zed/assets/1486634/7ae9a2d3-d5d9-427c-9125-3a47df5f6a2f">

Release Notes:

- N/A
 2023-12-18 18:13:09 -05:00
Marshall Bowers 4fdf6a867a Wire up offline contact list (#3700) 
This PR wires up the offline contact list.

Also enables toggling both the online and offline contact lists.

Release Notes:

- N/A
 2023-12-18 13:54:11 -05:00
Nate Butler 9d014b0f9a Remove comment 2023-12-18 13:11:51 -05:00
Nate Butler 89b231afeb Update collab panel signed out state 2023-12-18 13:09:46 -05:00
Nate Butler 196df1c378 Start on collab panel empty state 2023-12-18 11:33:37 -05:00
Max Brunsfeld 29c6061a14 Fix following bugs (#3688) 
* Follow command didn't work, because follow task was dropped
* An extra div prevented titlebar facepiles from rendering correctly
 2023-12-15 16:34:08 -08:00
Max Brunsfeld b5ae2f060b Remove div around all avatars in titlebar facepile 2023-12-15 16:26:56 -08:00
Marshall Bowers 5447c6d5ee Fix channel filter input (#3686) 
This PR fixes the channel filter in the collab panel not showing up.

Release Notes:

- N/A
 2023-12-15 17:03:59 -05:00
Marshall Bowers 487edcb12b Rework collab panel rendering to use gpui::list (#3678) 
This PR reworks the rendering of the collab panel to use `gpui::list`,
so that we don't render any items that are not visible on the screen.

In the process we also fixed some bugs in the channel list:

- Fixed the context menu for channels not deploying when activated via
keyboard
- Fixed drag and drop for channels
- Made it so when navigating the collab panel via keyboard the list only
scrolls enough to reveal the next item when navigating to an item that
is currently off-screen

Release Notes:

- N/A
 2023-12-15 14:11:24 -05:00
Marshall Bowers 5c060ceb1c Format code 2023-12-15 14:03:49 -05:00