oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,385 Commits 1 Branch 0 Tags
df15d2d2feada0bd474d814fcd4514e8000be62c
Commit Graph
12 Commits
Author SHA1 Message Date
Lukas Wirth b7112320bb file_finder: Fix open path prompt creating wrong highlight indices (#40488) 
Fixes ZED-28R

Release Notes:

- Fixed open path prompt panicking on certain inputs
 2025-10-17 12:41:09 +00:00
Smit Barmase 22e31a0d41 Fix crash when filtering items in Picker (#37929) 
Closes #37617

We're already using `get` in a bunch of places, this PR updates the
remaining spots to follow the same pattern. Note that the `ix` we read
in `render_match` can sometimes be stale.

The likely reason is that we run the match-update logic asynchronously
(see
[here](https://github.com/zed-industries/zed/blob/138117e0b15664079f5526cb56168750382b49b9/crates/picker/src/picker.rs#L643)).
That means it's possible to render items after the list's [data
update](https://github.com/zed-industries/zed/blob/138117e0b15664079f5526cb56168750382b49b9/crates/picker/src/picker.rs#L652)
but before the [list
reset](https://github.com/zed-industries/zed/blob/138117e0b15664079f5526cb56168750382b49b9/crates/picker/src/picker.rs#L662),
in which case the `ix` can be greater than that of our updated data.

Release Notes:

- Fixed crash when filtering MCP tools.
 2025-09-10 23:06:09 +05:30
Piotr Osiewicz 9e0e233319 Fix clippy::needless_borrow lint violations (#36444) 
Release Notes:

- N/A
 2025-08-18 21:54:35 +00:00
Smit Barmase 131f2857a5 editor: Improve code completion filtering to provide fewer and more accurate suggestions (#32928) 
Closes #32756

- Uses `filter_text` from LSP source to filter items in completion list.
This fixes noisy lists like on typing `await` in Rust, it would suggest
`await.or`, `await.and`, etc., which are bad suggestions. Fallbacks to
label.
- Add `penalize_length` flag to fuzzy matcher, which was the default
behavior across. Now, this flag is set to `false` just for code
completion fuzzy matching. This fixes the case where if the query is
`unreac` and the completion items are `unreachable` and
`unreachable!()`, the item with a shorter length would have a larger
score than the other one, which is not right in the case of
auto-complete context. Now these two items will have the same fuzzy
score, and LSP `sort_text` will take over in finalizing its ranking.
- Updated test to be more utility based rather than example based. This
will help to iterate/verify logic faster on what's going on.

Before/After:

await: 
<img width="600" alt="before-await"
src="https://github.com/user-attachments/assets/384138dd-a90d-4942-a430-6ae15df37268"
/>
<img width="600" alt="after-await"
src="https://github.com/user-attachments/assets/d05a10fa-bae5-49bd-9fe7-9933ff215f29"
/>

iter:
<img width="600" alt="before-iter"
src="https://github.com/user-attachments/assets/6e57ffe9-007d-4b17-9cc2-d48fc0176c8e"
/>
<img width="600" alt="after-iter"
src="https://github.com/user-attachments/assets/a8577a9f-dcc8-4fd6-9ba0-b7590584ec31"
/>

opt:
<img width="600" alt="opt-before"
src="https://github.com/user-attachments/assets/d45b6c52-c9ee-4bf3-8552-d5e3fdbecbff"
/>
<img width="600" alt="opt-after"
src="https://github.com/user-attachments/assets/daac11a8-9699-48f8-b441-19fe9803848d"
/>

Release Notes:

- Improved code completion filtering to provide fewer and more accurate
suggestions.
 2025-06-18 16:01:28 +05:30
CharlesChen0823andCole Miller edd40566b7 git: Pick which remote to fetch (#26897) 
I don't want to fetch `--all` branch, we should can picker which remote
to fetch.

Release Notes:

- Added the `git::FetchFrom` action to fetch from a single remote.

---------

Co-authored-by: Cole Miller <cole@zed.dev>
 2025-06-06 11:28:07 -04:00
Joseph T. Lyons c208532693 Use read-only access methods for read-only entity operations (#31479) 
Another follow-up to #31254

Release Notes:

- N/A
 2025-05-26 23:04:31 -04:00
Piotr Osiewicz c6e2d20a02 chore: Bump Rust version to 1.86 (#28021) 
Closes #ISSUE

Release Notes:

- N/A
 2025-04-03 23:32:50 +02:00
Piotr Osiewicz dc64ec9cc8 chore: Bump Rust edition to 2024 (#27800) 
Follow-up to https://github.com/zed-industries/zed/pull/27791

Release Notes:

- N/A
 2025-03-31 20:55:27 +02:00
Mikayla Maki 1aefa5178b Move "async move" a few characters to the left in cx.spawn() (#26758) 
This is the core change:
https://github.com/zed-industries/zed/pull/26758/files#diff-044302c0d57147af17e68a0009fee3e8dcdfb4f32c27a915e70cfa80e987f765R1052

TODO:
- [x] Use AsyncFn instead of Fn() -> Future in GPUI spawn methods
- [x] Implement it in the whole app
- [x] Implement it in the debugger 
- [x] Glance at the RPC crate, and see if those box future methods can
be switched over. Answer: It can't directly, as you can't make an
AsyncFn* into a trait object. There's ways around that, but they're all
more complex than just keeping the code as is.
- [ ] Fix platform specific code

Release Notes:

- N/A
 2025-03-19 02:09:02 +00:00
Mikayla Maki 036c123488 Add git init button (#26522) 
Because why not

Release Notes:

- N/A
 2025-03-12 07:25:19 +00:00
Mikayla Makiandjulia 73ac19958a Add user-visible output for remote operations (#25849) 
This PR adds toasts for reporting success and errors from remote git
operations. This PR also adds a focus handle to notifications, in
anticipation of making them keyboard accessible.

Release Notes:

- N/A

---------

Co-authored-by: julia <julia@zed.dev>
 2025-03-03 09:20:15 +00:00
Mikayla MakiandMichael Sloan ff6844300e Git push/pull/fetch (#25445) 
Release Notes:

- N/A

---------

Co-authored-by: Michael Sloan <mgsloan@gmail.com>
 2025-02-24 18:29:52 +00:00