oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,179 Commits 1 Branch 0 Tags
dcd05ef96b774bc5e62940de8bcbdb70ff53bdfd
Commit Graph
116 Commits
Author SHA1 Message Date
Nathan Sobo 811696670a Start on a new FragmentList 
Here I'm exploring a new approach to the project-wide diagnostics view that can exactly mirror the contents of cargo check. The `FragmentList` composes an arbitrary list of fragments from other buffers and presents them as if they were a single buffer.
 2021-12-04 06:57:56 -07:00
Antonio ScandurraandNathan Sobo e668ff8bcd Avoid allocating a Patch just to check if there are no edits 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-12-01 16:47:04 +01:00
Antonio ScandurraandNathan Sobo 733e0cb21b Use the new buffer subscription API to keep DisplayMap in sync 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-12-01 16:08:53 +01:00
Antonio ScandurraandNathan Sobo 3b536f153f Introduce text::Buffer::subscribe 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-12-01 15:55:05 +01:00
Antonio Scandurra 47c467dafc Bump FoldMap's version in FoldMap::sync (and not in DisplayMap) 2021-12-01 12:05:02 +01:00
Max BrunsfeldandNathan Sobo faba276fdc WIP - maintain foldmap with Buffer::edits_since 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-30 17:23:02 -08:00
Max Brunsfeld 924e1578ea Use &Snapshot directly instead of impl Into<Content<'a>> 
The text::Buffer and its snapshot already used the same representation
for their content, so we can just make Buffer deref to a Snapshot.
 2021-11-30 13:32:11 -08:00
Nathan SoboandMax Brunsfeld 1445ce10b5 Name the root file of every crate after the crate to ease navigation 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2021-11-30 12:46:39 -07:00
Nathan SoboandMax Brunsfeld d3f28166cb Rename buffer crate to text and name its entrypoint after the crate 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2021-11-30 12:26:12 -07:00
Antonio Scandurra 9d7039ed51 Embed a plain text grammar and override settings for that too 2021-11-29 18:01:51 +01:00
Antonio ScandurraandNathan Sobo 2c17ae9aa6 Introduce a new Grammar struct and allow it to be optional 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-29 17:38:59 +01:00
Antonio ScandurraandNathan Sobo 2f43ef67fd Allow a single start/end bias per AnchorRangeMap 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-25 16:53:10 +01:00
Max Brunsfeld f0db748ba1 Implement toggle-comments 2021-11-23 14:13:28 -08:00
Nathan Sobo 2f39dee28b Use uniform biases in AnchorMap, AnchorRangeMap 
Specifying a different bias for every point makes the interface feel pretty unwieldy and we don't really use it.
 2021-11-22 15:30:46 -07:00
Max BrunsfeldandNathan Sobo 612b4404a9 Fix the bias of deserialized selection sets 
Fixes #224

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-22 14:14:48 -08:00
Antonio ScandurraandNathan Sobo b25c3eb740 Switch to a dense representation for clock::Global 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-22 17:20:43 +01:00
Antonio ScandurraandNathan Sobo 5094380c83 Enhance keyboard navigation when showing next diagnostic 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-18 16:55:18 +01:00
Antonio ScandurraandNathan Sobo 0e51365770 In a diagnostic group, mark the highest-severity diagnostic as primary 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-18 15:53:00 +01:00
Antonio ScandurraandNathan Sobo 0a6293bcda Support highlighting in blocks 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-18 14:08:21 +01:00
Nathan SoboandMax Brunsfeld 52a4c15c14 Eliminate non-highlighted chunks APIs 
Now we only have a single code path for chunks across all layers, but highlighting is optional and controlled by a flag.

Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2021-11-16 16:51:38 -08:00
Max BrunsfeldandNathan Sobo 8b1b35913a Fix group_ids assertions in diagnostics test 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-15 14:18:58 -08:00
Antonio Scandurra 4e32fabfdc Add text manipulation facilities to Rope for test purposes 2021-11-12 17:02:51 +01:00
Antonio ScandurraandNathan Sobo 2f4d8932dc Allow querying a diagnostic group by its id 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-04 15:16:59 +01:00
Antonio ScandurraandNathan Sobo 78bbb83448 Assign diagnostics a group_id based on their related_information 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-04 14:52:34 +01:00
Nathan Sobo 2d6285a6e1 Start on a test for grouped diagnostics 2021-11-03 18:47:18 -06:00
Max Brunsfeld baf636a4a4 Extend empty diagnostic ranges at the ends of lines 2021-11-03 13:49:39 -07:00
Max Brunsfeld 8b5089c759 In the status bar, show the diagnostic under the cursor 2021-11-03 12:33:16 -07:00
Antonio ScandurraandMax Brunsfeld c07d794249 Avoid ending the pending selection until updating selections 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2021-11-03 19:07:06 +01:00
Antonio ScandurraNathan SoboMax Brunsfeld
 		9dc3c74260 Make resolving selections generic 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2021-11-03 17:51:57 +01:00
Antonio Scandurra 20a77f4c5e Fix test for disk-based diagnostics 2021-11-03 09:39:15 +01:00
Max BrunsfeldandNathan Sobo 8d3f42de52 Start language servers based on buffers' languages 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-02 17:41:01 -07:00
Max Brunsfeld 89392cd23d Avoid using worktree handle in File's path methods 
This avoids a circular model update that was happening
when trying to retrieve the absolute path from a buffer's
file while applying remote operations.
 2021-11-02 14:33:55 -07:00
Max BrunsfeldandNathan Sobo 1995bd89a6 Deserialize buffer's diagnostics 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-02 12:29:03 -07:00
Max Brunsfeld 61e06487b7 Avoid circular model update when sending diagnostics operations 2021-11-01 17:14:22 -07:00
Max BrunsfeldandNathan Sobo 0e62ddbb65 Replicate diagnostics to remote buffers 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-01 15:28:37 -07:00
Max BrunsfeldandNathan Sobo 40c861c249 Move protobuf logic from buffer crate to language crate 
This will enable us to add operations that only pertain to the language crate.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-01 14:05:19 -07:00
Max Brunsfeld 78d97a3db2 Use Diagnostic struct in buffer's diagnostics multimap 2021-11-01 12:59:01 -07:00
Max BrunsfeldAntonio ScandurraNathan Sobo
 		1aee7bdb1d Delay quit until language servers are gracefully shut down 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-11-01 11:57:31 -07:00
Antonio Scandurra 6e5ec2a00d Take a &clock::Global instead of cloning in edits_since 2021-11-01 10:48:20 +01:00
Antonio Scandurra f59be5fecf Always notify when receiving buffer operations 
We had changed it to only emit a notification when the buffer was
actually edited, but we also want to notify when we receive non-edit
operations, such as a selection update.
 2021-11-01 10:06:23 +01:00
Antonio ScandurraandNathan Sobo b571eae4f3 Extend empty diagnostic ranges by one character 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-10-29 19:09:19 +02:00
Antonio ScandurraandNathan Sobo 6212ebad9b Communicate with language servers in terms of UTF-16 coordinates 
This required indexing UTF-16 positions in `Rope`. We tried opting
into the UTF-8 experimental support but it didn't seem to work
correctly and the standard is UTF-16 anyway.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-10-29 18:33:23 +02:00
Antonio Scandurra 9c1b01521a Avoid unnecessary conversion to offsets in diagnostics_in_range 2021-10-29 14:41:41 +02:00
Max Brunsfeld e1556893f7 Merge branch 'anchor-map-selections' into lsp 2021-10-28 17:08:06 -07:00
Max Brunsfeld a1e576343e Rename AnchorRangeSet::to_point_ranges -> point_ranges 2021-10-28 16:32:49 -07:00
Max Brunsfeld 9bc08e446b Fix unit test for on-disk-changes to not rely on selection bias 2021-10-28 16:17:07 -07:00
Antonio ScandurraandMax Brunsfeld ce8741977b Clip points coming from language server 
This avoids panicking in Zed if the points they give us are invalid.

Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2021-10-28 19:02:26 +02:00
Antonio ScandurraandMax Brunsfeld d12387b753 Ensure start endpoints always come before end endpoints 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2021-10-28 18:26:32 +02:00
Antonio Scandurra ee78d6f17b Express multi-cursor edits using the new coordinate space 
The language server expects that ranges further in the list of edits
account for the impact of prior changes in the edit list.
 2021-10-28 13:40:55 +02:00
Antonio Scandurra 7091e0c567 Add a unit test for disk-based diagnostics 2021-10-28 11:37:24 +02:00