Mikayla Maki
44969460cd
Remove remaining port related todos ( #3994 )
...
TODO:
- [x] Audit all TODO comments in Zed source and mark port related ones
with a !
- [x] Resolve all todos written as `todo!`
Release Notes:
- N/A
2024-01-10 17:31:05 -08:00
Conrad Irwin
766a869208
Fix fold-related panic
2024-01-10 15:51:13 -07:00
Mikayla
c98d7adf83
Audit all TODOs in Zed and mark port related todos
2024-01-10 11:26:11 -08:00
Piotr Osiewicz
282184a673
editor: Use inclusive ranges for git diff resolution. ( #3999 )
...
The culprit was in display map which was resolving next valid point for
the editor, without regard for whether that point belongs to the same excerpt. We now make an end point a minimum of the end point passed in and the start of excerpt header, if there are any.
This bug existed in Zed1 as well.
Fixes: Diff markers in multibuffer search overlap with dividers between
excepts (shouldn't extend all the way into the divider region)
Release Notes:
- Fixed diff markers being drawn incorrectly near headers in multibuffer
views.
2024-01-10 18:11:05 +01:00
Julia and Antonio Scandurra
463270ed36
Take into account multiple scroll deltas within a single frame
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2024-01-09 14:32:43 -05:00
Marshall Bowers
a8c193c7a6
Remove resolved TODO ( #3943 )
...
This PR removes a resolved TODO in drawing diff hunk status.
Release Notes:
- N/A
2024-01-08 13:08:44 -05:00
Marshall Bowers
46a99feb97
Use correct color for folded diff indicator ( #3942 )
...
This PR updates the indicator for changes within a fold to use the
correct color from the theme:
<img width="380" alt="Screenshot 2024-01-08 at 12 52 56 PM"
src="https://github.com/zed-industries/zed/assets/1486634/b8bf6bf3-6acc-43a4-8c4b-a02c975c7f02 ">
Release Notes:
- Updated the color of the indicator for a fold containing modified
lines.
2024-01-08 12:58:04 -05:00
Conrad Irwin
3c0052850c
Merge branch 'main' into channel-guests
2024-01-05 10:05:59 -07:00
Marshall Bowers
e4aa7ba4f2
Try to load fallback fonts instead of panicking when a font is not found ( #3891 )
...
This PR adjusts our font resolution code to attempt to use a fallback
font if the specified font cannot be found.
Right now our fallback font stack is `Zed Mono`, followed by `Helvetica`
(in practice we should always be able to resolve `Zed Mono` since we
bundle it with the app).
In the future we'll want to surface the ability to set the fallback font
stack from GPUI consumers, and potentially even support specifying font
stacks in the user settings (as opposed to a single font family).
Release Notes:
- Fixed a panic when trying to load a font that could not be found.
2024-01-04 14:10:46 -05:00
Antonio Scandurra and Marshall
6f4a08ba5a
Prevent scrolling editor and resizing panels at the same time
...
This fixes a bug that would cause Zed to never stop resizing
panels when the drag handle overlapped with an editor scrollbar.
Co-Authored-By: Marshall <marshall@zed.dev >
2024-01-04 17:25:02 +01:00
Antonio Scandurra
f0afa3f9e3
Show scrollbar even when buffer search highlights are outside viewport
2024-01-04 12:39:15 +01:00
Conrad Irwin
6877bd4969
Make read only buffers feel more read only
2024-01-03 19:31:43 -07:00
Max Brunsfeld and Mikayla
588976d27a
Remove 2 suffix for editor
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2024-01-03 10:58:57 -08:00
Conrad Irwin
9d07561d99
Merge branch 'main' into pixel-columns
2023-10-18 23:00:56 -06:00
Conrad Irwin
cb76b2a6ad
Make vim visual block work better
2023-10-18 22:23:06 -06:00
Julia
85332eacbd
Race completion filter w/completion request & make not block UI
2023-10-12 13:23:26 -04:00
Julia
4688a94a54
Allow file links in markdown & filter links a bit aggressively
2023-10-12 12:11:27 -04:00
Conrad Irwin
ab050d1890
Use Horizontal ranges everywhere
2023-10-09 21:48:50 -06:00
Conrad Irwin and Julia
dacc8cb5f4
Begin to use pixels for column selection
...
For zed-industries/community#759
For zed-industries/community#1966
Co-Authored-By: Julia <floc@unpromptedtirade.com >
2023-10-09 21:47:58 -06:00
Max Brunsfeld and Conrad
0c95e5a6ca
Fix coloring of local selections when following
...
Co-authored-by: Conrad <conrad@zed.dev >
2023-09-28 11:37:47 -07:00
Max Brunsfeld and Conrad
0f39b63801
Rename color_index to participant_index
...
Co-authored-by: Conrad <conrad@zed.dev >
2023-09-28 11:37:22 -07:00
545b5e0161
Assign unique color indices to room participants, use those instead of replica_ids
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Antonio <antonio@zed.dev >
2023-09-28 11:06:09 -07:00
Nate Butler
24974ee2fa
Unify icons using multiple variants, remove all unused icons
2023-09-15 12:50:49 -04:00
Nathan Sobo
e0fdc7d0aa
Eliminate PaintContext
2023-09-11 09:00:59 -06:00
Nathan Sobo
a24d94cfda
Eliminate LayoutContext
2023-09-11 08:47:00 -06:00
Nathan Sobo
ebf8b32811
Checkpoint
2023-09-08 16:25:10 -06:00
Nathan Sobo
53a50b8df4
Move refreshing to window
2023-09-08 13:27:29 -06:00
Nathan Sobo
5a778fbde6
Checkpoint
2023-09-06 14:16:15 -06:00
Nathan Sobo
2fa9c037c8
Merge remote-tracking branch 'origin' into storybook
2023-09-01 10:08:48 -06:00
Max Brunsfeld and Mikayla
e0bdd857f1
Fix cursor colors of non-followed collaborators
...
Co-authored-by: Mikayla <mikayla@zed.dev >
2023-08-30 14:14:18 -07:00
Nathan Sobo
48d3e2d9b9
Move views_to_notify_if_ancestors_change to Window
2023-08-29 21:58:44 -06:00
Nathan Sobo
2e7356a53e
Store new_parents on Window instead of layout context
2023-08-29 21:43:48 -06:00
Kirill Bulatov
81e70905bb
Do not allow cmd+click in invalid inlay context
2023-08-27 19:12:32 +03:00
Kirill Bulatov
665d86ea73
Defer navigation target buffer opening
2023-08-26 02:45:08 +03:00
Max Brunsfeld
d6ffb68305
Fix bugs in autoscroll with 'fit' strategy ( #2893 )
...
This fixes a bug where text moved up and down by one pixel in the buffer
search query editor, while typing.
Release notes:
* Fixed a bug where editors didn't auto-scroll when typing if all
cursors could not fit within the viewport.
2023-08-25 16:36:33 -07:00
Max Brunsfeld and Nathan
a3b2c03b17
Fix bugs in autoscroll with 'fit' strategy
...
* Scroll to the newest cursor if all cursors can't fit in the viewport.
* Refuse to layout an editor less tall than one line height.
Co-authored-by: Nathan <nathan@zed.dev >
2023-08-25 16:13:12 -07:00
Conrad Irwin
bde67b2b9c
Fix merge-conflict
2023-08-25 11:59:16 -06:00
Conrad Irwin
f18cdcba54
Fix relative line numbers in vim visual mode
...
In visual mode when your selection ends with a newline we show the
cursor at the end of the previous line (not the start of the current
line). We had only been accounting for this if the cursor was on-screen.
2023-08-25 11:50:41 -06:00
Conrad Irwin
8d5dc266a3
Fix relative line numbers when newest cursor offscreen
2023-08-25 11:50:41 -06:00
Conrad Irwin and
790aa5d476
Add relative_line_mode
...
Co-Authored-By: joseph@zed.dev
2023-08-25 11:50:41 -06:00
Kirill Bulatov
f19c659ed6
Add link_go_to_definition test for inlays
2023-08-25 14:26:17 +03:00
Kirill Bulatov
bcaff0a18a
Propagate inlay background highlights to data storage
2023-08-25 14:26:17 +03:00
Kirill Bulatov
420f8b7b15
Prepare for inlay and text highlight unification
2023-08-25 14:26:17 +03:00
Kirill Bulatov
f8874a726c
Attempt to highlight inlays
2023-08-25 14:26:17 +03:00
Kirill Bulatov
6c5761d05b
Pass inlay highlight information
2023-08-25 14:26:17 +03:00
Kirill Bulatov
477fc865f5
Properly resolve inlay label parts' locations and buffers
2023-08-25 14:26:17 +03:00
Kirill Bulatov
7eab18ec89
Pass inlay go to definition data
2023-08-25 14:26:17 +03:00
Kirill Bulatov
ac86bbac75
Prepare for hover functionality refactoring
2023-08-25 14:26:17 +03:00
Kirill Bulatov
80e8714241
Send inlay hint resolve requests
2023-08-25 14:26:17 +03:00
Kirill Bulatov
d1cb0b3c27
Properly detect hovered inlay hint label part
2023-08-25 14:26:17 +03:00