oak-team/oak-gpui
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,752 Commits 1 Branch 0 Tags
bbbdb9ff3e6cc90cf35c823e255cd694aa135af8
Commit Graph
698 Commits
Author SHA1 Message Date
Julia bbbdb9ff3e Render panel in this test to make sure it can receive focus 2023-12-14 17:11:00 -05:00
Julia cd08d349a5 Quick and dirty attempt to immediately apply focus change in tests 
Doesn't quite work yet
 2023-12-13 21:48:05 -05:00
JuliaandAntonio Scandurra cfc050e3fe Fire focus handlers on draw to avoid timing with newly created item 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2023-12-13 12:16:39 -05:00
Antonio Scandurra 13c064186a Fix regressions in focus and active support (#3622) 
Release Notes:

- N/A
 2023-12-13 11:31:37 +01:00
Antonio Scandurra d147db1db9 Don't mark interactive element as active if default prevented 2023-12-13 11:23:05 +01:00
Antonio Scandurra 5018072203 Automatically transfer focus on mouse down in Interactivity::paint 2023-12-13 09:57:18 +01:00
Conrad Irwin 19e842b860 fix overlay positions (#3621) 
- Fix typo in overlay positioning code
- Make overlay positioning more robust

Release Notes:

- N/A
 2023-12-12 22:13:56 -07:00
Conrad Irwin a055a4c163 Make overlay positioning more robust 
Previously we would either switch anchor or snap, now we first try switching
anchor (if desired) and then snap to window regardless.
 2023-12-12 21:28:58 -07:00
Conrad Irwin fa36adbf1f Fix typo in overlay positioning code 2023-12-12 21:14:48 -07:00
Max BrunsfeldNathanMarshall
 		6362221363 Scroll the tab bar to show the active tab 
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
 2023-12-12 15:42:33 -08:00
Max BrunsfeldNathanMarshall
 		a579713a45 Allow dragging and dropping tabs 
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Marshall <marshall@zed.dev>
 2023-12-12 15:07:03 -08:00
Max Brunsfeld a4a501603e Start work on dragging tabs 2023-12-12 15:04:49 -08:00
Antonio Scandurra e53b9f5ccf Fix Div::active not working 
Somehow a condition got inverted and caused the bug.
 2023-12-12 17:40:22 +01:00
Antonio Scandurra 35670368a5 Remove focus_listeners from Interactive 
We're not using these anymore.
 2023-12-12 17:39:07 +01:00
Antonio Scandurra c0846d6f74 Set cursor style only if we're the active window (#3607) 
Release Notes:

- N/A
 2023-12-12 16:56:32 +01:00
Antonio Scandurra b87c45e6f5 Set cursor style only if we're the active window 2023-12-12 16:32:45 +01:00
Kirill Bulatov 4684440202 Fix focus issues with gpui2 docks (#3606) 
* Fixed dock toggling not focusing the terminal element
* Fixed loosing focus on dock close (e.g. cmd-d on the last terminal in
the dock)
* Removed element stateless focus API since it would not work when the
element is not rendered, update all API usages to the stateful one via
`gpui::Subscription`

Release Notes:

- N/A
 2023-12-12 17:26:39 +02:00
Kirill BulatovandAntonio 0140bb862e Fix the tests 
Co-authored-by: Antonio <antonio@zed.dev>
 2023-12-12 17:19:12 +02:00
Kirill Bulatov ca8e8d1065 Finish removing all dangerous focus APIs 2023-12-12 16:11:14 +02:00
Antonio Scandurra 6159a59534 Fix assertions now that we use different hash functions 2023-12-12 14:59:51 +01:00
Kirill BulatovandAntonio 2cde1a2e15 Re-focus window on workspace on corresponding window blur 
Co-authored-by: Antonio <antonio@zed.dev>
 2023-12-12 15:36:20 +02:00
Kirill Bulatov 717b2885f8 Attempt to remove the dangeous element focus API 2023-12-12 15:07:27 +02:00
Antonio Scandurra 43b8d65fee Transfer focus to the workspace when window focus is lost 2023-12-12 15:07:27 +02:00
Antonio Scandurra b871f906d6 Use FxHashMap and FxHashSet in hot code paths 
We can also use these maps and sets in place of `SeaHasher` because
they are also deterministic. Note that we're not swapping std's
`HashMap` and `HashSet` wholesale inside of `collections` because
on the server we need cryptographically secure collections.
 2023-12-12 13:35:22 +01:00
Antonio Scandurra 385c830bef Make each DispatchNode smaller by allocating more 2023-12-12 13:16:09 +01:00
Antonio Scandurra f312c58b30 Reduce the stack size of Interactivity at the cost of more allocations 2023-12-12 11:57:44 +01:00
Antonio Scandurra e7094cc98d Don't move interactivity unnecessarily during layout 2023-12-12 09:43:33 +01:00
Max BrunsfeldandMikayla 6f5b1064ee Fix detection of topmost region under the dragged item 
Co-authored-by: Mikayla <mikayla@zed.dev>
 2023-12-11 16:50:44 -08:00
Conrad Irwin 149e90c3d9 vim2 (#3597) 
- MOAR TESTS

[[PR Description]]

Release Notes:

- N/A
 2023-12-11 16:42:03 -07:00
Conrad Irwin d12eb0581a vim2 (#3594) 
- First round of vim tests

Add `observe_keystrokes` back to gpui2
Allow multiple actions to match a given key event

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
 2023-12-11 15:06:51 -07:00
Conrad Irwin 1e89092d62 MOAR TESTS 2023-12-11 15:06:33 -07:00
Mikayla Maki 927d18b0f3 Add support for resizing splits and docks, as well as utilities (#3595) 
Making this PR to upstream changes to util and GPUI2, resizing exists
but isn't working yet.

Release Notes:

- N/A
 2023-12-11 13:32:06 -08:00
Mikayla f03c0f6e63 Add double click handling 2023-12-11 13:17:42 -08:00
Conrad Irwin d1805d8ada First round of vim tests 2023-12-11 14:16:25 -07:00
Max Brunsfeld fdcb413e33 Fix unused field warning 2023-12-11 12:56:18 -08:00
Max BrunsfeldandAntonio fbfe108317 Avoid double borrow in tests by drawing windows explicitly in flush_effects 
Co-authored-by: Antonio <antonio@zed.dev>
 2023-12-11 12:37:10 -08:00
Antonio ScandurraandMax Brunsfeld 9b94f1483a Redraw the window at the end of flush_effects in tests 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2023-12-11 20:10:27 +01:00
Antonio ScandurraandMax Brunsfeld f1ebad22db Defer drawing the scene until macOS's display_layer callback 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2023-12-11 19:55:55 +01:00
Mikayla 3198eb6c6d Merge branch 'main' into splits 2023-12-11 10:16:32 -08:00
Antonio Scandurra 76cea3e7e8 Fire click event only when using left button (#3584) 
Release Notes:

- N/A
 2023-12-11 18:00:13 +01:00
Conrad Irwin d678efe7dd Fix some action registrations 2023-12-11 09:29:10 -07:00
Antonio Scandurra 0b7072bf67 Fire click event only when using left button 2023-12-11 16:20:46 +01:00
Conrad Irwin c5367e3085 Correct docs re:Debug 2023-12-10 19:52:17 -07:00
Conrad Irwin 9ce7395b74 Restore impl_actions! and remove derive(Action) 2023-12-10 19:33:38 -07:00
Conrad Irwin 4290c67b6a Restore namespace parameter to actions! 
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
 2023-12-09 15:18:31 -07:00
Mikayla fd34d1da31 Add back semi-funcitonal pane resizing code 2023-12-08 16:29:42 -08:00
Max Brunsfeld fce0c1f4d0 Dedup actions in WindowContext::available_actions 2023-12-08 13:02:14 -08:00
Max Brunsfeld c739906413 Make chat message list fill the available space 2023-12-08 12:31:07 -08:00
Max Brunsfeld c7d8169cab Get the chat panel wired up again 2023-12-08 12:31:07 -08:00
Nathan Sobo 213ed2028c Get more of chat panel compiling, but lots of todos 2023-12-08 12:31:07 -08:00