oak-team/oak-gpui
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
33,443 Commits 1 Branch 0 Tags
b871130220054f942c74d8d570614c4ab97ea9b1
Commit Graph
5 Commits
Author SHA1 Message Date
John TurandLukas Wirth d83201256d Use shell to launch MCP and ACP servers (#42382) 
`npx`, and any `npm install`-ed programs, exist as batch
scripts/PowerShell scripts on the PATH. We have to use a shell to launch
these programs.

Fixes https://github.com/zed-industries/zed/issues/41435
Closes https://github.com/zed-industries/zed/pull/42651


Release Notes:

- windows: Custom MCP and ACP servers installed through `npm` now launch
correctly.

---------

Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
 2025-12-10 12:08:37 -05:00
Smit Barmase 95feefc1cf remote: Fix terminal crash on Elvish shell (#41893) 2025-11-04 17:48:42 +05:30
Jakub Konka bcbc6a330e Use ShellKind::try_quote whenever we need to quote shell args (#41104) 
Re-reverts
https://github.com/zed-industries/zed/commit/8f4646d6c357409cfc286104088b4d21f2bea851
with fixes

Release Notes:

- N/A
 2025-10-24 18:19:53 +02:00
Jakub Konka 023ac1b649 Revert "Use ShellKind::try_quote whenever we need to quote shell args" (#41022) 
Reverts zed-industries/zed#40912

Closes https://github.com/zed-industries/zed/issues/41010
 2025-10-23 16:06:47 +00:00
Jakub KonkaandLukas Wirth 8f4646d6c3 Use ShellKind::try_quote whenever we need to quote shell args (#40912) 
Using `shlex` unconditionally is dangerous as it assumes the underlying
shell is POSIX which is not the case for PowerShell, CMD, or Nushell.
Therefore, whenever we want to quote the args we should utilise our
helper `util::shell::ShellKind::try_quote` which takes into account
which shell is being used to actually exec/spawn the invocation.

Release Notes:

- N/A

---------

Co-authored-by: Lukas Wirth <me@lukaswirth.dev>
 2025-10-23 06:44:42 +02:00