oak-team/oak-gpui
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,489 Commits 1 Branch 0 Tags
a53c87edfedca9f636ba714e60366fe86153deea
Commit Graph
71 Commits
Author SHA1 Message Date
Antonio Scandurra 6b1f989c2b Omit worktree id when emitting Event::DiskBasedDiagnosticsUpdated 
Sometimes we will have more than one worktree associated with the same
language server and in that case it's unclear which worktree id we should
report an event for.
 2022-01-20 10:13:27 +01:00
Antonio Scandurra 71082d4cdc Return a Task<Result<()>> in {ItemView,Buffer,MultiBuffer}::save 2022-01-20 09:58:24 +01:00
Max Brunsfeld e56c043693 Get tests passing, centralize more diagnostic logic in Project 2022-01-19 16:32:55 -08:00
Max Brunsfeld f43dcd6763 Move logic for starting language servers to the project 2022-01-19 14:05:06 -08:00
Antonio ScandurraandMax Brunsfeld ae284c2d8a Route save_as via the Project 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2022-01-19 18:44:48 +01:00
Antonio Scandurra 9c9a09cccb Replace project_path with project_entry in workspace::{Item, ItemView} 2022-01-19 15:56:04 +01:00
Antonio Scandurra 18f1040c85 Rename Navigation to NavHistory 2022-01-19 15:27:34 +01:00
Antonio ScandurraandMax Brunsfeld ea624c6cde Populate backward/forward stacks upon item deactivation 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2022-01-17 18:57:31 +01:00
Antonio Scandurra 08c3fddc65 Allow splitting of project diagnostics 2022-01-13 10:24:41 +01:00
Max Brunsfeld ed88fdcea2 Add unit test for diagnostic + path header ordering 2022-01-12 11:34:57 -08:00
Max BrunsfeldandNathan Sobo 6ad9ff10c1 Ensure path headers appear before first diagnostic header 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-12 10:51:28 -08:00
Max Brunsfeld ac0d55222f Adjust project diagnostics test to reflect new block structure 2022-01-12 10:51:08 -08:00
Max Brunsfeld 9ccf2f3f58 Tweak theming of project diagnostics 2022-01-12 10:51:08 -08:00
Max Brunsfeld b5ee095da9 Deduplicate path names in the project diagnostics view 2022-01-12 10:51:08 -08:00
Max BrunsfeldandNathan Sobo a0a558318c In diagnostics editor, attempt to open excerpts in a different pane 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-10 16:33:25 -08:00
Max BrunsfeldandNathan Sobo 747d9e8784 Add files to project diagnostics view in order 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-10 16:17:56 -08:00
Antonio Scandurra 5c3ae8808b Fix diagnostic unit test assertions 2022-01-10 14:28:25 +01:00
Antonio Scandurra eb353648e6 🎨 2022-01-10 12:14:52 +01:00
Antonio Scandurra 1a53d5b7ba Use a new Workspace::activate_item API in project diagnostics 
Previously, we would only activate the pane without switching the
pane's *active item*.
 2022-01-10 10:10:11 +01:00
Max Brunsfeld f933d54469 When selections lose their excerpts, move them to the next primary diagnostic 2022-01-07 14:53:33 -08:00
Max BrunsfeldandNathan Sobo ce6f3d7f3e Reuse views when moving between diagnostic view and editors 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 11:00:12 -08:00
Max BrunsfeldandNathan Sobo ea263822fa Finish implementing ProjectDiagnostics::open_excerpts 
* Build workspace item views with a reference to the workspace
* Add randomized test for MultiBuffer::excerpted_buffers and fix a small bug

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 09:59:27 -08:00
Antonio ScandurraandNathan Sobo 794d214eee Refactor opening workspace items 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 17:38:37 +01:00
Antonio ScandurraandNathan Sobo 3cab32d201 WIP: Add keybinding to open buffers under cursors 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 16:12:50 +01:00
Antonio ScandurraandNathan Sobo cf62d26ed8 Display a "Checking..." message when running disk-based diagnostics 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 15:03:19 +01:00
Antonio ScandurraandNathan Sobo e39be35e17 Show status bar item for project diagnostic summary 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 14:14:21 +01:00
Max Brunsfeld 94e9c7fd5b Give a full-width background to the diagnostic headers 2022-01-06 17:55:56 -08:00
Max BrunsfeldandNathan Sobo b19d92e918 Keep selections at the top of the project diagnostics view when it is first populated 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 17:01:13 -08:00
Max Brunsfeld 7357b3ff2a Revert "Remove special handling of multi-line primary diagnostic messages and fix tests" 
This reverts commit ce4142eab3.
 2022-01-06 14:38:13 -08:00
Nathan SoboandAntonio Scandurra 571d0386e2 Re-focus diagnostics editor when transitioning from an empty to a populated state 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2022-01-06 08:35:31 -07:00
Antonio ScandurraandNathan Sobo 1875a0e349 Polish rendering of inline errors 
- Don't soft-wrap
- Render multiple lines

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 16:17:53 +01:00
Antonio Scandurra d0f7e5f075 Maintain excerpt ordering correctly when some errors don't change 2022-01-06 15:33:02 +01:00
Antonio Scandurra f37f839330 Wire up refresh_anchors in Editor::refresh_selections and call it 2022-01-06 15:32:37 +01:00
Antonio Scandurra 29b63ae4c6 Remove invalid excerpts as opposed to styling them differently 2022-01-05 18:21:17 +01:00
Antonio Scandurra fe28abe8cf Show a message when no diagnostics are available 2022-01-05 17:25:03 +01:00
Antonio ScandurraandMax Brunsfeld b2f0c78924 Merge branch 'main' into polish-project-diagnostics 
Co-Authored-By: Max Brunsfeld <max@zed.dev>
 2022-01-04 18:35:28 +01:00
Antonio Scandurra ad1db117e6 Re-enable cargo check for rust-analyzer 2022-01-04 18:26:16 +01:00
Antonio Scandurra 508b9dc024 Rip out "diagnostic providers" 2022-01-04 16:32:17 +01:00
Max Brunsfeld a080ae98c6 Allow the zed app to connect to both the old and new rpc endpoints 
In the case of the new Next.js app, the app will follow a redirect
from 'zed.dev/rpc' to the subdomain where the rust service is hosted.
Until then, the app will connect directly to zed.dev/rpc.
 2022-01-03 15:29:26 -08:00
Nathan Sobo ce4142eab3 Remove special handling of multi-line primary diagnostic messages and fix tests 2021-12-24 13:47:45 -07:00
Nathan Sobo a3df597155 Make diagnostics disk-based in test 2021-12-24 13:33:11 -07:00
Antonio Scandurra 11e3874b4a Remove duplication when assigning diagnostics and hardcode provider names 2021-12-24 12:07:26 +01:00
Max Brunsfeld 4f774e2bde wip 2021-12-23 23:10:28 -08:00
Max Brunsfeld d5a17053df Get code compiling with some todos 2021-12-23 14:21:10 -08:00
Antonio ScandurraandNathan Sobo b9d1ca4341 Show only disk-based diagnostics in ProjectDiagnosticsEditor 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-12-23 16:47:54 +01:00
Antonio ScandurraandNathan Sobo 304afc1813 Only preserve excerpts for invalid diagnostics if they contain cursors 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2021-12-23 16:33:50 +01:00
Antonio Scandurra dcf26acaac Use a different invalidation strategy for project-wide diagnostics 2021-12-23 15:41:43 +01:00
Max Brunsfeld 3e59c61a34 Use MultiBuffer::insert_excerpt_after to update project diagnostics view 2021-12-22 18:00:53 -08:00
Max Brunsfeld 2c3efdea8c WIP - Start work on updating project diagnostics view 2021-12-21 16:39:23 -08:00
Max Brunsfeld 04d577e326 Fix context line handline in project diagnostic view 2021-12-21 11:46:47 -08:00