Christian Clauss
cff2e8bbe0
Fix typos discovered by codespell
2024-01-25 18:32:32 +01:00
Conrad Irwin
f185aca25a
Use the correct snapshot when calculating mouse positions
2024-01-24 19:10:53 -07:00
Conrad Irwin
4e085b2052
Show hovered cursors less flickerily
2024-01-23 22:32:22 -07:00
Conrad Irwin
450cf9dd06
Fix rendering of diagnostic blocks
...
- Distinct colors to make it not confusing
- Avoid overflowing the edge of the editor when the message is long
2024-01-23 16:28:58 -07:00
Julia
f2eb78bbfc
Avoid overwriting mouse wheel scroll with selection auto-scroll ( #4207 )
...
Release Notes:
- Fixed an issue where mouse wheel events could be ignored while
selecting text near the top or bottom of the editor with the mouse.
2024-01-22 19:07:03 -05:00
Julia
a2aa47aba2
Avoid overwriting mouse wheel scroll with selection auto-scroll
2024-01-22 18:12:25 -05:00
Conrad Irwin
53b47c15ac
Hide editor hovers when a menu is open
2024-01-22 13:33:13 -07:00
Julia and Nathan Sobo
2c3d9805a4
Store a z-index id per-layer
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2024-01-22 10:16:59 -05:00
Kirill Bulatov
7aa3d9d1fb
Fix lightning bolt hover and git gutter mark overlapping
2024-01-22 16:01:32 +02:00
Mikayla
c05edee2b5
Port the rest of the app
2024-01-21 20:26:33 -08:00
Mikayla
33105486aa
Make platform input handler private
...
Automatically record the context on non-view input handlers
Simplify the async window context update() method
2024-01-20 06:56:19 -08:00
Max Brunsfeld
0858db9ebb
Autocomplete mentions ( #4171 )
...
Release Notes:
- Added autocomplete for @-mentions in the chat panel.
2024-01-19 17:03:56 -08:00
Max Brunsfeld
4fb3e6d812
Ensure editors context menus get at least 3 lines of height
2024-01-19 15:47:42 -08:00
Mikayla
eaa0e93112
Fix hover popovers showing up over zoomed panels
2024-01-19 14:52:49 -08:00
139986d080
Start work on autocomplete for chat mentions
...
Co-authored-by: Conrad <conrad@zed.dev >
Co-authored-by: Nathan <nathan@zed.dev >
Co-authored-by: Marshall <marshall@zed.dev >
2024-01-19 13:12:57 -08:00
Joseph T. Lyons
595428a8b1
Rename show cursors to display cursor names
2024-01-19 11:37:57 -05:00
Joseph T. Lyons
cb1b7915ee
Allow cursors to be shown via a command ( #4153 )
2024-01-19 11:09:49 -05:00
Joseph T. Lyons
bcc13e151c
Change struct field name
2024-01-19 07:52:28 -05:00
Kirill Bulatov
a4a0a02dc3
Avoid gutter resizes on line number increase/decrease ( #4135 )
2024-01-19 10:25:55 +02:00
Joseph T. Lyons
0062cc000b
Allow cursors to be shown via a command
2024-01-19 02:58:30 -05:00
Conrad Irwin
276032398b
Fix overflow in hover handler
2024-01-18 16:53:05 -07:00
Conrad Irwin
e513020fbb
Fine tune
2024-01-18 15:59:13 -07:00
Kirill Bulatov
bf8e57098d
Avoid gutter resizes on line number increase/decrease
...
Reserves 4 characters for the line number in the gutter to avoid editor bounds jumping when editing small files like commit messages.
2024-01-18 23:11:05 +02:00
Conrad Irwin
bfee008bb2
Merge branch 'main' into cursors
2024-01-18 14:03:27 -07:00
Mikayla Maki
933fb87013
Fix editor selection issue ( #4110 )
...
Release Notes:
- Fixes a bug where, editor selections would update in the wrong pane
when split.
2024-01-17 17:16:56 -08:00
Mikayla
edb204511c
Fix selection bug in editor causing selections to be un-ended
2024-01-17 16:30:01 -08:00
Mikayla
078fd35f4f
WIP
2024-01-17 15:52:54 -08:00
Piotr Osiewicz and Kirill
6cbc49e5f0
Editor docs ( #4097 )
...
Release Notes:
- N/A
---------
Co-authored-by: Kirill <kirill@zed.dev >
2024-01-18 00:48:37 +01:00
Conrad Irwin
ef0432da0d
Hide cursors by default, but show some
2024-01-17 10:14:20 -07:00
Conrad Irwin
0ca9f286c6
Show cursors for remote participants
2024-01-16 21:54:49 -07:00
1cbdf2ba22
Fix overlapping block headers when using custom line height
...
This fixes block headers overlapping over text in the buffer when using
a custom line height of 1.25.
It fixes the issue by making the parent container a v-flex,
vertically-justifying the content and moving from relative padding to
absolute padding for the header itself.
Co-authored-by: antonio <antonio@zed.dev >
Co-authored-by: julia <julia@zed.dev >
Co-authored-by: marshall <marshall@zed.dev >
2024-01-16 17:20:27 +01:00
Marshall Bowers
90f4c70a82
Rename h_stack and v_stack to h_flex and v_flex, respectively ( #4053 )
...
This PR renames the `h_stack` and `v_stack` to `h_flex` and `v_flex`,
respectively.
We were previously using `h_stack` and `v_stack` to match SwiftUI, but
`h_flex` and `v_flex` fit better with the web/flexbox terminology that
the rest of GPUI uses.
Additionally, we were already calling the utility functions used to
implement `h_stack` and `v_stack` by the new names.
Release Notes:
- N/A
2024-01-15 11:34:06 -05:00
Thorsten Ball
80c0d09b15
Fix editor stealing click events from copy-error button ( #4046 )
...
This fixes the click event on the "copy error message" button by
changing the `editor` element to ignore mouse-down events when the
default was prevented. That's similar to how `div` does it.
Release Notes:
- Fixed a bug that prevented "copy error message" button from being
clicked.
2024-01-15 14:03:15 +01:00
Thorsten Ball and Antonio
74f3366f42
Fix editor stealing click events from copy-error button
...
Co-authored-by: Antonio <antonio@zed.dev >
2024-01-15 13:47:09 +01:00
Antonio Scandurra
f4a7f6f4c3
Fix warning
2024-01-12 18:06:18 +01:00
817b641c17
Ensure editor elements invalidate their parent views on notify
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Conrad Irwin <conrad@zed.dev >
2024-01-12 17:36:11 +01:00
Antonio Scandurra
a32ad3f907
Fix editor tests
2024-01-12 14:50:42 +01:00
Max Brunsfeld
cb11fb68cb
Avoid bright green separators when displaying untitled buffers in multi-buffers ( #4024 )
...
Release notes:
- Fixed unstyled excerpt separators when showing untitled buffers in
multi-buffers.
2024-01-11 12:19:55 -08:00
Max Brunsfeld
5feae86900
Avoid bright green separators when displaying untitled buffers in multi-buffers
2024-01-11 09:55:16 -08:00
Piotr Osiewicz
0db7559e96
editor: extend diff hunk range for custom transform blocks. ( #4012 )
...
Reported by Mikayla:

Note how the line with rust analyzer error does not have a git diff
hunk.
vs:

Release Notes:
- N/A
2024-01-11 12:26:12 +01:00
Mikayla Maki
44969460cd
Remove remaining port related todos ( #3994 )
...
TODO:
- [x] Audit all TODO comments in Zed source and mark port related ones
with a !
- [x] Resolve all todos written as `todo!`
Release Notes:
- N/A
2024-01-10 17:31:05 -08:00
Conrad Irwin
766a869208
Fix fold-related panic
2024-01-10 15:51:13 -07:00
Mikayla
c98d7adf83
Audit all TODOs in Zed and mark port related todos
2024-01-10 11:26:11 -08:00
Piotr Osiewicz
282184a673
editor: Use inclusive ranges for git diff resolution. ( #3999 )
...
The culprit was in display map which was resolving next valid point for
the editor, without regard for whether that point belongs to the same excerpt. We now make an end point a minimum of the end point passed in and the start of excerpt header, if there are any.
This bug existed in Zed1 as well.
Fixes: Diff markers in multibuffer search overlap with dividers between
excepts (shouldn't extend all the way into the divider region)
Release Notes:
- Fixed diff markers being drawn incorrectly near headers in multibuffer
views.
2024-01-10 18:11:05 +01:00
Julia and Antonio Scandurra
463270ed36
Take into account multiple scroll deltas within a single frame
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev >
2024-01-09 14:32:43 -05:00
Marshall Bowers
a8c193c7a6
Remove resolved TODO ( #3943 )
...
This PR removes a resolved TODO in drawing diff hunk status.
Release Notes:
- N/A
2024-01-08 13:08:44 -05:00
Marshall Bowers
46a99feb97
Use correct color for folded diff indicator ( #3942 )
...
This PR updates the indicator for changes within a fold to use the
correct color from the theme:
<img width="380" alt="Screenshot 2024-01-08 at 12 52 56 PM"
src="https://github.com/zed-industries/zed/assets/1486634/b8bf6bf3-6acc-43a4-8c4b-a02c975c7f02 ">
Release Notes:
- Updated the color of the indicator for a fold containing modified
lines.
2024-01-08 12:58:04 -05:00
Conrad Irwin
3c0052850c
Merge branch 'main' into channel-guests
2024-01-05 10:05:59 -07:00
Marshall Bowers
e4aa7ba4f2
Try to load fallback fonts instead of panicking when a font is not found ( #3891 )
...
This PR adjusts our font resolution code to attempt to use a fallback
font if the specified font cannot be found.
Right now our fallback font stack is `Zed Mono`, followed by `Helvetica`
(in practice we should always be able to resolve `Zed Mono` since we
bundle it with the app).
In the future we'll want to surface the ability to set the fallback font
stack from GPUI consumers, and potentially even support specifying font
stacks in the user settings (as opposed to a single font family).
Release Notes:
- Fixed a panic when trying to load a font that could not be found.
2024-01-04 14:10:46 -05:00
Antonio Scandurra and Marshall
6f4a08ba5a
Prevent scrolling editor and resizing panels at the same time
...
This fixes a bug that would cause Zed to never stop resizing
panels when the drag handle overlapped with an editor scrollbar.
Co-Authored-By: Marshall <marshall@zed.dev >
2024-01-04 17:25:02 +01:00