oak-gpui

3 Commits

Include renames

Author SHA1 Message Date

Author	SHA1	Message	Date
Nate Butler	97512be378	Add wiring for UI density (#11260 ) Note: You shouldn't use the `unstable.ui_density` setting – it is only being added for testing and to enable new UI components to be built with density in mind. Don't expect this to work well, or at all right now. Adds some of the basic wiring we'll need to start scaling UI elements throughout the app based on a desired density setting. Release Notes: - N/A	2024-05-01 14:28:52 -04:00
Marshall Bowers	14a0d8039b	ui: Center `Checkbox` within its container (#9201 ) This PR fixes an issue with the `Checkbox` component where the checkbox wasn't being centered within its container element. The problem can be seen when applying a background color to the container element: #### Before <img width="439" alt="Screenshot 2024-03-11 at 5 44 10 PM" src="https://github.com/zed-industries/zed/assets/1486634/11704b1a-3c3e-4250-99c3-973fb442287a"> #### After <img width="447" alt="Screenshot 2024-03-11 at 5 45 59 PM" src="https://github.com/zed-industries/zed/assets/1486634/569a850b-4bd7-4711-8327-bf426fa5d265"> This resulted in issues where, under certain conditions, the checkbox could get cut off, as seen in #8868. Centering the checkbox fixes this issue: <img width="305" alt="Screenshot 2024-03-11 at 5 51 00 PM" src="https://github.com/zed-industries/zed/assets/1486634/14e5642f-59ad-4288-bc25-ea7da2a008a7"> Fixes #8868. Release Notes: - Fixed a positioning issue with checkboxes ([#8868](https://github.com/zed-industries/zed/issues/8868)).	2024-03-11 18:08:31 -04:00
Marshall Bowers	ef551cedef	Add `CheckboxWithLabel` component (#7881 ) This PR builds on top of #7878 by adding a general-purpose `CheckboxWithLabel` component to use for checkboxes that have attached labels. This component encompasses the functionality of allowing to click on the label to toggle the value of the checkbox. There was only one other occurrence of a checkbox with a label—the "Public" checkbox in the channel management modal—and this has been updated to use `CheckboxWithLabel`. Resolves #7794. Release Notes: - Added support for clicking the label of the "Public" checkbox in the channel management modal to toggle the value ([#7794](https://github.com/zed-industries/zed/issues/7794)).	2024-02-15 21:00:30 -05:00

97512be378

Add wiring for UI density (#11260 )

Note: You shouldn't use the `unstable.ui_density` setting – it is only
being added for testing and to enable new UI components to be built with
density in mind. Don't expect this to work well, or at all right now.

Adds some of the basic wiring we'll need to start scaling UI elements
throughout the app based on a desired density setting.

Release Notes:

- N/A

2024-05-01 14:28:52 -04:00

Marshall Bowers

14a0d8039b

ui: Center Checkbox within its container (#9201 )

This PR fixes an issue with the `Checkbox` component where the checkbox
wasn't being centered within its container element.

The problem can be seen when applying a background color to the
container element:

#### Before

<img width="439" alt="Screenshot 2024-03-11 at 5 44 10 PM"
src="https://github.com/zed-industries/zed/assets/1486634/11704b1a-3c3e-4250-99c3-973fb442287a">

#### After

<img width="447" alt="Screenshot 2024-03-11 at 5 45 59 PM"
src="https://github.com/zed-industries/zed/assets/1486634/569a850b-4bd7-4711-8327-bf426fa5d265">

This resulted in issues where, under certain conditions, the checkbox
could get cut off, as seen in #8868.

Centering the checkbox fixes this issue:

<img width="305" alt="Screenshot 2024-03-11 at 5 51 00 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14e5642f-59ad-4288-bc25-ea7da2a008a7">

Fixes #8868.

Release Notes:

- Fixed a positioning issue with checkboxes
([#8868](https://github.com/zed-industries/zed/issues/8868)).

2024-03-11 18:08:31 -04:00

Marshall Bowers

ef551cedef

Add CheckboxWithLabel component (#7881 )

This PR builds on top of #7878 by adding a general-purpose
`CheckboxWithLabel` component to use for checkboxes that have attached
labels.

This component encompasses the functionality of allowing to click on the
label to toggle the value of the checkbox.

There was only one other occurrence of a checkbox with a label—the
"Public" checkbox in the channel management modal—and this has been
updated to use `CheckboxWithLabel`.

Resolves #7794.

Release Notes:

- Added support for clicking the label of the "Public" checkbox in the
channel management modal to toggle the value
([#7794](https://github.com/zed-industries/zed/issues/7794)).

2024-02-15 21:00:30 -05:00